From e50a3215120053cad53f63c2b6d414523cd34a00 Mon Sep 17 00:00:00 2001 From: Kazuki Matsumoto Date: Tue, 19 Aug 2025 16:56:42 +0900 Subject: [PATCH 1/3] add debug symbol when debug build. fix android build script for debug --- BuildScripts~/build_libwebrtc_android.sh | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/BuildScripts~/build_libwebrtc_android.sh b/BuildScripts~/build_libwebrtc_android.sh index 61843f663a..3f6b4501ee 100755 --- a/BuildScripts~/build_libwebrtc_android.sh +++ b/BuildScripts~/build_libwebrtc_android.sh @@ -64,6 +64,10 @@ do for is_debug in "true" "false" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi # generate ninja files # use `treat_warnings_as_errors` option to avoid deprecation warnings gn gen "$OUTPUT_DIR" --root="src" \ @@ -79,7 +83,8 @@ do use_custom_libcxx=false \ treat_warnings_as_errors=false \ use_errorprone_java_compiler=false \ - use_cxx17=true" + use_cxx17=true \ + symbol_level=${symbol_level}" # build static library ninja -C "$OUTPUT_DIR" webrtc @@ -98,6 +103,10 @@ pushd src for is_debug in "true" "false" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi # use `treat_warnings_as_errors` option to avoid deprecation warnings "$PYTHON3_BIN" tools_webrtc/android/build_aar.py \ --build-dir $OUTPUT_DIR \ @@ -113,7 +122,8 @@ do use_custom_libcxx=false \ treat_warnings_as_errors=false \ use_errorprone_java_compiler=false \ - use_cxx17=true" + use_cxx17=true \ + symbol_level=${symbol_level}" filename="libwebrtc.aar" if [ $is_debug = "true" ]; then From 22bba017b3d9238e69312834894d34cadb44d0a5 Mon Sep 17 00:00:00 2001 From: Kazuki Matsumoto Date: Thu, 21 Aug 2025 14:04:23 +0900 Subject: [PATCH 2/3] set symbol_level in libwebrtc gn command --- BuildScripts~/build_libwebrtc_ios.sh | 7 ++++++- BuildScripts~/build_libwebrtc_linux.sh | 7 ++++++- BuildScripts~/build_libwebrtc_macos.sh | 7 ++++++- BuildScripts~/build_libwebrtc_win.cmd | 8 +++++++- 4 files changed, 25 insertions(+), 4 deletions(-) diff --git a/BuildScripts~/build_libwebrtc_ios.sh b/BuildScripts~/build_libwebrtc_ios.sh index 84ef9c0703..422a0ab25a 100755 --- a/BuildScripts~/build_libwebrtc_ios.sh +++ b/BuildScripts~/build_libwebrtc_ios.sh @@ -43,6 +43,10 @@ mkdir -p "$ARTIFACTS_DIR/lib" for is_debug in "true" "false" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi for target_cpu in "arm64" "x64" do # generate ninja files @@ -62,7 +66,8 @@ do ios_enable_code_signing=false \ rtc_include_tests=false \ rtc_build_examples=false \ - use_cxx17=true" + use_cxx17=true \ + symbol_level=${symbol_level}" # build static library ninja -C "$OUTPUT_DIR" webrtc diff --git a/BuildScripts~/build_libwebrtc_linux.sh b/BuildScripts~/build_libwebrtc_linux.sh index 2239939744..687d1a27d9 100755 --- a/BuildScripts~/build_libwebrtc_linux.sh +++ b/BuildScripts~/build_libwebrtc_linux.sh @@ -33,6 +33,10 @@ mkdir -p "$ARTIFACTS_DIR/lib" for target_cpu in "x64" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi mkdir -p "$ARTIFACTS_DIR/lib/${target_cpu}" for is_debug in "true" "false" do @@ -48,7 +52,8 @@ do is_component_build=false \ use_rtti=true \ rtc_use_x11=false \ - use_cxx17=true" + use_cxx17=true \ + symbol_level=${symbol_level}" if [ $is_debug = "true" ]; then args="${args} is_asan=true is_lsan=true"; diff --git a/BuildScripts~/build_libwebrtc_macos.sh b/BuildScripts~/build_libwebrtc_macos.sh index 25bd429390..73bf6f2f51 100755 --- a/BuildScripts~/build_libwebrtc_macos.sh +++ b/BuildScripts~/build_libwebrtc_macos.sh @@ -40,6 +40,10 @@ mkdir -p "$ARTIFACTS_DIR/lib" for is_debug in "true" "false" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi for target_cpu in "x64" "arm64" do @@ -57,7 +61,8 @@ do is_component_build=false \ use_rtti=true \ rtc_use_x11=false \ - use_cxx17=true" + use_cxx17=true \ + symbol_level=${symbol_level}" # build static library ninja -C "$OUTPUT_DIR" webrtc diff --git a/BuildScripts~/build_libwebrtc_win.cmd b/BuildScripts~/build_libwebrtc_win.cmd index 34dd7b7b78..23340dacbb 100644 --- a/BuildScripts~/build_libwebrtc_win.cmd +++ b/BuildScripts~/build_libwebrtc_win.cmd @@ -47,9 +47,15 @@ for %%i in (x64) do ( mkdir "%ARTIFACTS_DIR%/lib/%%i" for %%j in (true false) do ( + rem set symbol_level depending on is_debug + set symbol_level=0 + if %%j==true ( + set symbol_level=1 + ) + rem generate ninja for release call gn.bat gen %OUTPUT_DIR% --root="src" ^ - --args="is_debug=%%j is_clang=true target_cpu=\"%%i\" use_custom_libcxx=false rtc_include_tests=false rtc_build_examples=false rtc_use_h264=false symbol_level=0 enable_iterator_debugging=false use_cxx17=true" + --args="is_debug=%%j is_clang=true target_cpu=\"%%i\" use_custom_libcxx=false rtc_include_tests=false rtc_build_examples=false rtc_use_h264=false symbol_level=!symbol_level! enable_iterator_debugging=false use_cxx17=true" rem build call ninja.bat -C %OUTPUT_DIR% webrtc From 7a234044a0c4c03af0c159fc4b67752e48eae52e Mon Sep 17 00:00:00 2001 From: Kazuki Matsumoto Date: Thu, 21 Aug 2025 14:09:15 +0900 Subject: [PATCH 3/3] fix --- BuildScripts~/build_libwebrtc_linux.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BuildScripts~/build_libwebrtc_linux.sh b/BuildScripts~/build_libwebrtc_linux.sh index 687d1a27d9..bde1f09951 100755 --- a/BuildScripts~/build_libwebrtc_linux.sh +++ b/BuildScripts~/build_libwebrtc_linux.sh @@ -33,13 +33,13 @@ mkdir -p "$ARTIFACTS_DIR/lib" for target_cpu in "x64" do - symbol_level=0 - if [ $is_debug = "true" ]; then - symbol_level=1 - fi mkdir -p "$ARTIFACTS_DIR/lib/${target_cpu}" for is_debug in "true" "false" do + symbol_level=0 + if [ $is_debug = "true" ]; then + symbol_level=1 + fi args="is_debug=${is_debug} \ target_os=\"linux\" \ target_cpu=\"${target_cpu}\" \