Expect BadImageError on corrupted image

Author: adamtheturtle

tests/mock_vws/test_add_target.py

@@ -478,14 +478,21 @@ def test_corrupted(
         vws_client: VWS,
     ) -> None:
         """
-        No error is returned when the given image is corrupted.
+        An error is returned when the given image is corrupted.
         """
-        vws_client.add_target(
-            name="example_name",
-            width=1,
-            image=corrupted_image_file,
-            application_metadata=None,
-            active_flag=True,
+        with pytest.raises(expected_exception=BadImageError) as exc:
+            vws_client.add_target(
+                name="example_name",
+                width=1,
+                image=corrupted_image_file,
+                application_metadata=None,
+                active_flag=True,
+            )
+
+        assert_vws_failure(
+            response=exc.value.response,
+            status_code=HTTPStatus.UNPROCESSABLE_ENTITY,
+            result_code=ResultCodes.BAD_IMAGE,
         )
 
     @staticmethod

tests/mock_vws/test_get_target.py

@@ -146,7 +146,6 @@ def test_target_quality(
         vws_client: VWS,
         high_quality_image: io.BytesIO,
         image_file_success_state_low_rating: io.BytesIO,
-        corrupted_image_file: io.BytesIO,
     ) -> None:
         """
         The target tracking rating is as expected.
@@ -159,14 +158,9 @@ def test_target_quality(
             vws_client=vws_client,
             image_file=image_file_success_state_low_rating,
         )
-        corrupted_image_file_tracking_rating = _get_target_tracking_rating(
-            vws_client=vws_client,
-            image_file=corrupted_image_file,
-        )
         assert (
             high_quality_image_tracking_rating
             > low_quality_image_tracking_rating
-            >= corrupted_image_file_tracking_rating
         )
 
 

tests/mock_vws/test_update_target.py

@@ -670,12 +670,19 @@ def test_corrupted(
         target_id: str,
     ) -> None:
         """
-        No error is returned when the given image is corrupted.
+        An error is returned when the given image is corrupted.
         """
         vws_client.wait_for_target_processed(target_id=target_id)
-        vws_client.update_target(
-            target_id=target_id,
-            image=corrupted_image_file,
+        with pytest.raises(expected_exception=BadImageError) as exc:
+            vws_client.update_target(
+                target_id=target_id,
+                image=corrupted_image_file,
+            )
+
+        assert_vws_failure(
+            response=exc.value.response,
+            status_code=HTTPStatus.UNPROCESSABLE_ENTITY,
+            result_code=ResultCodes.BAD_IMAGE,
         )
 
     @staticmethod