Skip to content

Commit 690bb63

Browse files
Merge pull request #1507 from VWS-Python/redirect-link
Update link references given vuforia docs changes
2 parents 177d526 + 199191d commit 690bb63

File tree

9 files changed

+17
-20
lines changed

9 files changed

+17
-20
lines changed

docs/source/ci-setup.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ To avoid hitting request quotas and to avoid conflicts when running multiple tes
1111

1212
CI builds use a different credentials file depending on the build configuration.
1313
Within a workflow, this avoids conflicts.
14-
However, there may be conflicts across workflows, as currently there is no way to prevent workflows from running in parallel.
15-
See https://github.community/t5/GitHub-Actions/Prevent-parallel-workflows/td-p/32889.
16-
1714

1815
How to set GitHub Actions secrets
1916
---------------------------------

docs/source/contributing.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,13 @@ The database summary from ``GET /summary`` has multiple undocumented return fiel
143143

144144
The database summary from ``GET /summary`` is not immediately accurate.
145145

146-
The documentation page `How To Perform an Image Recognition Query`_ states that the ``Content-Type`` header must be set to ``multipart/form-data``.
146+
The documentation page `Vuforia Query Web API`_ states that the ``Content-Type`` header must be set to ``multipart/form-data``.
147147
However, it must be set to ``multipart/form-data; boundary=<BOUNDARY>`` where ``<BOUNDARY>`` is the boundary used when encoding the form data.
148148

149-
The documentation page `How To Perform an Image Recognition Query`_ states that ``Content-Type`` will be the only response header.
149+
The documentation page `Vuforia Query Web API`_ states that ``Content-Type`` will be the only response header.
150150
This is not the case.
151151

152-
The documentation page `How To Perform an Image Recognition Query`_ states that 10 is the maximum allowed value of ``max_num_results``.
152+
The documentation page `Vuforia Query Web API`_ states that 10 is the maximum allowed value of ``max_num_results``.
153153
However, the maximum allowed value is 50.
154154

155155
A response to an invalid query may have an ``application/json`` content type but include text (not JSON) data.
@@ -158,18 +158,18 @@ After deleting a target, for up to approximately 30 seconds, matching it with a
158158

159159
A target with the name ``\uffff`` gets stuck in processing.
160160

161-
The documentation page `How To Perform an Image Recognition Query`_ states that "The API accepts requests with unknown data fields, and ignore the unknown fields.".
161+
The documentation page `Vuforia Query Web API`_ states that "The API accepts requests with unknown data fields, and ignore the unknown fields.".
162162
This is not the case.
163163

164-
The documentation page `How To Perform an Image Recognition Query`_ states "Maximum image size: 2.1 MPixel. 512 KiB for JPEG, 2MiB for PNG".
164+
The documentation page `Vuforia Query Web API`_ states "Maximum image size: 2.1 MPixel. 512 KiB for JPEG, 2MiB for PNG".
165165
However, JPEG images up to 2MiB are accepted.
166166

167167
The ``request_count`` in a database summary is always ``0``.
168168

169169
The documentation for the target summary report says "Note: tracking_rating and ``reco_rating`` are provided only when status = success.".
170170
However, ``reco_rating`` is never provided and ``tracking_rating`` is provided even when the status is "failed".
171171

172-
.. _How To Perform an Image Recognition Query: https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query
172+
.. _Vuforia Query Web API: https://library.vuforia.com/web-api/vuforia-query-web-api
173173

174174
Release Process
175175
---------------

docs/source/differences-to-vws.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Result codes
9797
------------
9898

9999
Result codes are returned by requests to Vuforia to help with debugging.
100-
See `How To Interpret VWS API Result Codes <https://library.vuforia.com/articles/Solution/How-To-Use-the-Vuforia-Web-Services-API#How-To-Interperete-VWS-API-Result-Codes>`_ for details of the available result codes.
100+
See `VWS API Result Codes <https://library.vuforia.com/web-api/cloud-targets-web-services-api#result-codes>`_ for details of the available result codes.
101101
There are some result codes which the mock cannot return.
102102

103103
These are:

src/mock_vws/_constants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class ResultCodes(Enum):
1010
Constants representing various VWS result codes.
1111
1212
See
13-
https://library.vuforia.com/articles/Solution/How-To-Use-the-Vuforia-Web-Services-API.html#How-To-Interperete-VWS-API-Result-Codes
13+
https://library.vuforia.com/web-api/cloud-targets-web-services-api#result-codes.
1414
1515
Some codes here are not documented in the above link.
1616
"""

src/mock_vws/_flask_server/vwq.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
A fake implementation of the Vuforia Web Query API using Flask.
33
44
See
5-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query
5+
https://library.vuforia.com/web-api/vuforia-query-web-api
66
"""
77

88
import email.utils

src/mock_vws/_query_validators/image_validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def validate_image_file_size(
7070
image = parsed.get("image").raw
7171

7272
# This is the documented maximum size of a PNG as per.
73-
# https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query.
73+
# https://library.vuforia.com/web-api/vuforia-query-web-api.
7474
# However, the tests show that this maximum size also applies to JPEG
7575
# files.
7676
max_bytes = 2 * 1024 * 1024

src/mock_vws/_requests_mock_server/mock_web_query_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
A fake implementation of the Vuforia Web Query API.
33
44
See
5-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query
5+
https://library.vuforia.com/web-api/vuforia-query-web-api
66
"""
77

88
from __future__ import annotations

tests/mock_vws/test_query.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""
22
Tests for the mock of the query endpoint.
33
4-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query.
4+
https://library.vuforia.com/web-api/vuforia-query-web-api.
55
"""
66

77
from __future__ import annotations
@@ -738,7 +738,7 @@ def test_valid_accepted(
738738
This is because uploading 50 images would be very slow.
739739
740740
The documentation at
741-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query
741+
https://library.vuforia.com/web-api/vuforia-query-web-api
742742
states that this must be between 1 and 10, but in practice, 50 is the
743743
maximum.
744744
"""
@@ -792,7 +792,7 @@ def test_out_of_range(
792792
of the range (1, 50).
793793
794794
The documentation at
795-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query.
795+
https://library.vuforia.com/web-api/vuforia-query-web-api.
796796
states that this must be between 1 and 10, but in practice, 50 is the
797797
maximum.
798798
"""
@@ -1271,7 +1271,7 @@ def test_png(
12711271
) -> None: # pragma: no cover
12721272
"""
12731273
According to
1274-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query.
1274+
https://library.vuforia.com/web-api/vuforia-query-web-api.
12751275
the maximum file size is "2MiB for PNG".
12761276
12771277
Above this limit, a ``REQUEST_ENTITY_TOO_LARGE`` response is returned.
@@ -1352,7 +1352,7 @@ def test_jpeg(
13521352
) -> None: # pragma: no cover
13531353
"""
13541354
According to
1355-
https://library.vuforia.com/articles/Solution/How-To-Perform-an-Image-Recognition-Query.
1355+
https://library.vuforia.com/web-api/vuforia-query-web-api.
13561356
the maximum file size is "512 KiB for JPEG".
13571357
However, this test shows that the maximum size for JPEG is 2 MiB.
13581358

tests/mock_vws/utils/assertions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def assert_vws_response(
114114
"""
115115
Assert that a VWS response is as expected, at least in part.
116116
117-
https://library.vuforia.com/articles/Solution/How-To-Use-the-Vuforia-Web-Services-API.html#How-To-Interperete-VWS-API-Result-Codes
117+
https://library.vuforia.com/web-api/cloud-targets-web-services-api#result-codes
118118
implies that the expected status code can be worked out from the result
119119
code. However, this is not the case as the real results differ from the
120120
documentation.

0 commit comments

Comments
 (0)