Progress

Author: adamtheturtle

src/mock_vws/_flask_server/target_manager.py

@@ -5,7 +5,6 @@
 import base64
 import dataclasses
 import datetime
-import random
 from http import HTTPStatus
 from zoneinfo import ZoneInfo
 
@@ -212,12 +211,6 @@ def update_target(database_name: str, target_id: str) -> tuple[str, int]:
     if "image" in request.json:
         image_value = base64.b64decode(s=request.json["image"])
 
-    # In the real implementation, the tracking rating can stay the same.
-    # However, for demonstration purposes, the tracking rating changes but
-    # when the target is updated.
-    available_values = list(set(range(6)) - {target.tracking_rating})
-    processed_tracking_rating = random.choice(available_values)
-
     gmt = ZoneInfo("GMT")
     last_modified_date = datetime.datetime.now(tz=gmt)
 
@@ -228,7 +221,6 @@ def update_target(database_name: str, target_id: str) -> tuple[str, int]:
         active_flag=active_flag,
         application_metadata=application_metadata,
         image_value=image_value,
-        processed_tracking_rating=processed_tracking_rating,
         last_modified_date=last_modified_date,
     )
 

src/mock_vws/_requests_mock_server/mock_web_services_api.py

@@ -11,7 +11,6 @@
 import dataclasses
 import datetime
 import email.utils
-import random
 import uuid
 from http import HTTPStatus
 from typing import TYPE_CHECKING
@@ -590,11 +589,7 @@ def update_target(
             context.status_code = fail_exception.status_code
             return fail_exception.response_text
 
-        # In the real implementation, the tracking rating can stay the same.
-        # However, for demonstration purposes, the tracking rating changes but
-        # when the target is updated.
-        available_values = list(set(range(6)) - {target.tracking_rating})
-        processed_tracking_rating = random.choice(available_values)
+        # TODO: Consider the case of the code that was here
 
         gmt = ZoneInfo("GMT")
         last_modified_date = datetime.datetime.now(tz=gmt)
@@ -606,7 +601,6 @@ def update_target(
             active_flag=active_flag,
             application_metadata=application_metadata,
             image_value=image_value,
-            processed_tracking_rating=processed_tracking_rating,
             last_modified_date=last_modified_date,
         )
 

src/mock_vws/target.py

@@ -28,6 +28,7 @@ class TargetDict(TypedDict):
     image_base64: str
     active_flag: bool
     processing_time_seconds: int | float
+    processed_tracking_rating: int
     application_metadata: str | None
     target_id: str
     last_modified_date: str
@@ -50,6 +51,13 @@ def _time_now() -> datetime.datetime:
     return datetime.datetime.now(tz=gmt)
 
 
+def _random_tracking_rating() -> int:
+    """
+    Return a random tracking rating.
+    """
+    return random.randint(0, 5)
+
+
 @dataclass(frozen=True, eq=True)
 class Target:
     """
@@ -67,18 +75,14 @@ class Target:
     delete_date: datetime.datetime | None = None
     last_modified_date: datetime.datetime = field(default_factory=_time_now)
     previous_month_recos: int = 0
+    processed_tracking_rating: int = field(
+        default_factory=_random_tracking_rating,
+    )
     reco_rating: str = ""
     target_id: str = field(default_factory=_random_hex)
     total_recos: int = 0
     upload_date: datetime.datetime = field(default_factory=_time_now)
 
-    @staticmethod
-    def _tracking_rater(image_content: bytes) -> int:
-        """
-        Return a random tracking rating.
-        """
-        return random.randint(0, 5)
-
     @property
     def _post_processing_status(self) -> TargetStatuses:
         """
@@ -154,7 +158,7 @@ def tracking_rating(self) -> int:
             return -1
 
         if self._post_processing_status == TargetStatuses.SUCCESS:
-            return self._tracking_rater(image_content=self.image_value)
+            return self.processed_tracking_rating
 
         return 0
 
@@ -215,6 +219,7 @@ def to_dict(self) -> TargetDict:
             "image_base64": image_base64,
             "active_flag": self.active_flag,
             "processing_time_seconds": self.processing_time_seconds,
+            "processed_tracking_rating": self.processed_tracking_rating,
             "application_metadata": self.application_metadata,
             "target_id": self.target_id,
             "last_modified_date": self.last_modified_date.isoformat(),