Merge pull request #2813 from VWS-Python/add-pyrefly

Add pyrefly and pyrefly-docs configuration

Author: adamtheturtle

.pre-commit-config.yaml

@@ -38,6 +38,8 @@ ci:
     - vulture
     - vulture-docs
     - yamlfix
+    - pyrefly
+    - pyrefly-docs
 
 # See https://pre-commit.com for more information
 # See https://pre-commit.com/hooks.html for more hooks
@@ -389,3 +391,21 @@ repos:
         types_or: [rst]
         additional_dependencies: [uv==0.9.5]
         stages: [pre-commit]
+
+      - id: pyrefly
+        name: pyrefly
+        stages: [pre-push]
+        entry: uv run --extra=dev pyrefly check
+        language: python
+        types_or: [python, toml]
+        pass_filenames: false
+        additional_dependencies: [uv==0.9.5]
+
+      - id: pyrefly-docs
+        name: pyrefly-docs
+        stages: [pre-push]
+        entry: uv run --extra=dev doccmd --no-write-to-file --example-workers 0 --language=python
+          --command="pyrefly check"
+        language: python
+        types_or: [markdown, rst]
+        additional_dependencies: [uv==0.9.5]

admin/create_secrets_files.py

@@ -8,12 +8,16 @@
 import sys
 import textwrap
 from pathlib import Path
+from typing import TYPE_CHECKING
 
 import vws_web_tools
 from dotenv import load_dotenv
 from selenium import webdriver
 from selenium.common.exceptions import TimeoutException
 
+if TYPE_CHECKING:
+    from selenium.webdriver.remote.webdriver import WebDriver
+
 
 def main() -> None:
     """
@@ -37,7 +41,7 @@ def main() -> None:
         for i in range(num_databases)
     ]
     files_to_create = [file for file in required_files if not file.exists()]
-    driver = None
+    driver: WebDriver | None = None
 
     while files_to_create:
         if driver is None:

pyproject.toml

@@ -70,6 +70,7 @@ optional-dependencies.dev = [
     "pylint[spelling]==4.0.4",
     "pylint-per-file-ignores==3.2.0",
     "pyproject-fmt==2.11.1",
+    "pyrefly==0.46.1",
     "pyright==1.1.407",
     "pyroma==5.0.1",
     "pytest==9.0.2",
@@ -389,6 +390,12 @@ plugins = [
 ]
 follow_untyped_imports = true
 
+[tool.pyrefly]
+search_path = [
+    ".",
+    "src",
+]
+
 [tool.pyright]
 
 enableTypeIgnoreComments = false

spelling_private_dict.txt

@@ -74,6 +74,7 @@ plugins
 png
 pragma
 processable
+pyrefly
 pyright
 pytest
 readme

src/mock_vws/_flask_server/target_manager.py

@@ -248,7 +248,11 @@ def delete_target(database_name: str, target_id: str) -> Response:
     )
     target = database.get_target(target_id=target_id)
     now = datetime.datetime.now(tz=target.upload_date.tzinfo)
-    new_target = copy.replace(target, delete_date=now)
+    # See https://github.com/facebook/pyrefly/issues/1897
+    new_target = copy.replace(
+        target,  # pyrefly: ignore[bad-argument-type]
+        delete_date=now,
+    )
     database.targets.remove(target)
     database.targets.add(new_target)
     return Response(
@@ -289,8 +293,9 @@ def update_target(database_name: str, target_id: str) -> Response:
     gmt = ZoneInfo(key="GMT")
     last_modified_date = datetime.datetime.now(tz=gmt)
 
+    # See https://github.com/facebook/pyrefly/issues/1897
     new_target = copy.replace(
-        target,
+        target,  # pyrefly: ignore[bad-argument-type]
         name=name,
         width=width,
         active_flag=active_flag,

src/mock_vws/_requests_mock_server/mock_web_services_api.py

@@ -259,7 +259,11 @@ def delete_target(self, request: PreparedRequest) -> _ResponseType:
             )
 
         now = datetime.datetime.now(tz=target.upload_date.tzinfo)
-        new_target = copy.replace(target, delete_date=now)
+        # See https://github.com/facebook/pyrefly/issues/1897
+        new_target = copy.replace(
+            target,  # pyrefly: ignore[bad-argument-type]
+            delete_date=now,
+        )
         database.targets.remove(target)
         database.targets.add(new_target)
         date = email.utils.formatdate(
@@ -618,8 +622,9 @@ def update_target(self, request: PreparedRequest) -> _ResponseType:
         gmt = ZoneInfo(key="GMT")
         last_modified_date = datetime.datetime.now(tz=gmt)
 
+        # See https://github.com/facebook/pyrefly/issues/1897
         new_target = copy.replace(
-            target,
+            target,  # pyrefly: ignore[bad-argument-type]
             name=name,
             width=width,
             active_flag=active_flag,