Skip to content

Commit 0131d39

Browse files
Merge pull request #634 from adamtheturtle/reco-numbers-sumamry
Add test for recognition numbers
2 parents 1c73904 + 2690e71 commit 0131d39

File tree

2 files changed

+29
-5
lines changed

2 files changed

+29
-5
lines changed

src/mock_vws/_mock_web_services_api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -716,8 +716,8 @@ def target_summary(
716716
'upload_date': target.upload_date.strftime('%Y-%m-%d'),
717717
'active_flag': target.active_flag,
718718
'tracking_rating': target.tracking_rating,
719-
'total_recos': '',
720-
'current_month_recos': '',
721-
'previous_month_recos': '',
719+
'total_recos': 0,
720+
'current_month_recos': 0,
721+
'previous_month_recos': 0,
722722
}
723723
return json_dump(body)

tests/mock_vws/test_target_summary.py

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import io
88

99
import pytest
10+
import pytz
1011
from requests import codes
1112

1213
from mock_vws._constants import ResultCodes, TargetStatuses
@@ -39,7 +40,9 @@ def test_target_summary(
3940
image_data = png_rgb.read()
4041
image_data_encoded = base64.b64encode(image_data).decode('ascii')
4142

42-
date_before_add_target = datetime.datetime.now().date()
43+
gmt = pytz.timezone('GMT')
44+
45+
date_before_add_target = datetime.datetime.now(tz=gmt).date()
4346

4447
target_response = add_target_to_vws(
4548
vuforia_database_keys=vuforia_database_keys,
@@ -52,7 +55,7 @@ def test_target_summary(
5255

5356
target_id = target_response.json()['target_id']
5457

55-
date_after_add_target = datetime.datetime.now().date()
58+
date_after_add_target = datetime.datetime.now(tz=gmt).date()
5659

5760
response = target_summary(
5861
vuforia_database_keys=vuforia_database_keys,
@@ -95,6 +98,10 @@ def test_target_summary(
9598
# While processing the tracking rating is -1.
9699
assert response.json()['tracking_rating'] == -1
97100

101+
assert response.json()['total_recos'] == 0
102+
assert response.json()['current_month_recos'] == 0
103+
assert response.json()['previous_month_recos'] == 0
104+
98105
def test_after_processing(
99106
self,
100107
vuforia_database_keys: VuforiaDatabaseKeys,
@@ -140,6 +147,9 @@ def test_after_processing(
140147
assert response.json()['tracking_rating'] == tracking_rating
141148
assert response.json()['tracking_rating'] in range(6)
142149
assert response.json()['status'] == TargetStatuses.FAILED.value
150+
assert response.json()['total_recos'] == 0
151+
assert response.json()['current_month_recos'] == 0
152+
assert response.json()['previous_month_recos'] == 0
143153

144154

145155
@pytest.mark.usefixtures('verify_mock_vuforia')
@@ -177,3 +187,17 @@ def test_active_flag(
177187
target_id=target_id,
178188
)
179189
assert response.json()['active_flag'] == active_flag
190+
191+
192+
@pytest.mark.usefixtures('verify_mock_vuforia')
193+
class TestRecognitionCounts:
194+
"""
195+
Tests for the recognition counts in the summary.
196+
"""
197+
198+
def test_recognition(self) -> None:
199+
"""
200+
See https://github.com/adamtheturtle/vws-python/issues/357 for
201+
implementing this.
202+
"""
203+
pass

0 commit comments

Comments
 (0)