Skip to content

Commit 2c2c8bb

Browse files
Merge pull request #648 from adamtheturtle/fewer-preps
Use CaseInsensitiveDicts to remove type ignores
2 parents 503486c + 123e389 commit 2c2c8bb

File tree

6 files changed

+18
-38
lines changed

6 files changed

+18
-38
lines changed

tests/mock_vws/test_add_target.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ def test_name_valid(
253253
(None, codes.BAD_REQUEST),
254254
(chr(_MAX_CHAR_VALUE + 1), codes.INTERNAL_SERVER_ERROR),
255255
(
256-
chr(_MAX_CHAR_VALUE + 1) *
257-
(_MAX_NAME_LENGTH + 1), codes.BAD_REQUEST,
256+
chr(_MAX_CHAR_VALUE + 1) * (_MAX_NAME_LENGTH + 1),
257+
codes.BAD_REQUEST,
258258
),
259259
],
260260
ids=[

tests/mock_vws/test_authorization_header.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import pytest
99
import requests
1010
from requests import codes
11+
from requests.structures import CaseInsensitiveDict
1112

1213
from mock_vws._constants import ResultCodes
1314
from tests.mock_vws.utils import Endpoint
@@ -39,9 +40,7 @@ def test_missing(self, endpoint: Endpoint) -> None:
3940

4041
headers.pop('Authorization', None)
4142

42-
endpoint.prepared_request.prepare_headers( # type: ignore
43-
headers=headers,
44-
)
43+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
4544
session = requests.Session()
4645
response = session.send( # type: ignore
4746
request=endpoint.prepared_request,
@@ -77,9 +76,7 @@ def test_incorrect(self, endpoint: Endpoint) -> None:
7776
'Date': date,
7877
}
7978

80-
endpoint.prepared_request.prepare_headers( # type: ignore
81-
headers=headers,
82-
)
79+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
8380
session = requests.Session()
8481
response = session.send( # type: ignore
8582
request=endpoint.prepared_request,

tests/mock_vws/test_date_header.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import requests
1212
from freezegun import freeze_time
1313
from requests import codes
14+
from requests.structures import CaseInsensitiveDict
1415

1516
from mock_vws._constants import ResultCodes
1617
from tests.mock_vws.utils import Endpoint
@@ -62,10 +63,7 @@ def test_no_date_header(
6263
'Authorization': authorization_string,
6364
}
6465
headers.pop('Date', None)
65-
66-
endpoint.prepared_request.prepare_headers( # type: ignore
67-
headers=headers,
68-
)
66+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
6967
session = requests.Session()
7068
response = session.send( # type: ignore
7169
request=endpoint.prepared_request,
@@ -135,9 +133,7 @@ def test_incorrect_date_format(
135133
'Date': date_incorrect_format,
136134
}
137135

138-
endpoint.prepared_request.prepare_headers( # type: ignore
139-
headers=headers,
140-
)
136+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
141137
session = requests.Session()
142138
response = session.send( # type: ignore
143139
request=endpoint.prepared_request,
@@ -218,9 +214,7 @@ def test_date_out_of_range(
218214
'Date': date,
219215
}
220216

221-
endpoint.prepared_request.prepare_headers( # type: ignore
222-
headers=headers,
223-
)
217+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
224218
session = requests.Session()
225219
response = session.send( # type: ignore
226220
request=endpoint.prepared_request,
@@ -282,9 +276,7 @@ def test_date_in_range(
282276
'Date': date,
283277
}
284278

285-
endpoint.prepared_request.prepare_headers( # type: ignore
286-
headers=headers,
287-
)
279+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
288280
session = requests.Session()
289281
response = session.send( # type: ignore
290282
request=endpoint.prepared_request,

tests/mock_vws/test_invalid_json.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import requests
1111
from freezegun import freeze_time
1212
from requests import codes
13+
from requests.structures import CaseInsensitiveDict
1314

1415
from mock_vws._constants import ResultCodes
1516
from tests.mock_vws.utils import Endpoint
@@ -66,14 +67,8 @@ def test_invalid_json(
6667
'Date': date,
6768
}
6869

69-
endpoint.prepared_request.prepare_body( # type: ignore
70-
data=content,
71-
files=None,
72-
)
73-
74-
endpoint.prepared_request.prepare_headers( # type: ignore
75-
headers=headers,
76-
)
70+
endpoint.prepared_request.body = content
71+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
7772
endpoint.prepared_request.prepare_content_length( # type: ignore
7873
body=content,
7974
)

tests/mock_vws/test_unexpected_json.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import pytest
99
import requests
1010
from requests import codes
11+
from requests.structures import CaseInsensitiveDict
1112

1213
from mock_vws._constants import ResultCodes
1314
from tests.mock_vws.utils import Endpoint
@@ -62,13 +63,8 @@ def test_does_not_take_data(
6263
'Content-Type': content_type,
6364
}
6465

65-
endpoint.prepared_request.prepare_body( # type: ignore
66-
data=content,
67-
files=None,
68-
)
69-
endpoint.prepared_request.prepare_headers( # type: ignore
70-
headers=headers,
71-
)
66+
endpoint.prepared_request.body = content
67+
endpoint.prepared_request.headers = CaseInsensitiveDict(data=headers)
7268
endpoint.prepared_request.prepare_content_length( # type: ignore
7369
body=content,
7470
)

tests/mock_vws/test_update_target.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,8 @@ def test_name_valid(
538538
(None, codes.BAD_REQUEST),
539539
(chr(_MAX_CHAR_VALUE + 1), codes.INTERNAL_SERVER_ERROR),
540540
(
541-
chr(_MAX_CHAR_VALUE + 1) *
542-
(_MAX_NAME_LENGTH + 1), codes.BAD_REQUEST,
541+
chr(_MAX_CHAR_VALUE + 1) * (_MAX_NAME_LENGTH + 1),
542+
codes.BAD_REQUEST,
543543
),
544544
],
545545
ids=[

0 commit comments

Comments
 (0)