Use ids for metadata length test

Author: adamtheturtle

src/mock_vws/_mock_web_services_api.py

@@ -39,6 +39,7 @@
     validate_image_size,
     validate_keys,
     validate_metadata_encoding,
+    validate_metadata_size,
     validate_metadata_type,
     validate_name,
     validate_not_invalid_json,
@@ -155,6 +156,7 @@ def decorator(method: Callable[..., str]) -> Callable[..., str]:
             decorators = [
                 parse_target_id,
                 validate_authorization,
+                validate_metadata_size,
                 validate_metadata_encoding,
                 validate_metadata_type,
                 validate_active_flag,

src/mock_vws/_validators.py

@@ -872,3 +872,46 @@ def validate_metadata_type(
         'result_code': ResultCodes.FAIL.value,
     }
     return json_dump(body)
+
+
+@wrapt.decorator
+def validate_metadata_size(
+    wrapped: Callable[..., str],
+    instance: Any,  # pylint: disable=unused-argument
+    args: Tuple[_RequestObjectProxy, _Context],
+    kwargs: Dict,
+) -> str:
+    """
+    Validate that the given application metadata is a string or 1024 * 1024
+    bytes or fewer.
+
+    Args:
+        wrapped: An endpoint function for `requests_mock`.
+        instance: The class that the endpoint function is in.
+        args: The arguments given to the endpoint function.
+        kwargs: The keyword arguments given to the endpoint function.
+
+    Returns:
+        The result of calling the endpoint.
+        An `UNPROCESSABLE_ENTITY` response if application metadata is given and
+        it is too large.
+    """
+    request, context = args
+
+    if not request.text:
+        return wrapped(*args, **kwargs)
+
+    application_metadata = request.json().get('application_metadata')
+    if application_metadata is None:
+        return wrapped(*args, **kwargs)
+    decoded = base64.b64decode(application_metadata)
+
+    if len(decoded) <= 1024 * 1024:
+        return wrapped(*args, **kwargs)
+
+    context.status_code = codes.UNPROCESSABLE_ENTITY
+    body = {
+        'transaction_id': uuid.uuid4().hex,
+        'result_code': ResultCodes.METADATA_TOO_LARGE.value,
+    }
+    return json_dump(body)

tests/mock_vws/test_add_target.py

@@ -646,12 +646,11 @@ class TestApplicationMetadata:
     """
 
     @pytest.mark.parametrize(
-        'metadata',
-        [
+        'metadata', [
             b'a',
-            # This is the maximum metadata length.
             b'a' * (1024 * 1024),
         ],
+        ids=['Short', 'Max length']
     )
     def test_base64_encoded(
         self,
@@ -775,7 +774,6 @@ def test_not_base64_encoded(
             result_code=ResultCodes.FAIL,
         )
 
-
     def test_metadata_too_large(
         self,
         vuforia_database_keys: VuforiaDatabaseKeys,