Support bad credentials

Author: adamtheturtle

src/vws/query.py

@@ -8,6 +8,8 @@
 from vws.exceptions import MaxNumResultsOutOfRange
 
 from ._authorization import authorization_header, rfc_1123_date
+# TODO this cannot be private...
+from .vws import _raise_for_result_code
 
 
 class CloudRecoService:
@@ -74,8 +76,8 @@ def query(
             data=content,
         )
 
-        try:
-            return response.json()['results']
-        except json.decoder.JSONDecodeError:
-            if 'Accepted range is from 1 to 50 (inclusive).' in response.text:
-                raise MaxNumResultsOutOfRange(response=response)
+        if 'Accepted range is from 1 to 50 (inclusive).' in response.text:
+            raise MaxNumResultsOutOfRange(response=response)
+
+        _raise_for_result_code(response=response, expected_result_code='Success')
+        return response.json()['results']

tests/test_query.py

@@ -4,11 +4,12 @@
 
 import io
 import uuid
+from requests import codes
 
 import pytest
 
 from vws import VWS, CloudRecoService
-from vws.exceptions import MaxNumResultsOutOfRange
+from vws.exceptions import AuthenticationFailure, MaxNumResultsOutOfRange
 
 
 class TestQuery:
@@ -125,9 +126,20 @@ def test_too_many(
         )
         assert str(exc.value) == expected_value
 
+class TestBadCredentials:
+
+    def test_bad_credentials(self, high_quality_image: io.BytesIO):
+        cloud_reco_client = CloudRecoService(
+            client_access_key='a',
+            client_secret_key='a',
+        )
+        with pytest.raises(AuthenticationFailure) as exc:
+            cloud_reco_client.query(image=high_quality_image)
+
+        assert exc.value.response.status_code == codes.UNAUTHORIZED
+
 
 # TODO test custom base URL
-# TODO test bad credentials
 # TODO test options - include_target_data
 
 # TODO do we give an image type? Infer it?