Skip to content

Commit 7df2db4

Browse files
committed
Fix lint
1 parent 4fcb601 commit 7df2db4

File tree

4 files changed

+22
-15
lines changed

4 files changed

+22
-15
lines changed

src/mock_vws/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ def __init__( # pylint: disable=too-many-arguments
5757
deterministic.
5858
base_vwq_url: The base URL for the VWQ API.
5959
base_vws_url: The base URL for the VWS API.
60+
query_recognizes_deletion_seconds: The number of seconds after a
61+
target has been deleted that the query endpoint will return a
62+
500 response for on a match.
6063
6164
6265
Attributes:
@@ -122,7 +125,7 @@ def __enter__(self) -> 'MockVWS':
122125
mock_web_services_api=mock_vws_api,
123126
query_recognizes_deletion_seconds=(
124127
self._query_recognizes_deletion_seconds
125-
)
128+
),
126129
)
127130

128131
date = email.utils.formatdate(None, localtime=False, usegmt=True)

src/mock_vws/_mock_web_query_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io
1111
import uuid
1212
from pathlib import Path
13-
from typing import Any, Callable, Dict, List, Set, Tuple
13+
from typing import Any, Callable, Dict, List, Set, Tuple, Union
1414

1515
import pytz
1616
import wrapt
@@ -449,7 +449,7 @@ def __init__(
449449
client_access_key: str,
450450
client_secret_key: str,
451451
mock_web_services_api: MockVuforiaWebServicesAPI,
452-
query_recognizes_deletion_seconds: int,
452+
query_recognizes_deletion_seconds: Union[int, float],
453453
) -> None:
454454
"""
455455
Args:

tests/mock_vws/test_usage.py

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -433,11 +433,11 @@ class TestCustomQueryRecognizesDeletionSeconds:
433433
until it is not recognized by the query endpoint.
434434
"""
435435

436-
def _seconds_to_recognize_deletion(
436+
def _recognize_deletion_seconds(
437437
self,
438438
high_quality_image: io.BytesIO,
439439
vuforia_database_keys: VuforiaDatabaseKeys,
440-
) -> datetime.timedelta:
440+
) -> float:
441441
"""
442442
XXX
443443
"""
@@ -496,43 +496,48 @@ def test_default(
496496
vuforia_database_keys: VuforiaDatabaseKeys,
497497
) -> None:
498498
"""
499-
XXX
499+
By default it takes three seconds for the Query API on the mock to
500+
recognize that a target has been deleted.
501+
502+
The real Query API takes between seven and thirty seconds.
503+
See ``test_query`` for more information.
500504
"""
501505
with MockVWS(
502506
client_access_key=vuforia_database_keys.client_access_key.decode(),
503507
client_secret_key=vuforia_database_keys.client_secret_key.decode(),
504508
server_access_key=vuforia_database_keys.server_access_key.decode(),
505509
server_secret_key=vuforia_database_keys.server_secret_key.decode(),
506-
) as mock:
507-
seconds_to_recognize_deletion = self._seconds_to_recognize_deletion(
510+
):
511+
recognize_deletion_seconds = self._recognize_deletion_seconds(
508512
high_quality_image=high_quality_image,
509513
vuforia_database_keys=vuforia_database_keys,
510514
)
511515

512516
expected = 3
513-
assert abs(expected - seconds_to_recognize_deletion) < 0.2
517+
assert abs(expected - recognize_deletion_seconds) < 0.2
514518

515519
def test_custom(
516520
self,
517521
high_quality_image: io.BytesIO,
518522
vuforia_database_keys: VuforiaDatabaseKeys,
519523
) -> None:
520524
"""
521-
XXX
525+
It is possible to use set a custom amount of time that it takes for the
526+
Query API on the mock to recognize that a target has been deleted.
522527
"""
523-
# We choose a low time for a quick test
528+
# We choose a low time for a quick test.
524529
query_recognizes_deletion = 0.1
525530
with MockVWS(
526531
client_access_key=vuforia_database_keys.client_access_key.decode(),
527532
client_secret_key=vuforia_database_keys.client_secret_key.decode(),
528533
server_access_key=vuforia_database_keys.server_access_key.decode(),
529534
server_secret_key=vuforia_database_keys.server_secret_key.decode(),
530535
query_recognizes_deletion_seconds=query_recognizes_deletion,
531-
) as mock:
532-
seconds_to_recognize_deletion = self._seconds_to_recognize_deletion(
536+
):
537+
recognize_deletion_seconds = self._recognize_deletion_seconds(
533538
high_quality_image=high_quality_image,
534539
vuforia_database_keys=vuforia_database_keys,
535540
)
536541

537542
expected = query_recognizes_deletion
538-
assert abs(expected - seconds_to_recognize_deletion) < 0.2
543+
assert abs(expected - recognize_deletion_seconds) < 0.2

tests/mock_vws/utils/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,6 @@ def query(
408408
'Content-Type': content_type_header,
409409
}
410410

411-
412411
vwq_host = 'https://cloudreco.vuforia.com'
413412
response = requests.request(
414413
method=method,

0 commit comments

Comments
 (0)