Use clearer fixture name [skip ci]

Author: adamtheturtle

tests/mock_vws/fixtures/images.py

@@ -50,31 +50,22 @@ def png_greyscale() -> io.BytesIO:
     )
 
 
-@pytest.fixture
-def jpeg_rgb() -> io.BytesIO:
+@pytest.fixture(params=[('PNG', 'RGB'), ('JPEG', 'RGB'), ('PNG', 'L')])
+def image_files_failed_state(request: SubRequest) -> io.BytesIO:
     """
-    Return a 1x1 JPEG file in the RGB color space.
+    Return an image file which is expected to be accepted by the add and
+    update target endpoints, but get a "failed" status.
     """
+    # These images get a "failed" status because they are so small.
+    file_format, color_space = request.param
     return make_image_file(
-        file_format='JPEG',
-        color_space='RGB',
+        file_format=file_format,
+        color_space=color_space,
         width=1,
         height=1,
     )
 
 
-@pytest.fixture(params=['png_rgb', 'jpeg_rgb', 'png_greyscale'])
-def image_file(request: SubRequest) -> io.BytesIO:
-    """
-    Return an image file which is expected to work on Vuforia.
-
-    "work" means that this will be added as a target. However, this may or may
-    not result in target with a 'success' status.
-    """
-    file_bytes_io: io.BytesIO = request.getfixturevalue(request.param)
-    return file_bytes_io
-
-
 @pytest.fixture(
     params=[('TIFF', 'RGB'), ('JPEG', 'CMYK')],
     ids=['Not accepted format', 'Not accepted color space'],

tests/mock_vws/test_add_target.py

@@ -385,12 +385,12 @@ class TestImage:
     def test_image_valid(
         self,
         vuforia_database_keys: VuforiaDatabaseKeys,
-        image_file: io.BytesIO,
+        image_files_failed_state: io.BytesIO,
     ) -> None:
         """
-        JPEG and PNG files in the RGB and greyscale color spaces are
-        allowed.
+        JPEG and PNG files in the RGB and greyscale color spaces are allowed.
         """
+        image_file = image_files_failed_state
         image_data = image_file.read()
         image_data_encoded = base64.b64encode(image_data).decode('ascii')
 

tests/mock_vws/test_update_target.py

@@ -705,13 +705,13 @@ class TestImage:
     def test_image_valid(
         self,
         vuforia_database_keys: VuforiaDatabaseKeys,
-        image_file: io.BytesIO,
+        image_files_failed_state: io.BytesIO,
         target_id: str,
     ) -> None:
         """
-        JPEG and PNG files in the RGB and greyscale color spaces are
-        allowed. The image must be under a threshold.
+        JPEG and PNG files in the RGB and greyscale color spaces are allowed.
         """
+        image_file = image_files_failed_state
         image_data = image_file.read()
         image_data_encoded = base64.b64encode(image_data).decode('ascii')