Merge pull request #2327 from VWS-Python/more-kwargs

Use more keyword arguments - better errors from type checkers

Author: adamtheturtle

src/vws/exceptions/vws_exceptions.py

@@ -24,7 +24,7 @@ def target_id(self) -> str:
         """
         The unknown target ID.
         """
-        path = urlparse(self.response.url).path
+        path = urlparse(url=self.response.url).path
         # Every HTTP path which can raise this error is in the format
         # `/something/{target_id}`.
         return path.split(sep="/", maxsplit=2)[-1]
@@ -75,7 +75,7 @@ def target_id(self) -> str:
         """
         The processing target ID.
         """
-        path = urlparse(self.response.url).path
+        path = urlparse(url=self.response.url).path
         # Every HTTP path which can raise this error is in the format
         # `/something/{target_id}`.
         return path.split(sep="/", maxsplit=2)[-1]
@@ -178,7 +178,7 @@ def target_id(self) -> str:
         """
         The unknown target ID.
         """
-        path = urlparse(self.response.url).path
+        path = urlparse(url=self.response.url).path
         # Every HTTP path which can raise this error is in the format
         # `/something/{target_id}`.
         return path.split(sep="/", maxsplit=2)[-1]

src/vws/query.py

@@ -186,7 +186,7 @@ def query(
                 metadata = target_data_dict["application_metadata"]
                 timestamp_string = target_data_dict["target_timestamp"]
                 target_timestamp = datetime.datetime.fromtimestamp(
-                    timestamp_string,
+                    timestamp=timestamp_string,
                     tz=datetime.UTC,
                 )
                 target_data = TargetData(

src/vws/vws.py

@@ -316,7 +316,7 @@ def add_target(
             expected_result_code="TargetCreated",
         )
 
-        return str(json.loads(response.text)["target_id"])
+        return str(json.loads(s=response.text)["target_id"])
 
     def get_target_record(self, target_id: str) -> TargetStatusAndRecord:
         """
@@ -354,7 +354,7 @@ def get_target_record(self, target_id: str) -> TargetStatusAndRecord:
         )
 
         result_data = json.loads(s=response.text)
-        status = TargetStatuses(result_data["status"])
+        status = TargetStatuses(value=result_data["status"])
         target_record_dict = dict(result_data["target_record"])
         target_record = TargetRecord(
             target_id=target_record_dict["target_id"],
@@ -449,7 +449,7 @@ def list_targets(self) -> list[str]:
             expected_result_code="Success",
         )
 
-        return list(json.loads(response.text)["results"])
+        return list(json.loads(s=response.text)["results"])
 
     def get_target_summary_report(self, target_id: str) -> TargetSummaryReport:
         """
@@ -486,9 +486,9 @@ def get_target_summary_report(self, target_id: str) -> TargetSummaryReport:
             expected_result_code="Success",
         )
 
-        result_data = dict(json.loads(response.text))
+        result_data = dict(json.loads(s=response.text))
         return TargetSummaryReport(
-            status=TargetStatuses(result_data["status"]),
+            status=TargetStatuses(value=result_data["status"]),
             database_name=result_data["database_name"],
             target_name=result_data["target_name"],
             upload_date=date.fromisoformat(result_data["upload_date"]),
@@ -529,7 +529,7 @@ def get_database_summary_report(self) -> DatabaseSummaryReport:
             expected_result_code="Success",
         )
 
-        response_data = dict(json.loads(response.text))
+        response_data = dict(json.loads(s=response.text))
         return DatabaseSummaryReport(
             active_images=response_data["active_images"],
             current_month_recos=response_data["current_month_recos"],
@@ -682,7 +682,9 @@ def update_target(
 
         if image is not None:
             image_data = _get_image_data(image=image)
-            image_data_encoded = base64.b64encode(image_data).decode("ascii")
+            image_data_encoded = base64.b64encode(s=image_data).decode(
+                encoding="ascii",
+            )
             data["image"] = image_data_encoded
 
         if active_flag is not None:

tests/test_vws.py

@@ -48,8 +48,8 @@ def test_add_target(
         if application_metadata is None:
             encoded_metadata = None
         else:
-            encoded_metadata_bytes = base64.b64encode(application_metadata)
-            encoded_metadata = encoded_metadata_bytes.decode("utf-8")
+            encoded_metadata_bytes = base64.b64encode(s=application_metadata)
+            encoded_metadata = encoded_metadata_bytes.decode(encoding="utf-8")
 
         target_id = vws_client.add_target(
             name=name,
@@ -197,7 +197,7 @@ def test_get_target_summary_report(
         """
         date = "2018-04-25"
         target_name = uuid.uuid4().hex
-        with freeze_time(date):
+        with freeze_time(time_to_freeze=date):
             target_id = vws_client.add_target(
                 name=target_name,
                 width=1,
@@ -521,7 +521,9 @@ def test_update_target(
 
         new_name = uuid.uuid4().hex
         new_width = secrets.choice(seq=range(1, 5000)) / 100
-        new_application_metadata = base64.b64encode(b"a").decode("ascii")
+        new_application_metadata = base64.b64encode(s=b"a").decode(
+            encoding="ascii",
+        )
         vws_client.update_target(
             target_id=target_id,
             name=new_name,

tests/test_vws_exceptions.py

@@ -121,7 +121,7 @@ def test_bad_image(vws_client: VWS) -> None:
     """
     A ``BadImage`` exception is raised when a non-image is given.
     """
-    not_an_image = io.BytesIO(b"Not an image")
+    not_an_image = io.BytesIO(initial_bytes=b"Not an image")
     with pytest.raises(BadImageError) as exc:
         vws_client.add_target(
             name="x",