Merge pull request #816 from adamtheturtle/test-delete

Add tests for delete

Author: adamtheturtle

src/vws/exceptions.py

@@ -18,3 +18,18 @@ def __init__(self, response: Response) -> None:
         """
         super().__init__()
         self.response = response
+
+
+class TargetStatusProcessing(Exception):
+    """
+    Exception raised when Vuforia returns a response with a result code
+    'TargetStatusProcessing'.
+    """
+
+    def __init__(self, response: Response) -> None:
+        """
+        Args:
+            response: The response to a request to Vuforia.
+        """
+        super().__init__()
+        self.response = response

src/vws/vws.py

@@ -15,7 +15,7 @@
 from requests import Response
 
 from vws._authorization import authorization_header, rfc_1123_date
-from vws.exceptions import UnknownTarget
+from vws.exceptions import TargetStatusProcessing, UnknownTarget
 
 
 def _target_api_request(
@@ -106,6 +106,7 @@ class _ResultCodes(Enum):
 
 _EXCEPTIONS = {
     _ResultCodes.UNKNOWN_TARGET: UnknownTarget,
+    _ResultCodes.TARGET_STATUS_PROCESSING: TargetStatusProcessing,
 }
 
 
@@ -302,9 +303,9 @@ def delete_target(self, target_id: str) -> None:
         response = _target_api_request(
             server_access_key=self._server_access_key,
             server_secret_key=self._server_secret_key,
-            method='GET',
+            method='DELETE',
             content=b'',
-            request_path=f'/summary/{target_id}',
+            request_path=f'/targets/{target_id}',
             base_vws_url=self._base_vws_url,
         )
 

tests/test_delete_target.py

@@ -4,21 +4,45 @@
 
 import io
 
+import pytest
+from requests import codes
+
 from vws import VWS
+from vws.exceptions import TargetStatusProcessing, UnknownTarget
 
 
 class TestDelete:
     """
     Test for deleting a target.
     """
 
+    def test_target_processing(
+        self,
+        client: VWS,
+        high_quality_image: io.BytesIO,
+    ) -> None:
+        """
+        A ``TargetStatusProcessing`` exception is raised if trying to delete a
+        target which is processing.
+        """
+        target_id = client.add_target(
+            name='x',
+            width=1,
+            image=high_quality_image,
+        )
+
+        with pytest.raises(TargetStatusProcessing) as exc:
+            client.delete_target(target_id=target_id)
+
+        assert exc.value.response.status_code == codes.FORBIDDEN
+
     def test_delete_target(
         self,
         client: VWS,
         high_quality_image: io.BytesIO,
     ) -> None:
         """
-        it is possible to delete a target.
+        It is possible to delete a target.
         """
         target_id = client.add_target(
             name='x',
@@ -28,3 +52,5 @@ def test_delete_target(
 
         client.wait_for_target_processed(target_id=target_id)
         client.delete_target(target_id=target_id)
+        with pytest.raises(UnknownTarget):
+            client.get_target_record(target_id=target_id)