Progress

Author: adamtheturtle

src/vws/exceptions.py

@@ -5,6 +5,27 @@
 from requests import Response
 
 
+class MaxNumResultsOutOfRange(Exception):
+    """
+    TODO
+    """
+
+    def __init__(self, response: Response) -> None:
+        """
+        Args:
+            response: The response to a request to Vuforia.
+        """
+        super().__init__(response.text)
+        self._response = response
+
+    @property
+    def response(self) -> Response:
+        """
+        The response returned by Vuforia which included this error.
+        """
+        return self._response
+
+
 class UnknownTarget(Exception):
     """
     Exception raised when Vuforia returns a response with a result code

src/vws/query.py

@@ -1,5 +1,7 @@
 import io
+import json
 from urllib.parse import urljoin
+from vws.exceptions import MaxNumResultsOutOfRange
 
 import requests
 from urllib3.filepost import encode_multipart_formdata
@@ -71,6 +73,8 @@ def query(
             data=content,
         )
 
-        return response.json()['results']
-        import pdb; pdb.set_trace()
-        return response
+        try:
+            return response.json()['results']
+        except json.decoder.JSONDecodeError:
+            if 'Accepted range is from 1 to 50 (inclusive).' in response.text:
+                raise MaxNumResultsOutOfRange(response=response)

tests/test_query.py

@@ -4,8 +4,10 @@
 
 import io
 import uuid
+import pytest
 
 from vws import VWS, CloudRecoService
+from vws.exceptions import MaxNumResultsOutOfRange
 
 
 class TestQuery:
@@ -112,10 +114,18 @@ def test_too_many(
         cloud_reco_client: CloudRecoService,
         high_quality_image: io.BytesIO,
     ) -> None:
-        matches = cloud_reco_client.query(
-            image=high_quality_image,
-            max_num_results=51,
+        with pytest.raises(MaxNumResultsOutOfRange) as exc:
+            cloud_reco_client.query(
+                image=high_quality_image,
+                max_num_results=51,
+            )
+
+        expected_value = (
+            "Integer out of range (51) in form data part 'max_result'. "
+            'Accepted range is from 1 to 50 (inclusive).'
         )
+        assert str(exc.value) == expected_value
+
 
 
 # TODO test custom base URL