Merge pull request #1038 from adamtheturtle/authorization-query

Raise results for result codes

Author: adamtheturtle

src/vws/query.py

@@ -10,6 +10,7 @@
 from urllib3.filepost import encode_multipart_formdata
 
 from ._authorization import authorization_header, rfc_1123_date
+from ._result_codes import raise_for_result_code
 
 
 class CloudRecoService:
@@ -80,4 +81,8 @@ def query(self, image: io.BytesIO) -> List[Dict[str, Any]]:
             data=content,
         )
 
+        raise_for_result_code(
+            response=response,
+            expected_result_code='Success',
+        )
         return list(response.json()['results'])

tests/test_exceptions.py

@@ -12,7 +12,7 @@
 from PIL import Image
 from requests import codes
 
-from vws import VWS
+from vws import VWS, CloudRecoService
 from vws.exceptions import (
     AuthenticationFailure,
     BadImage,
@@ -211,7 +211,8 @@ def test_metadata_too_large(
 def test_authentication_failure(high_quality_image: io.BytesIO) -> None:
     """
     An ``AuthenticationFailure`` exception is raised when the server access key
-    exists but the server secret key is incorrect.
+    exists but the server secret key is incorrect, or when a client key is
+    incorrect.
     """
     database = VuforiaDatabase()
     with MockVWS() as mock:
@@ -230,6 +231,16 @@ def test_authentication_failure(high_quality_image: io.BytesIO) -> None:
 
         assert exc.value.response.status_code == codes.UNAUTHORIZED
 
+        cloud_reco_client = CloudRecoService(
+            client_access_key=database.client_access_key,
+            client_secret_key='a',
+        )
+
+        with pytest.raises(AuthenticationFailure) as exc:
+            cloud_reco_client.query(image=high_quality_image)
+
+        assert exc.value.response.status_code == codes.UNAUTHORIZED
+
 
 def test_target_status_not_success(
     vws_client: VWS,