Merge pull request #829 from adamtheturtle/more-exception-tests

Move a few tests into test_exceptions

Author: adamtheturtle

tests/test_add_target.py

@@ -9,7 +9,7 @@
 from requests import codes
 
 from vws import VWS
-from vws.exceptions import MetadataTooLarge, TargetNameExist
+from vws.exceptions import TargetNameExist
 
 
 class TestSuccess:
@@ -129,25 +129,6 @@ def test_given(
             application_metadata=b'a',
         )
 
-    def test_too_large(
-        self,
-        client: VWS,
-        high_quality_image: io.BytesIO,
-    ) -> None:
-        """
-        A ``MetadataTooLarge`` exception is raised if the metadata given is too
-        large.
-        """
-        with pytest.raises(MetadataTooLarge) as exc:
-            client.add_target(
-                name='x',
-                width=1,
-                image=high_quality_image,
-                application_metadata=b'a' * 1024 * 1024,
-            )
-
-        assert exc.value.response.status_code == codes.UNPROCESSABLE_ENTITY
-
 
 class TestActiveFlag:
     """

tests/test_delete_target.py

@@ -5,37 +5,16 @@
 import io
 
 import pytest
-from requests import codes
 
 from vws import VWS
-from vws.exceptions import TargetStatusProcessing, UnknownTarget
+from vws.exceptions import UnknownTarget
 
 
 class TestDelete:
     """
     Test for deleting a target.
     """
 
-    def test_target_processing(
-        self,
-        client: VWS,
-        high_quality_image: io.BytesIO,
-    ) -> None:
-        """
-        A ``TargetStatusProcessing`` exception is raised if trying to delete a
-        target which is processing.
-        """
-        target_id = client.add_target(
-            name='x',
-            width=1,
-            image=high_quality_image,
-        )
-
-        with pytest.raises(TargetStatusProcessing) as exc:
-            client.delete_target(target_id=target_id)
-
-        assert exc.value.response.status_code == codes.FORBIDDEN
-
     def test_delete_target(
         self,
         client: VWS,

tests/test_exceptions.py

@@ -10,7 +10,12 @@
 from requests import codes
 
 from vws import VWS
-from vws.exceptions import ImageTooLarge, UnknownTarget
+from vws.exceptions import (
+    ImageTooLarge,
+    MetadataTooLarge,
+    TargetStatusProcessing,
+    UnknownTarget,
+)
 
 
 def _make_image_file(
@@ -81,3 +86,42 @@ def test_request_quota_reached() -> None:
     See https://github.com/adamtheturtle/vws-python/issues/822 for writing
     this test.
     """
+
+
+def test_target_status_processing(
+    client: VWS,
+    high_quality_image: io.BytesIO,
+) -> None:
+    """
+    A ``TargetStatusProcessing`` exception is raised if trying to delete a
+    target which is processing.
+    """
+    target_id = client.add_target(
+        name='x',
+        width=1,
+        image=high_quality_image,
+    )
+
+    with pytest.raises(TargetStatusProcessing) as exc:
+        client.delete_target(target_id=target_id)
+
+    assert exc.value.response.status_code == codes.FORBIDDEN
+
+
+def test_metadata_too_large(
+    client: VWS,
+    high_quality_image: io.BytesIO,
+) -> None:
+    """
+    A ``MetadataTooLarge`` exception is raised if the metadata given is too
+    large.
+    """
+    with pytest.raises(MetadataTooLarge) as exc:
+        client.add_target(
+            name='x',
+            width=1,
+            image=high_quality_image,
+            application_metadata=b'a' * 1024 * 1024,
+        )
+
+    assert exc.value.response.status_code == codes.UNPROCESSABLE_ENTITY