Skip to content

Commit eb84860

Browse files
Merge pull request #987 from adamtheturtle/update-mypy
Fix strict equality checks
2 parents 9ea3f34 + 35401c6 commit eb84860

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ flake8-commas==2.0.0 # Require silicon valley commas
88
flake8-quotes==1.0.0 # Require single quotes
99
flake8==3.7.7 # Lint
1010
isort==4.3.16 # Lint imports
11-
mypy-mypyc==0.670 # Type checking
11+
mypy==0.700 # Type checking
1212
pip_check_reqs==2.0.3
1313
pydocstyle==3.0.0 # Lint docstrings
1414
pyenchant==2.0.0 # Bindings for a spellchecking sytem

setup.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ disallow_untyped_defs = True
7373
follow_imports = silent
7474
ignore_missing_imports = True
7575
no_implicit_optional = True
76+
strict_equality = True
7677
strict_optional = True
7778
warn_no_return = True
7879
warn_redundant_casts = True

tests/test_vws.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def test_get_target_summary_report(
191191
'current_month_recos',
192192
'previous_month_recos',
193193
}
194-
assert result.keys() == expected_keys
194+
assert set(result.keys()) == expected_keys
195195

196196

197197
class TestGetDatabaseSummaryReport:
@@ -220,7 +220,7 @@ def test_get_target(self, client: VWS) -> None:
220220
'total_recos',
221221
'transaction_id',
222222
}
223-
assert report.keys() == expected_keys
223+
assert set(report.keys()) == expected_keys
224224

225225

226226
class TestGetTargetRecord:
@@ -252,7 +252,7 @@ def test_get_target_record(
252252
'tracking_rating',
253253
'reco_rating',
254254
}
255-
assert result.keys() == expected_keys
255+
assert set(result.keys()) == expected_keys
256256

257257

258258
class TestWaitForTargetProcessed:

0 commit comments

Comments
 (0)