Merge pull request #836 from adamtheturtle/parametrize-metadata-tests

Parametrize metadata test

Author: adamtheturtle

tests/test_add_target.py

@@ -3,6 +3,7 @@
 """
 
 import io
+from typing import Optional
 
 import pytest
 from mock_vws import MockVWS
@@ -79,30 +80,21 @@ class TestApplicationMetadata:
     Tests for the ``application_metadata`` parameter to ``add_target``.
     """
 
-    def test_none(self, client: VWS, high_quality_image: io.BytesIO) -> None:
-        """
-        No exception is raised when ``None`` is given.
-        """
-        client.add_target(
-            name='x',
-            width=1,
-            image=high_quality_image,
-            application_metadata=None,
-        )
-
-    def test_given(
+    @pytest.mark.parametrize('application_metadata', [None, b'a'])
+    def test_valid_metadata(
         self,
         client: VWS,
         high_quality_image: io.BytesIO,
+        application_metadata: Optional[bytes],
     ) -> None:
         """
-        No exception is raised when bytes are given.
+        No exception is raised when ``None`` or bytes is given.
         """
         client.add_target(
             name='x',
             width=1,
             image=high_quality_image,
-            application_metadata=b'a',
+            application_metadata=application_metadata,
         )
 
 
@@ -112,7 +104,7 @@ class TestActiveFlag:
     """
 
     @pytest.mark.parametrize('active_flag', [True, False])
-    def test_given(
+    def test_active_flag_given(
         self,
         client: VWS,
         high_quality_image: io.BytesIO,