[GEN][ZH] Fix uninitialized costSoFar variable in AIPathfind::findGoundPath() (TheSuperHackers#632)

Mauller · xezon · commit 3feb3fcd6cdb · 2025-04-28T09:30:17.000+02:00
diff --git a/Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp b/Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
@@ -6649,7 +6649,7 @@ Path *Pathfinder::findGroundPath( const Coord3D *from,
 		const Int adjacent[5] = {0, 1, 2, 3, 0};
 		Bool neighborFlags[8] = {false, false, false, false, false, false, false};
 
-		UnsignedInt newCostSoFar;
+		UnsignedInt newCostSoFar = 0;
 
 		for( int i=0; i<numNeighbors; i++ )
 		{
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
@@ -7192,7 +7192,7 @@ Path *Pathfinder::findGroundPath( const Coord3D *from,
 		const Int adjacent[5] = {0, 1, 2, 3, 0};
 		Bool neighborFlags[8] = {false, false, false, false, false, false, false};
 
-		UnsignedInt newCostSoFar;
+		UnsignedInt newCostSoFar = 0;
 
 		for( int i=0; i<numNeighbors; i++ )
 		{

Original file line number	Diff line number	Diff line change
`@@ -6649,7 +6649,7 @@ Path Pathfinder::findGroundPath( const Coord3D from,`
`6649`	`6649`	`const Int adjacent[5] = {0, 1, 2, 3, 0};`
`6650`	`6650`	`Bool neighborFlags[8] = {false, false, false, false, false, false, false};`
`6651`	`6651`
`6652`		`- UnsignedInt newCostSoFar;`
	`6652`	`+ UnsignedInt newCostSoFar = 0;`
`6653`	`6653`
`6654`	`6654`	`for( int i=0; i<numNeighbors; i++ )`
`6655`	`6655`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7192,7 +7192,7 @@ Path Pathfinder::findGroundPath( const Coord3D from,`
`7192`	`7192`	`const Int adjacent[5] = {0, 1, 2, 3, 0};`
`7193`	`7193`	`Bool neighborFlags[8] = {false, false, false, false, false, false, false};`
`7194`	`7194`
`7195`		`- UnsignedInt newCostSoFar;`
	`7195`	`+ UnsignedInt newCostSoFar = 0;`
`7196`	`7196`
`7197`	`7197`	`for( int i=0; i<numNeighbors; i++ )`
`7198`	`7198`	`{`