units: refactored SetLampComponentUnit into SetLampColorUnit

Author: jsm174

…iptors/SetLampComponentUnitDescriptor.cs …escriptors/SetLampColorUnitDescriptor.csEditor/Descriptors/SetLampComponentUnitDescriptor.cs renamed to Editor/Descriptors/SetLampColorUnitDescriptor.cs Editor/Descriptors/SetLampComponentUnitDescriptor.cs renamed to Editor/Descriptors/SetLampColorUnitDescriptor.cs

@@ -22,16 +22,16 @@
 
 namespace VisualPinball.Unity.VisualScripting.Editor
 {
-	[Descriptor(typeof(SetLampComponentUnit))]
-	public class SetLampComponentUnitDescriptor : UnitDescriptor<SetLampComponentUnit>
+	[Descriptor(typeof(SetLampColorUnit))]
+	public class SetLampColorUnitDescriptor : UnitDescriptor<SetLampColorUnit>
 	{
-		public SetLampComponentUnitDescriptor(SetLampComponentUnit target) : base(target)
+		public SetLampColorUnitDescriptor(SetLampColorUnit target) : base(target)
 		{
 		}
 
 		protected override string DefinedSummary()
 		{
-			return "This node assigns a given value to a light or light group in the scene. \n\nNote that this doesn't pass through the gamelogic engine, thus no event will be triggered. However, it allows you to drive non-mapped lights as well.";
+			return "This node assigns a given value to a lamp defined by its mapped ID. This will also trigger the lamp changed event and update the internal status.";
 		}
 
 		protected override EditorTexture DefinedIcon() => EditorTexture.Single(Unity.Editor.Icons.Light(IconSize.Large, IconColor.Orange));
@@ -40,18 +40,16 @@ protected override void DefinedPort(IUnitPort port, UnitPortDescription desc)
 		{
 			base.DefinedPort(port, desc);
 
-			switch (port.key) {
-				case nameof(SetLampComponentUnit.LampComponent):
-					desc.summary = "The light component whose value you want to change. Assigning a light group will change all lights in the group.";
-					break;
-
-				case nameof(SetLampComponentUnit.Value):
-					desc.summary = "The intensity to apply (0-1).";
-					break;
+			if (port.key == nameof(SetLampColorUnit.Value))
+			{
+				desc.summary = "The color to set the lamp";
+			}
+			else if (int.TryParse(port.key, out int id))
+			{
+				id += 1;
 
-				case nameof(SetLampComponentUnit.ColorChannel):
-					desc.summary = "Which color channel to use. For non-RGB lights, use alpha.";
-					break;
+				desc.label = $"Lamp ID {id}";
+				desc.summary = $"Lamp ID {id} of the lamp to set the intensity";
 			}
 		}
 	}

…Nodes/Lamps/SetLampComponentUnit.cs.meta …ptors/SetLampColorUnitDescriptor.cs.metaRuntime/Nodes/Lamps/SetLampComponentUnit.cs.meta renamed to Editor/Descriptors/SetLampColorUnitDescriptor.cs.meta Runtime/Nodes/Lamps/SetLampComponentUnit.cs.meta renamed to Editor/Descriptors/SetLampColorUnitDescriptor.cs.meta

@@ -0,0 +1,67 @@
+// Visual Pinball Engine
+// Copyright (C) 2022 freezy and VPE Team
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+// ReSharper disable UnusedType.Global
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using Unity.VisualScripting;
+
+namespace VisualPinball.Unity.VisualScripting.Editor
+{
+	[Widget(typeof(SetLampColorUnit))]
+	public sealed class SetLampColorUnitWidget : GleUnitWidget<SetLampColorUnit>
+	{
+		private readonly List<Func<Metadata, VariableNameInspector>> _lampIdInspectorConstructorList;
+
+		public SetLampColorUnitWidget(FlowCanvas canvas, SetLampColorUnit unit) : base(canvas, unit)
+		{
+			_lampIdInspectorConstructorList = new List<Func<Metadata, VariableNameInspector>>();
+		}
+
+		public override Inspector GetPortInspector(IUnitPort port, Metadata meta)
+		{
+			if (_lampIdInspectorConstructorList.Count() < unit.inputCount)
+			{
+				for (var index = 0; index < unit.inputCount - _lampIdInspectorConstructorList.Count(); index++)
+				{
+					_lampIdInspectorConstructorList.Add(meta => new VariableNameInspector(meta, GetNameSuggestions));
+				}
+			}
+
+			for (var index = 0; index < unit.inputCount; index++)
+			{
+				if (unit.multiInputs[index] == port)
+				{
+					VariableNameInspector lampIdInspector = new VariableNameInspector(meta, GetNameSuggestions);
+					InspectorProvider.instance.Renew(ref lampIdInspector, meta, _lampIdInspectorConstructorList[index]);
+
+					return lampIdInspector;
+				}
+			}
+
+			return base.GetPortInspector(port, meta);
+		}
+
+		private IEnumerable<string> GetNameSuggestions()
+		{
+			return !GleAvailable
+				? new List<string>()
+				: Gle.RequestedLamps.Select(lamp => lamp.Id).ToList();
+		}
+	}
+}

Editor/Widgets/SetLampColorUnitWidget.cs

@@ -14,17 +14,18 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using Unity.VisualScripting;
 using UnityEngine;
-using VisualPinball.Engine.Math;
 
 namespace VisualPinball.Unity.VisualScripting
 {
-	[UnitTitle("Set Lamp (Component, Value, Channel)")]
 	[UnitShortTitle("Set Lamp")]
-	[UnitSurtitle("Scene")]
+	[UnitTitle("Set Lamp (ID, Color)")]
+	[UnitSurtitle("Gamelogic Engine")]
 	[UnitCategory("Visual Pinball")]
-	public class SetLampComponentUnit : GleUnit
+	public class SetLampColorUnit : GleUnit, IMultiInputUnit
 	{
 		[DoNotSerialize]
 		[PortLabelHidden]
@@ -34,49 +35,63 @@ public class SetLampComponentUnit : GleUnit
 		[PortLabelHidden]
 		public ControlOutput OutputTrigger;
 
+		[SerializeAs(nameof(inputCount))]
+		private int _inputCount = 1;
+
 		[DoNotSerialize]
-		[PortLabel("Component")]
-		public ValueInput LampComponent;
+		[Inspectable, UnitHeaderInspectable("Lamp IDs")]
+		public int inputCount
+		{
+			get => _inputCount;
+			set => _inputCount = Mathf.Clamp(value, 1, 10);
+		}
 
 		[DoNotSerialize]
-		[PortLabel("Intensity")]
-		public ValueInput Value;
+		public ReadOnlyCollection<ValueInput> multiInputs { get; private set; }
 
 		[DoNotSerialize]
-		[PortLabel("Color Channel")]
-		public ValueInput ColorChannel;
+		[PortLabel("Value")]
+		public ValueInput Value { get; private set; }
 
 		protected override void Definition()
 		{
 			InputTrigger = ControlInput(nameof(InputTrigger), Process);
 			OutputTrigger = ControlOutput(nameof(OutputTrigger));
 
-			LampComponent = ValueInput<MonoBehaviour>(nameof(LampComponent), null);
+			var _multiInputs = new List<ValueInput>();
 
-			Value = ValueInput(nameof(Value), 0f);
-			ColorChannel = ValueInput(nameof(ColorChannel), Engine.Math.ColorChannel.Alpha);
+			multiInputs = _multiInputs.AsReadOnly();
+
+			for (var i = 0; i < inputCount; i++)
+			{
+				var input = ValueInput(i.ToString(), string.Empty);
+				_multiInputs.Add(input);
+
+				Requirement(input, InputTrigger);
+			}
+
+			Value = ValueInput(nameof(Value), Color.black);
 
-			Requirement(LampComponent, InputTrigger);
 			Succession(InputTrigger, OutputTrigger);
 		}
 
 		private ControlOutput Process(Flow flow)
 		{
-			if (!AssertPlayer(flow)) {
-				Debug.LogError("Cannot find player.");
+			if (!AssertGle(flow))
+			{
+				Debug.LogError("Cannot find GLE.");
 				return OutputTrigger;
 			}
 
-			if (flow.GetValue<MonoBehaviour>(LampComponent) is ILampDeviceComponent lamp) {
-				var valueRaw = flow.GetValue<float>(Value);
-				var colorChannelRaw = flow.GetValue<ColorChannel>(ColorChannel);
+			var value = flow.GetValue<Color>(Value);
 
-				Player.Lamp(lamp)?.OnLamp(valueRaw, colorChannelRaw);
+			foreach (var input in multiInputs)
+			{
+				var lampId = flow.GetValue<string>(input);
+				Gle.SetLamp(lampId, value);
 			}
 
 			return OutputTrigger;
 		}
-
-
 	}
 }