coils: update pulse coil unit to take multiple coils

Author: jsm174

Editor/Descriptors/PulseCoilUnitDescriptor.cs

@@ -44,11 +44,11 @@ protected override void DefinedPort(IUnitPort port, UnitPortDescription desc)
 			base.DefinedPort(port, desc);
 
 			switch (port.key) {
-				case nameof(PulseCoilUnit.Id):
-					desc.summary = "The ID of the coil to be pulsed.";
+				case nameof(PulseCoilUnit.Ids):
+					desc.summary = "The IDs of the coils to be pulsed.";
 					break;
 				case nameof(PulseCoilUnit.PulseDuration):
-					desc.summary = "The time in milliseconds until the coil is disabled again.";
+					desc.summary = "The time in milliseconds until the coils are disabled again.";
 					break;
 			}
 		}

Editor/Widgets/PulseCoilUnitWidget.cs

@@ -26,19 +26,28 @@ namespace VisualPinball.Unity.VisualScripting.Editor
 	[Widget(typeof(PulseCoilUnit))]
 	public sealed class PulseCoilUnitWidget : GleUnitWidget<PulseCoilUnit>
 	{
-		private VariableNameInspector _coilIdInspector;
-		private readonly Func<Metadata, VariableNameInspector> _setCoilInspectorConstructor;
+		private readonly List<Func<Metadata, VariableNameInspector>> _coilIdInspectorConstructorList;
 
 		public PulseCoilUnitWidget(FlowCanvas canvas, PulseCoilUnit unit) : base(canvas, unit)
 		{
-			_setCoilInspectorConstructor = meta => new VariableNameInspector(meta, GetNameSuggestions);
+			_coilIdInspectorConstructorList = new List<Func<Metadata, VariableNameInspector>>();
 		}
 
 		public override Inspector GetPortInspector(IUnitPort port, Metadata meta)
 		{
-			if (port == unit.Id) {
-				InspectorProvider.instance.Renew(ref _coilIdInspector, meta, _setCoilInspectorConstructor);
-				return _coilIdInspector;
+			if (_coilIdInspectorConstructorList.Count() < unit.idCount) {
+				for (var index = 0; index < unit.idCount - _coilIdInspectorConstructorList.Count(); index++) {
+					_coilIdInspectorConstructorList.Add(meta => new VariableNameInspector(meta, GetNameSuggestions));
+				}
+			}
+
+			for (var index = 0; index < unit.idCount; index++) {
+				if (unit.Ids[index] == port) {
+					VariableNameInspector coilIdInspector = new VariableNameInspector(meta, GetNameSuggestions);
+					InspectorProvider.instance.Renew(ref coilIdInspector, meta, _coilIdInspectorConstructorList[index]);
+
+					return coilIdInspector;
+				}
 			}
 
 			return base.GetPortInspector(port, meta);

Runtime/Nodes/Coils/PulseCoilUnit.cs

@@ -14,6 +14,7 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+using System.Collections.Generic;
 using Unity.VisualScripting;
 using UnityEngine;
 
@@ -32,9 +33,19 @@ public class PulseCoilUnit : GleUnit
 		[PortLabelHidden]
 		public ControlOutput OutputTrigger;
 
+		[SerializeAs(nameof(idCount))]
+		private int _idCount = 1;
+
+		[DoNotSerialize]
+		[Inspectable, UnitHeaderInspectable("Coil IDs")]
+		public int idCount
+		{
+			get => _idCount;
+			set => _idCount = Mathf.Clamp(value, 1, 10);
+		}
+
 		[DoNotSerialize]
-		[PortLabel("Coil ID")]
-		public ValueInput Id { get; private set; }
+		public List<ValueInput> Ids { get; private set; }
 
 		[DoNotSerialize]
 		[PortLabel("Duration (ms)")]
@@ -45,10 +56,17 @@ protected override void Definition()
 			InputTrigger = ControlInput(nameof(InputTrigger), Process);
 			OutputTrigger = ControlOutput(nameof(OutputTrigger));
 
-			Id = ValueInput<string>(nameof(Id), string.Empty);
+			Ids = new List<ValueInput>();
+
+			for (var i = 0; i < idCount; i++) {
+				var id = ValueInput<string>("Coil ID " + (i + 1), string.Empty);
+				Ids.Add(id);
+
+				Requirement(id, InputTrigger);
+			}
+
 			PulseDuration = ValueInput<int>(nameof(PulseDuration), 80);
 
-			Requirement(Id, InputTrigger);
 			Succession(InputTrigger, OutputTrigger);
 		}
 
@@ -60,15 +78,17 @@ private ControlOutput Process(Flow flow)
 			}
 
 			if (!AssertPlayer(flow)) {
-				Debug.LogError("Cannot find GLE.");
+				Debug.LogError("Cannot find Player.");
 				return OutputTrigger;
 			}
 
-			var id = flow.GetValue<string>(Id);
-			var pulseDuration = flow.GetValue<int>(PulseDuration);
+			foreach (var id in Ids) {
+				var idValue = flow.GetValue<string>(id);
+				var pulseDuration = flow.GetValue<int>(PulseDuration);
 
-			Gle.SetCoil(id, true);
-			Player.ScheduleAction(pulseDuration, () => Gle.SetCoil(id, false));
+				Gle.SetCoil(idValue, true);
+				Player.ScheduleAction(pulseDuration, () => Gle.SetCoil(idValue, false));
+			}
 
 			return OutputTrigger;
 		}