unit: update LampIdValue to convert to/from JSON

Author: jsm174

Editor/Inspectors/LampIdValueInspector.cs

@@ -38,7 +38,7 @@ protected override void OnGUI(Rect position, GUIContent label)
 
             var fieldPosition = position.VerticalSection(ref y, GetFieldHeight(position.width, GUIContent.none));
 
-            LampIdValue lampIdValue = (LampIdValue)metadata.value;
+            LampIdValue lampIdValue = LampIdValue.FromJson((string)metadata.value);
 
             var valueWidth = LudiqGUI.GetTextFieldAdaptiveWidth(lampIdValue.value);
 
@@ -105,17 +105,17 @@ protected override void OnGUI(Rect position, GUIContent label)
             if (EndBlock(metadata))
             {
                 metadata.RecordUndo();
-                metadata.value = new LampIdValue
-                {
-                    id = newIdValue,
-                    value = newValue
-                };
+
+                lampIdValue.id = newIdValue;
+                lampIdValue.value = newValue;
+
+                metadata.value = lampIdValue.ToJson();
             }
         }
 
         public override float GetAdaptiveWidth()
         {
-            LampIdValue lampIdValue = (LampIdValue)metadata.value;
+            LampIdValue lampIdValue = LampIdValue.FromJson((string)metadata.value);
 
             return Mathf.Max(30, EditorStyles.textField.CalcSize(new GUIContent(lampIdValue.id)).x + 1 + Styles.popup.fixedWidth) +
                 LudiqGUI.GetTextFieldAdaptiveWidth(lampIdValue.value) + 70;

Runtime/Nodes/Lamps/SwitchLampUnit.cs

@@ -18,17 +18,26 @@
 using System.Collections.Generic;
 using Unity.VisualScripting;
 using UnityEngine;
-using UnityObject = UnityEngine.Object;
 
 namespace VisualPinball.Unity.VisualScripting
 {
 	[Serializable]
-	public class LampIdValue : UnityObject
+	public struct LampIdValue
 	{
 		public string id;
 		public int value;
 
-		public static LampIdValue Empty = new LampIdValue { id = string.Empty, value = 0 };
+		public static LampIdValue FromJson(string json)
+		{
+			return JsonUtility.FromJson<LampIdValue>(json);
+		}
+
+		public string ToJson()
+		{
+			return JsonUtility.ToJson(this);
+		}
+
+		public static readonly LampIdValue Empty = new LampIdValue { id = string.Empty, value = 0 };
 	}
 
 	[UnitShortTitle("Switch Lamp")]
@@ -63,6 +72,9 @@ public int idCount
 		[DoNotSerialize]
 		public List<ValueInput> LampIdValues { get; private set; }
 
+		private List<LampIdValue> _lampIdValueList;
+		private int _hash;
+
 		protected override void Definition()
 		{
 			InputTrigger = ControlInput(nameof(InputTrigger), Process);
@@ -72,15 +84,13 @@ protected override void Definition()
 
 			LampIdValues = new List<ValueInput>();
 
-			for (var i = 0; i < idCount; i++)
-			{
-				var lampIdValue = ValueInput<LampIdValue>("Lamp ID " + (i + 1), LampIdValue.Empty);
-				LampIdValues.Add(lampIdValue);
+			for (var i = 0; i < idCount; i++) {
+				var valueInput = ValueInput($"Lamp ID {i + 1}", LampIdValue.Empty.ToJson());
+				LampIdValues.Add(valueInput);
 
-				Requirement(lampIdValue, InputTrigger);
+				Requirement(valueInput, InputTrigger);
 			}
 
-		
 			Succession(InputTrigger, OutputTrigger);
 		}
 
@@ -90,13 +100,12 @@ private ControlOutput Process(Flow flow)
 				Debug.LogError("Cannot find GLE.");
 				return OutputTrigger;
 			}
-
+			
 			var value = flow.GetValue<int>(Value);
 
-			foreach (var lampIdValue in LampIdValues)
-			{
-				var lampIdValueStruct = flow.GetValue<LampIdValue>(lampIdValue);
-				Gle.SetLamp(lampIdValueStruct.id, lampIdValueStruct.value == value ? 255f : 0f);
+			foreach (var lampIdValue in LampIdValues) {
+				var obj = LampIdValue.FromJson(flow.GetValue<string>(lampIdValue));
+				Gle.SetLamp(obj.id, obj.value == value ? 255f : 0f);
 			}
 
 			return OutputTrigger;