From f1154fe0b47bc15710a01ddbe533fd2cafdc893c Mon Sep 17 00:00:00 2001 From: Dmitry Kryukov Date: Wed, 24 Dec 2025 21:16:53 +0300 Subject: [PATCH] [bug] fixed issue "number of placeholders in logging call doesn't match the number of arguments" --- .../eventchecker/service/AbstractEventCheckReceiver.java | 6 +++--- .../appconn/eventchecker/service/EventCheckerService.java | 4 ++-- .../dss/apiservice/core/util/HttpClientUtil.java | 2 +- .../dss/guide/server/restful/PageGuideAdminRestful.java | 2 +- .../com/webank/wedatasphere/dss/common/utils/ZipHelper.java | 4 ++-- .../project/restful/DSSFrameworkProjectRestfulApi.java | 6 +++--- .../framework/workspace/restful/DSSWorkspaceRestful.java | 4 ++-- .../wedatasphere/dss/migrate/restful/DSSMigrateRestful.java | 2 +- .../dss/migrate/service/impl/MigrateServiceImpl.java | 2 +- .../dss/workflow/service/impl/DSSFlowServiceImpl.java | 2 +- 10 files changed, 17 insertions(+), 17 deletions(-) diff --git a/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/AbstractEventCheckReceiver.java b/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/AbstractEventCheckReceiver.java index f20095ea0a..4e5c5e58e3 100644 --- a/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/AbstractEventCheckReceiver.java +++ b/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/AbstractEventCheckReceiver.java @@ -69,7 +69,7 @@ String setConsumedMsg(Properties props, Logger log, String[] consumedMsgInfo){ + ", messageBody: " + vMsg); } }catch (Exception e) { - log.error("Error set consumed message failed {} setConsumedMsg failed" + e); + log.error("Error set consumed message failed setConsumedMsg failed ", e); return vNewMsgID; } return vNewMsgID; @@ -99,7 +99,7 @@ boolean updateMsgOffset(int jobId, Properties props, Logger log, String[] consum updatePstmt.setString(4, vReceiveTime); updatePstmt.setString(5, vNewMsgID); int updaters = updatePstmt.executeUpdate(); - log.info("updateMsgOffset successful {} update result is:" + updaters); + log.info("updateMsgOffset successful, update result is: {}", updaters); if(updaters != 0){ log.info("Received message successfully , update message status succeeded, consumed flow execution ID: " + vProcessID); //return true after update success @@ -197,7 +197,7 @@ private String[] createExecuteType(int jobId, Properties props, Logger log,Strin } } }catch(Exception e){ - log.error("create executeType failed {}" + e); + log.error("create executeType failed ", e); } return executeType; } diff --git a/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/EventCheckerService.java b/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/EventCheckerService.java index cd6bb36818..c841e2aed2 100644 --- a/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/EventCheckerService.java +++ b/dss-appconn/appconns/dss-eventchecker-appconn/src/main/java/com/webank/wedatasphere/dss/appconn/eventchecker/service/EventCheckerService.java @@ -49,7 +49,7 @@ public boolean sendMsg(int jobId, Properties props, Logger log) { } return eventCheck.sendMsg(jobId, props, log); } else { - log.error("create EventCheckSender failed {}"); + log.error("create EventCheckSender failed"); return false; } } @@ -75,7 +75,7 @@ public boolean reciveMsg(int jobId, Properties props, Logger log) { } return eventCheck.reciveMsg(jobId, props, log); } else { - log.error("create EventCheckSender failed {}"); + log.error("create EventCheckSender failed"); return false; } } diff --git a/dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/util/HttpClientUtil.java b/dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/util/HttpClientUtil.java index b2708f75b5..dd8d772219 100644 --- a/dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/util/HttpClientUtil.java +++ b/dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/util/HttpClientUtil.java @@ -373,7 +373,7 @@ public static String postJsonBody3(String url, int timeout, Map //post.setEntity(new StringEntity(jsonArray.get(0).toString(), encoding)); post.setEntity(new StringEntity(null, encoding)); //logger.info("successfully start post Json Body url{},params ", url,jsonArray.get(0).toString()); - logger.info("successfully start post Json Body url{},params ", url,null); + logger.info("successfully start post Json Body url {}", url); } CloseableHttpResponse response = httpclient.execute(post); try { diff --git a/dss-apps/dss-user-guide/dss-user-guide-server/src/main/java/com/webank/wedatasphere/dss/guide/server/restful/PageGuideAdminRestful.java b/dss-apps/dss-user-guide/dss-user-guide-server/src/main/java/com/webank/wedatasphere/dss/guide/server/restful/PageGuideAdminRestful.java index 4850ebafa9..5258fc2bcf 100644 --- a/dss-apps/dss-user-guide/dss-user-guide-server/src/main/java/com/webank/wedatasphere/dss/guide/server/restful/PageGuideAdminRestful.java +++ b/dss-apps/dss-user-guide/dss-user-guide-server/src/main/java/com/webank/wedatasphere/dss/guide/server/restful/PageGuideAdminRestful.java @@ -102,7 +102,7 @@ public Message updateGuideContent(@PathVariable Long id, @RequestBody Map roles = dssWorkspaceRoleService.getRoleInWorkspace(username, projectRequest.getWorkspaceId().intValue()); @@ -486,7 +486,7 @@ public Message listAllProjectName(HttpServletRequest request, @RequestBody Proje try { dssWorkspaceService.getWorkspacesById(projectRequest.getWorkspaceId(), username); } catch (DSSErrorException e) { - LOGGER.error("User {} get workspace {} failed.", username, projectRequest.getWorkspaceId(), e); + LOGGER.error("User {} get workspace {} failed. {}", username, projectRequest.getWorkspaceId(), e); return Message.error(e); } List roles = dssWorkspaceRoleService.getRoleInWorkspace(username, projectRequest.getWorkspaceId().intValue()); @@ -570,7 +570,7 @@ public Message queryAllProject(HttpServletRequest request, @RequestBody ProjectQ try { dssWorkspaceService.getWorkspacesById(projectRequest.getWorkspaceId(), username); } catch (DSSErrorException e) { - LOGGER.error("User {} get workspace {} failed.", username, projectRequest.getWorkspaceId(), e); + LOGGER.error("User {} get workspace {} failed. {}", username, projectRequest.getWorkspaceId(), e); return Message.error(e); } List roles = dssWorkspaceRoleService.getRoleInWorkspace(username, projectRequest.getWorkspaceId().intValue()); diff --git a/dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/restful/DSSWorkspaceRestful.java b/dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/restful/DSSWorkspaceRestful.java index 954af5752a..9ad8fe8db2 100644 --- a/dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/restful/DSSWorkspaceRestful.java +++ b/dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/restful/DSSWorkspaceRestful.java @@ -357,7 +357,7 @@ public Message getWorkspacesById(@PathVariable("id") Long workspaceId) { try { workspace = dssWorkspaceService.getWorkspacesById(workspaceId, username); } catch (DSSErrorException e) { - LOGGER.error("User {} get workspace {} failed.", username, workspaceId, e); + LOGGER.error("User {} get workspace {} failed. {}", username, workspaceId, e); return Message.error(e); } @@ -438,7 +438,7 @@ public Message getWorkspaceAppConns(@PathVariable("workspaceId") Long workspaceI try { menuAppconnVos = dssWorkspaceService.getWorkspaceAppConns(workspace, workspaceId, username, isChinese); } catch (DSSErrorException e) { - LOGGER.warn("{} get appconns from workspace {} failed.", username, workspaceId, e); + LOGGER.warn("{} get appconns from workspace {} failed. {}", username, workspaceId, e); return Message.error(e); } return Message.ok().data("menus", menuAppconnVos); diff --git a/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/restful/DSSMigrateRestful.java b/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/restful/DSSMigrateRestful.java index 0dac927b1f..fa9fc1dd8c 100644 --- a/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/restful/DSSMigrateRestful.java +++ b/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/restful/DSSMigrateRestful.java @@ -300,7 +300,7 @@ public Message importWorkFlow(HttpServletRequest req, String flowLatestBmlVersion = getLatestFlowBmlVersion(userName, orchestratorLatestVersion.getAppId()); responseMsg.data(FLOW_BML_VERSION_KEY, flowLatestBmlVersion); } else { - LOG.error("Got null orchestrator version after imported. User : {}, workspace : {}, projectName : {}, projectId : {}", importOrcId, userName, workspaceName, projectName, projectVo.getId()); + LOG.error("Got null orchestrator version after imported. ImportOrcId: {}, User : {}, workspace : {}, projectName : {}, projectId : {}", importOrcId, userName, workspaceName, projectName, projectVo.getId()); responseMsg.data(FLOW_ID_KEY, null); responseMsg.data(FLOW_BML_VERSION_KEY, null); } diff --git a/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/service/impl/MigrateServiceImpl.java b/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/service/impl/MigrateServiceImpl.java index 7944e1d861..6da2e43460 100644 --- a/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/service/impl/MigrateServiceImpl.java +++ b/dss-framework/framework-plugins/dss-framework-migrate-server/src/main/java/com/webank/wedatasphere/dss/migrate/service/impl/MigrateServiceImpl.java @@ -108,7 +108,7 @@ public void migrate(String userName, String inputZipPath, Workspace workspace) t LOG.error("fatal error, project {} 已经创建，但是创建人不是 {}", dssProject.getName(), dssProject.getCreateBy()); throw new MigrateErrorException(40035, "project has been created by others"); } else if (dbProject.getVisible() != null && dbProject.getVisible().intValue() != 1) { - LOG.error("fatal error, project {} 已经被删除 {}", dssProject.getName()); + LOG.error("fatal error, project {} 已经被删除", dssProject.getName()); throw new MigrateErrorException(40036, "The project has been deleted.Please restore project before exporting"); } else { DSSProjectVo dssProjectVo = new DSSProjectVo(); diff --git a/dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl/DSSFlowServiceImpl.java b/dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl/DSSFlowServiceImpl.java index 84d5b3f4b8..5bde57d103 100644 --- a/dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl/DSSFlowServiceImpl.java +++ b/dss-orchestrator/orchestrators/dss-workflow/dss-workflow-server/src/main/java/com/webank/wedatasphere/dss/workflow/service/impl/DSSFlowServiceImpl.java @@ -467,7 +467,7 @@ public void updateTOSaveStatus(Long projectId, Long flowID, Long orchestratorId) } } } catch (DSSErrorException e) { - logger.error("getProjectInfo failed by:", e); + logger.error("getProjectInfo failed by: ", e); throw new DSSRuntimeException(e.getErrCode(), "更新工作流状态失败，您可以尝试重新保存工作流！原因：" + ExceptionUtils.getRootCauseMessage(e), e); } }