Skip to content

Commit 8dc6d73

Browse files
committed
bug fix
1 parent f10b593 commit 8dc6d73

File tree

4 files changed

+21
-20
lines changed

4 files changed

+21
-20
lines changed

dss-framework/dss-framework-orchestrator-server/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -245,15 +245,6 @@
245245
</exclusions>
246246
</dependency>
247247

248-
249-
<dependency>
250-
<groupId>com.webank.wedatasphere.dss</groupId>
251-
<artifactId>dss-framework-project-server</artifactId>
252-
<version>${dss.version}</version>
253-
<scope>provided</scope>
254-
</dependency>
255-
256-
257248
</dependencies>
258249

259250
<build>

dss-framework/dss-framework-orchestrator-server/src/main/java/com/webank/wedatasphere/dss/orchestrator/server/restful/DSSFrameworkOrchestratorRestful.java

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import com.webank.wedatasphere.dss.common.utils.AuditLogUtils;
3131
import com.webank.wedatasphere.dss.common.utils.DSSExceptionUtils;
3232
import com.webank.wedatasphere.dss.common.utils.RpcAskUtils;
33-
import com.webank.wedatasphere.dss.framework.project.entity.DSSProjectDO;
34-
import com.webank.wedatasphere.dss.framework.project.service.DSSProjectService;
3533
import com.webank.wedatasphere.dss.framework.workspace.bean.itsm.ItsmRequest;
3634
import com.webank.wedatasphere.dss.framework.workspace.bean.itsm.ItsmResponse;
3735
import com.webank.wedatasphere.dss.framework.workspace.service.DSSWorkspaceRoleService;
@@ -125,10 +123,6 @@ public class DSSFrameworkOrchestratorRestful {
125123

126124
@Autowired
127125
private ProjectOrchestratorWhiteService projectOrchestratorWhiteService;
128-
@Autowired
129-
private DSSProjectService dssProjectService;
130-
131-
132126

133127
private final String encryptCopyWorkflowSuffix = "copy_cib";
134128

@@ -952,10 +946,9 @@ public ItsmResponse addProjectAndOrchestratorWhite(@RequestBody ItsmRequest itsm
952946

953947
try {
954948

949+
DSSProject dssProject = orchestratorFrameworkService.getProjectByName(projectName);
955950

956-
DSSProjectDO dbProject = dssProjectService.getProjectByName(projectName);
957-
958-
if (dbProject == null) {
951+
if (dssProject == null) {
959952
String msg = String.format("project %s does not exist.", projectName);
960953
LOGGER.error(msg);
961954
return ItsmResponse.error().retDetail(msg);
@@ -965,7 +958,7 @@ public ItsmResponse addProjectAndOrchestratorWhite(@RequestBody ItsmRequest itsm
965958

966959
if(!"*".equalsIgnoreCase(orchestratorName.trim())){
967960

968-
List<DSSOrchestratorInfo> orchestratorInfoList = orchestratorMapper.getByNameAndProjectId(dbProject.getId(),orchestratorName);
961+
List<DSSOrchestratorInfo> orchestratorInfoList = orchestratorMapper.getByNameAndProjectId(dssProject.getId(),orchestratorName);
969962

970963
if(CollectionUtils.isEmpty(orchestratorInfoList)){
971964
String msg = String.format("flow %s does not exist.", orchestratorName);
@@ -981,7 +974,7 @@ public ItsmResponse addProjectAndOrchestratorWhite(@RequestBody ItsmRequest itsm
981974
projectOrchestratorWhite.setOrchestratorId(orchestratorId);
982975
projectOrchestratorWhite.setOrchestratorName(orchestratorName);
983976
projectOrchestratorWhite.setProjectName(projectName);
984-
projectOrchestratorWhite.setProjectId(dbProject.getId());
977+
projectOrchestratorWhite.setProjectId(dssProject.getId());
985978
projectOrchestratorWhite.setCreateBy(createUser);
986979

987980
projectOrchestratorWhiteService.addProjectOrchestratorWhite(projectOrchestratorWhite);

dss-framework/dss-framework-orchestrator-server/src/main/java/com/webank/wedatasphere/dss/orchestrator/server/service/OrchestratorFrameworkService.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.webank.wedatasphere.dss.orchestrator.server.service;
1818

19+
import com.webank.wedatasphere.dss.common.entity.project.DSSProject;
1920
import com.webank.wedatasphere.dss.common.exception.DSSErrorException;
2021
import com.webank.wedatasphere.dss.common.label.LabelRouteVO;
2122
import com.webank.wedatasphere.dss.git.common.protocol.GitTree;
@@ -68,4 +69,7 @@ public interface OrchestratorFrameworkService {
6869

6970
DSSEncryptOrchestratorCopyInfo getDSSEncryptOrchestratorCopyInfo(String copyInfoId);
7071

72+
73+
DSSProject getProjectByName(String projectName);
74+
7175
}

dss-framework/dss-framework-orchestrator-server/src/main/java/com/webank/wedatasphere/dss/orchestrator/server/service/impl/OrchestratorFrameworkServiceImpl.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,4 +1158,17 @@ public DSSEncryptOrchestratorCopyInfo getDSSEncryptOrchestratorCopyInfo(String c
11581158
}
11591159

11601160

1161+
1162+
@Override
1163+
public DSSProject getProjectByName(String projectName){
1164+
1165+
List<String> projects = Collections.singletonList(projectName);
1166+
ProjectInfoListRequest request = new ProjectInfoListRequest();
1167+
request.setProjectNames(projects);
1168+
1169+
ProjectInfoListResponse response = RpcAskUtils.processAskException(DSSSenderServiceFactory.getOrCreateServiceInstance()
1170+
.getProjectServerSender().ask(request), ProjectInfoListResponse.class, ProjectInfoListRequest.class);
1171+
1172+
return CollectionUtils.isEmpty(response.getDssProjects()) ? null : response.getDssProjects().get(0);
1173+
}
11611174
}

0 commit comments

Comments
 (0)