Skip to content

Commit be2c9af

Browse files
committed
Release checklist: add new bullet about checking all PRs are milestoned
Rodrigo and me just noticed that a few PRs which were merged into the `3.2.0` release did not have a milestone attached. We've fixed those now and will fix the changelog too (only one needed a mention, the others were maintenance PRs). This commit just adds a new reminder bullet to verify that all PRs are milestoned before creating the changelog to (hopefully) prevent this from happening again. _Side-note: in other repos I actually have it required check for the milestone being set (can't merge without it), but that would require permission from the WordPress organisation to allow the [app which handles that](https://github.com/scholzj/milestone-check) and that might get complicated..._
1 parent fa635ad commit be2c9af

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/release-checklist.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ PR for tracking changes for the x.x.x release. Target release date: **DOW MONTH
3636

3737
### Release prep
3838

39+
- [ ] Double-check that all PRs which were merged since the last release have a milestone attached to it.
3940
- [ ] Add changelog for the release - PR #xxx
4041
:pencil2: Remember to add a release link at the bottom!
4142
- [ ] Update `README` (if applicable) - PR #xxx

0 commit comments

Comments
 (0)