Skip to content

Commit d18cc2a

Browse files
authored
[Refactor] QA - 메인피드 화면 개선 (#49)
2 parents 528890e + 8d190b0 commit d18cc2a

File tree

32 files changed

+352
-220
lines changed

32 files changed

+352
-220
lines changed

Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_sun.fill.imageset/Contents.json renamed to Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_home.fill.imageset/Contents.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"images" : [
33
{
4-
"filename" : "icon_sun.fill.svg",
4+
"filename" : "icon_home.fill.svg",
55
"idiom" : "universal"
66
}
77
],
Lines changed: 10 additions & 0 deletions
Loading

Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_sun.imageset/Contents.json renamed to Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_home.imageset/Contents.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"images" : [
33
{
4-
"filename" : "icon_sun.svg",
4+
"filename" : "icon_home.svg",
55
"idiom" : "universal"
66
}
77
],
Lines changed: 14 additions & 0 deletions
Loading

Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_sun.fill.imageset/icon_sun.fill.svg

Lines changed: 0 additions & 18 deletions
This file was deleted.

Fitfty/Projects/Common/Resources/Images.xcassets/icons/icon_sun.imageset/icon_sun.svg

Lines changed: 0 additions & 18 deletions
This file was deleted.

Fitfty/Projects/Common/Sources/AppAppearance.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,8 @@ public final class AppAppearance {
1414
UINavigationBar.appearance().largeTitleTextAttributes = [.foregroundColor: UIColor.label]
1515
UINavigationBar.appearance().titleTextAttributes = [.foregroundColor: UIColor.label]
1616
UINavigationBar.appearance().barTintColor = .white
17+
UITabBar.appearance().shadowImage = UIImage()
18+
UITabBar.appearance().backgroundImage = UIImage()
19+
UITabBar.appearance().backgroundColor = UIColor.white
1720
}
1821
}

Fitfty/Projects/Common/Sources/TabBarController.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public final class TabBarController: UITabBarController {
1313
public init() {
1414
super.init(nibName: nil, bundle: nil)
1515
object_setClass(self.tabBar, TabBar.self)
16-
self.tabBar.backgroundColor = .white
16+
applyShadow()
1717
}
1818

1919
required init?(coder: NSCoder) {
@@ -27,4 +27,11 @@ public final class TabBarController: UITabBarController {
2727
}
2828
}
2929

30+
private func applyShadow() {
31+
tabBar.layer.shadowColor = UIColor.black.cgColor
32+
tabBar.layer.shadowOpacity = 0.3
33+
tabBar.layer.shadowOffset = CGSize(width: 0, height: 0)
34+
tabBar.layer.shadowRadius = 0.33
35+
}
36+
3037
}

Fitfty/Projects/Common/Sources/WeatherTag.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@ public enum WeatherTag: String, Codable {
7777
}
7878
extension WeatherTag {
7979
public init(temp: Int) {
80-
if temp < 3 {
80+
if temp <= 3 {
8181
self = .freezing
82-
} else if temp > 3, temp < 9 {
82+
} else if temp >= 3, temp <= 9 {
8383
self = .cold
84-
} else if temp > 9, temp < 17 {
84+
} else if temp >= 9, temp <= 17 {
8585
self = .chilly
86-
} else if temp > 17, temp < 23 {
86+
} else if temp >= 17, temp <= 23 {
8787
self = .warm
8888
} else {
8989
self = .hot

Fitfty/Projects/Coordinator/Sources/TabCoordinator.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ enum TabBarPage {
3535

3636
var pageIconImage: UIImage? {
3737
switch self {
38-
case .weather: return CommonAsset.Images.iconSun.image.withRenderingMode(.alwaysOriginal)
38+
case .weather: return CommonAsset.Images.iconHome.image.withRenderingMode(.alwaysOriginal)
3939
case .createCody: return CommonAsset.Images.iconAdd.image.withRenderingMode(.alwaysOriginal)
4040
case .profile: return CommonAsset.Images.iconProfile.image.withRenderingMode(.alwaysOriginal)
4141
}
4242
}
4343

4444
public var selectedIconImage: UIImage? {
4545
switch self {
46-
case .weather: return CommonAsset.Images.iconSunFill.image.withRenderingMode(.alwaysOriginal)
46+
case .weather: return CommonAsset.Images.iconHomeFill.image.withRenderingMode(.alwaysOriginal)
4747
case .createCody: return CommonAsset.Images.iconAdd.image.withRenderingMode(.alwaysOriginal)
4848
case .profile: return CommonAsset.Images.iconProfileFill.image.withRenderingMode(.alwaysOriginal)
4949
}

0 commit comments

Comments
 (0)