Commit e63dfd9
committed
Fix TCK Quality compliance and SDK input validation
This PR addresses failures in the TCK Quality category (test_empty_arrays, test_boundary_values, test_task_state_transitions) by improving SDK validation and adjusting the SUT behavior for compliance.
1. SDK Validation Improvements (src/a2a/types.py)
- Enforced Non-Empty Messages: Added a Pydantic field_validator to Message.parts to reject empty lists.
- Enforced History Length Boundaries: Added validators to TaskQueryParams and MessageSendConfiguration to reject negative history_length values.
2. SUT Compatibility Fix (tck/sut_agent.py)
- Solution: Force blocking=False (Asynchronous) for the state transition test case using an interceptor pattern. This matches the pattern used in a2a-go and ensures the SUT returns 'submitted' or 'working' as expected by the TCK, without 'patching' the state.1 parent 28c12b3 commit e63dfd9
2 files changed
+65
-42
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
962 | 962 | | |
963 | 963 | | |
964 | 964 | | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
965 | 972 | | |
966 | 973 | | |
967 | 974 | | |
| |||
1288 | 1295 | | |
1289 | 1296 | | |
1290 | 1297 | | |
1291 | | - | |
1292 | 1298 | | |
1293 | 1299 | | |
1294 | 1300 | | |
1295 | 1301 | | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
1296 | 1309 | | |
1297 | 1310 | | |
1298 | 1311 | | |
| |||
1476 | 1489 | | |
1477 | 1490 | | |
1478 | 1491 | | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
1479 | 1499 | | |
1480 | 1500 | | |
1481 | 1501 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 31 | | |
31 | | - | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
| 74 | + | |
108 | 75 | | |
109 | 76 | | |
110 | 77 | | |
| |||
163 | 130 | | |
164 | 131 | | |
165 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
205 | 207 | | |
206 | 208 | | |
207 | 209 | | |
208 | | - | |
| 210 | + | |
| 211 | + | |
209 | 212 | | |
210 | | - | |
| 213 | + | |
211 | 214 | | |
212 | 215 | | |
213 | 216 | | |
| |||
0 commit comments