Fix: shortcode generator provides an ID, but shortcode parser doesn't support for poster.

joedolson · joedolson · commit 6789b1fc6ca0 · 2025-06-23T18:11:43.000-05:00
diff --git a/src/ableplayer.php b/src/ableplayer.php
@@ -506,7 +506,12 @@ function ableplayer_shortcode( $atts, $content = null ) {
 			$o .= ' preload="' . esc_attr( $preload ) . '"';
 		}
 		if ( ! empty( $all_atts['poster'] ) ) {
-			$o .= ' poster="' . esc_attr( $all_atts['poster'] ) . '"';
+			// Allow passing an attachment ID as poster.
+			$poster = $all_atts['poster'];
+			if ( is_numeric( $poster ) ) {
+				$poster = wp_get_attachment_image_url( $poster, 'large' );
+			}
+			$o .= ' poster="' . esc_attr( $poster ) . '"';
 		}
 		if ( ! empty( $all_atts['width'] ) ) {
 			$o .= ' width="' . esc_attr( $all_atts['width'] ) . '"';

Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,12 @@ function ableplayer_shortcode( $atts, $content = null ) {`
`506`	`506`	`$o .= ' preload="' . esc_attr( $preload ) . '"';`
`507`	`507`	`}`
`508`	`508`	`if ( ! empty( $all_atts['poster'] ) ) {`
`509`		`- $o .= ' poster="' . esc_attr( $all_atts['poster'] ) . '"';`
	`509`	`+ // Allow passing an attachment ID as poster.`
	`510`	`+ $poster = $all_atts['poster'];`
	`511`	`+ if ( is_numeric( $poster ) ) {`
	`512`	`+ $poster = wp_get_attachment_image_url( $poster, 'large' );`
	`513`	`+ }`
	`514`	`+ $o .= ' poster="' . esc_attr( $poster ) . '"';`
`510`	`515`	`}`
`511`	`516`	`if ( ! empty( $all_atts['width'] ) ) {`
`512`	`517`	`$o .= ' width="' . esc_attr( $all_atts['width'] ) . '"';`