Render messages inline in the Shortcodes tab so they don't interfere on settings.

joedolson · joedolson · commit 76b01c6ea73f · 2025-05-24T09:21:39.000-05:00
diff --git a/src/inc/generator.php b/src/inc/generator.php
@@ -65,6 +65,7 @@ function ableplayer_generate( $format = 'shortcode' ) {
 			}
 			$array['shortcode'] = "[$output]";
 			$array['message']   = __( 'New shortcode created.', 'ableplayer' );
+			$array['type']      = 'success';
 
 			return $array;
 		}
@@ -129,7 +130,7 @@ function ableplayer_generator_fields( $data ) {
 		$params = $data;
 	}
 	$message        = isset( $params['message'] ) ? $params['message'] : __( 'Generate an <code>[ableplayer]</code> shortcode.', 'ableplayer' );
-	$message_type   = isset( $params['type'] ) ? $params['type'] : 'success';
+	$message_type   = isset( $params['type'] ) ? $params['type'] : 'info';
 	$shortcode      = isset( $params['shortcode'] ) ? $params['shortcode'] : '[ableplayer]';
 	$last_shortcode = ableplayer_get_settings( 'last_shortcode' );
 	$shortcode      = ( ! isset( $params['shortcode'] ) && $last_shortcode ) ? "[$last_shortcode]" : $shortcode;
@@ -147,7 +148,8 @@ function ableplayer_generator_fields( $data ) {
 			wp_admin_notice(
 				$message,
 				array(
-					'type' => $message_type,
+					'type'               => $message_type,
+					'additional_classes' => array( 'inline' ),
 				)
 			);
 			?>

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ function ableplayer_generate( $format = 'shortcode' ) {`
`65`	`65`	`}`
`66`	`66`	`$array['shortcode'] = "[$output]";`
`67`	`67`	`$array['message'] = __( 'New shortcode created.', 'ableplayer' );`
	`68`	`+ $array['type'] = 'success';`
`68`	`69`
`69`	`70`	`return $array;`
`70`	`71`	`}`
`@@ -129,7 +130,7 @@ function ableplayer_generator_fields( $data ) {`
`129`	`130`	`$params = $data;`
`130`	`131`	`}`
`131`	`132`	`$message = isset( $params['message'] ) ? $params['message'] : __( 'Generate an <code>[ableplayer]</code> shortcode.', 'ableplayer' );`
`132`		`- $message_type = isset( $params['type'] ) ? $params['type'] : 'success';`
	`133`	`+ $message_type = isset( $params['type'] ) ? $params['type'] : 'info';`
`133`	`134`	`$shortcode = isset( $params['shortcode'] ) ? $params['shortcode'] : '[ableplayer]';`
`134`	`135`	`$last_shortcode = ableplayer_get_settings( 'last_shortcode' );`
`135`	`136`	`$shortcode = ( ! isset( $params['shortcode'] ) && $last_shortcode ) ? "[$last_shortcode]" : $shortcode;`
`@@ -147,7 +148,8 @@ function ableplayer_generator_fields( $data ) {`
`147`	`148`	`wp_admin_notice(`
`148`	`149`	`$message,`
`149`	`150`	`array(`
`150`		`- 'type' => $message_type,`
	`151`	`+ 'type' => $message_type,`
	`152`	`+ 'additional_classes' => array( 'inline' ),`
`151`	`153`	`)`
`152`	`154`	`);`
`153`	`155`	`?>`