PHPCS checks.

Author: joedolson

src/ableplayer.php

@@ -427,8 +427,8 @@ function ableplayer_shortcode( $atts, $content = null ) {
 		return false;
 	} else {
 		if ( $all_atts['media-id'] ) {
-			// If Video ID is set but is not a valid URL, 
-			$media_id = ( is_numeric($all_atts['media-id'] ) ) ? wp_get_attachment_url( $all_atts['media-id'] ) : $all_atts['media-id'];
+			// If Video ID is set but is not a valid URL, return.
+			$media_id = ( is_numeric( $all_atts['media-id'] ) ) ? wp_get_attachment_url( $all_atts['media-id'] ) : $all_atts['media-id'];
 			if ( ! $media_id ) {
 				return false;
 			} else {
@@ -450,12 +450,12 @@ function ableplayer_shortcode( $atts, $content = null ) {
 			foreach ( $kinds as $kind => $default_label ) {
 				$track = '';
 				if ( ! empty( $all_atts[ $kind ] ) ) {
-					$data     = explode( '|', $all_atts[ $kind ] );
+					$data = explode( '|', $all_atts[ $kind ] );
 					if ( empty( $data[0] ) ) {
 						continue;
 					}
 					// Optional lang and language.
-					$srclang  = (  isset( $data[1] ) && ! empty( $data[1] ) ) ? $data[1] : $default_lang;
+					$srclang  = ( isset( $data[1] ) && ! empty( $data[1] ) ) ? $data[1] : $default_lang;
 					$srclabel = ( isset( $data[2] ) && ! empty( $data[2] ) ) ? $data[2] : $default_label;
 					$src      = ( is_numeric( $data[0] ) ) ? wp_get_attachment_url( $data[0] ) : $data[0];
 					$track    = '<track kind="' . $kind . '" srclang="' . esc_attr( $srclang ) . '" srclabel="' . esc_attr( $srclabel ) . '" src="' . esc_url( $src ) . '">';

src/inc/generator.php

@@ -24,8 +24,8 @@ function ableplayer_generate( $format = 'shortcode' ) {
 		if ( ! wp_verify_nonce( $nonce, 'ableplayer-nonce' ) ) {
 			wp_die( 'Invalid nonce' );
 		}
-		$string = '';
-		$array  = array();
+		$string    = '';
+		$array     = array();
 		$shortcode = 'ableplayer';
 		$keys      = array( 'youtube-id', 'vimeo-id', 'media-id', 'poster', 'captions', 'subtitles', 'descriptions', 'chapters', 'autoplay', 'loop', 'playsinline', 'hidecontrols', 'heading', 'speed', 'start', 'volume', 'seekinterval' );
 		$post      = map_deep( $_POST, 'sanitize_text_field' );
@@ -73,7 +73,6 @@ function ableplayer_generate( $format = 'shortcode' ) {
 /**
  * Form to create a shortcode
  *
- * @param string $type Type of shortcode to reproduce.
  * @param array  $data Data submitted from shortcode generator.
  */
 function ableplayer_generator( $data = array() ) {
@@ -99,7 +98,7 @@ function ableplayer_generator_fields( $data ) {
 	}
 	$message        = isset( $params['message'] ) ? $params['message'] : __( 'Generate an <code>[ableplayer]</code> shortcode.', 'ableplayer' );
 	$message_type   = isset( $params['type'] ) ? $params['type'] : 'success';
-	$shortcode      = isset( $params['shortcode'] ) ? $params['shortcode'] : "[ableplayer]";
+	$shortcode      = isset( $params['shortcode'] ) ? $params['shortcode'] : '[ableplayer]';
 	$last_shortcode = ableplayer_get_settings( 'last_shortcode' );
 	$shortcode      = ( ! isset( $params['shortcode'] ) && $last_shortcode ) ? "[$last_shortcode]" : $shortcode;
 	?>
@@ -111,7 +110,7 @@ function ableplayer_generator_fields( $data ) {
 				array(
 					'type' => $message_type,
 				)
-				);
+			);
 			?>
 			<div><input type="hidden" name="_wpnonce" value="<?php echo esc_attr( wp_create_nonce( 'ableplayer-nonce' ) ); ?>"/></div>
 			<?php
@@ -131,9 +130,9 @@ function ableplayer_generator_fields( $data ) {
 				<?php
 				ableplayer_settings_field(
 					array(
-						'name'  => 'source_type',
-						'label' => __( 'Video Source Type', 'ableplayer' ),
-						'type'  => 'select',
+						'name'    => 'source_type',
+						'label'   => __( 'Video Source Type', 'ableplayer' ),
+						'type'    => 'select',
 						'default' => array(
 							'youtube' => 'YouTube',
 							'vimeo'   => 'Vimeo',
@@ -350,9 +349,9 @@ function ableplayer_generator_fields( $data ) {
 				<?php
 				ableplayer_settings_field(
 					array(
-						'name'     => 'heading',
-						'label'    => __( 'Hidden heading level', 'ableplayer' ),
-						'type'     => 'select',
+						'name'    => 'heading',
+						'label'   => __( 'Hidden heading level', 'ableplayer' ),
+						'type'    => 'select',
 						'default' => array(
 							'auto' => __( 'Automatically assigned', 'ableplayer' ),
 							'0'    => __( 'No heading', 'ableplayer' ),
@@ -369,12 +368,12 @@ function ableplayer_generator_fields( $data ) {
 				<?php
 				ableplayer_settings_field(
 					array(
-						'name'     => 'speed',
-						'label'    => __( 'Speed selection control', 'ableplayer' ),
-						'type'     => 'select',
+						'name'    => 'speed',
+						'label'   => __( 'Speed selection control', 'ableplayer' ),
+						'type'    => 'select',
 						'default' => array(
 							'animals' => __( 'Animals: Tortoise and Hare', 'ableplayer' ),
-							'arrows'    => __( 'Arrows', 'ableplayer' ),
+							'arrows'  => __( 'Arrows', 'ableplayer' ),
 						),
 					),
 					'generator'

src/inc/settings.php

@@ -50,7 +50,7 @@ function ableplayer_update_setting( $key, $value = '' ) {
 /**
  * Generate input & field for an AblePlayer setting.
  *
- * @param array $args {
+ * @param array  $args {
  *     Array of settings arguments.
  *
  *     @type string       $name Name of the option used in name attribute. Required.