From 252374e34b2eb728c1c7a37b775cc5d6d6a5528e Mon Sep 17 00:00:00 2001 From: NullPointer-cell Date: Thu, 15 Jan 2026 13:15:48 +0530 Subject: [PATCH 1/5] Add BSD license detection rule for JLine XML comments Fixes #4576 Adds bsd-new_jline_xml.RULE to detect BSD-3-Clause license in JLine POM files License was previously undetected because it was in XML comments Tested on jline-console, applies to jline-style and jline-reader as well Signed-off-by: NullPointer-cell --- .../data/rules/bsd-new_jline_xml.RULE | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 src/licensedcode/data/rules/bsd-new_jline_xml.RULE diff --git a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE new file mode 100644 index 0000000000..a9460a8174 --- /dev/null +++ b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE @@ -0,0 +1,15 @@ +--- +license_expression: bsd-new +is_license_notice: yes +relevance: 100 +ignorable_urls: + - https://opensource.org/licenses/BSD-3-Clause +notes: | + License notice found in XML comments of JLine project POM files. + Appears in jline-console, jline-style, and jline-reader modules. +--- + +Copyright (c) 2002-2025, the original author or authors. +This software is distributable under the BSD license. See the terms of the +BSD license in the documentation provided with this software. +https://opensource.org/licenses/BSD-3-Clause From 68b357373930db1a9f8dd688bd198bb6bdd7cdb2 Mon Sep 17 00:00:00 2001 From: NullPointer-cell Date: Thu, 15 Jan 2026 14:57:59 +0530 Subject: [PATCH 2/5] Fix BSD license rule validation error Remove ignorable_urls field to fix CI validation test failures Signed-off-by: NullPointer-cell --- src/licensedcode/data/rules/bsd-new_jline_xml.RULE | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE index a9460a8174..24347d3db3 100644 --- a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE +++ b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE @@ -2,8 +2,6 @@ license_expression: bsd-new is_license_notice: yes relevance: 100 -ignorable_urls: - - https://opensource.org/licenses/BSD-3-Clause notes: | License notice found in XML comments of JLine project POM files. Appears in jline-console, jline-style, and jline-reader modules. From f0911b44b552b05c05caa4f8994a914df842fa3a Mon Sep 17 00:00:00 2001 From: NullPointer-cell Date: Thu, 15 Jan 2026 19:41:56 +0530 Subject: [PATCH 3/5] Fix: Add ignorable_urls to BSD license rule The URL in the license text must be declared in ignorable_urls to pass CI validation checks. Signed-off-by: NullPointer-cell --- src/licensedcode/data/rules/bsd-new_jline_xml.RULE | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE index 24347d3db3..a9460a8174 100644 --- a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE +++ b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE @@ -2,6 +2,8 @@ license_expression: bsd-new is_license_notice: yes relevance: 100 +ignorable_urls: + - https://opensource.org/licenses/BSD-3-Clause notes: | License notice found in XML comments of JLine project POM files. Appears in jline-console, jline-style, and jline-reader modules. From 54a9f17d9d48641c871a2759e5f6b8c7ef54cbe3 Mon Sep 17 00:00:00 2001 From: NullPointer-cell Date: Fri, 16 Jan 2026 12:41:58 +0530 Subject: [PATCH 4/5] Fix: Add all ignorable fields for BSD license rule Added ignorable_copyrights and ignorable_holders to match the copyright statement and holder in the license text. This fixes the CI validation test. Signed-off-by: NullPointer-cell --- src/licensedcode/data/rules/bsd-new_jline_xml.RULE | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE index a9460a8174..85e18348b9 100644 --- a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE +++ b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE @@ -2,6 +2,10 @@ license_expression: bsd-new is_license_notice: yes relevance: 100 +ignorable_copyrights: + - Copyright (c) 2002-2025, the original author or authors +ignorable_holders: + - the original author or authors ignorable_urls: - https://opensource.org/licenses/BSD-3-Clause notes: | From 9e66baebbeb9b8d6598d9124726c924140221329 Mon Sep 17 00:00:00 2001 From: NullPointer-cell Date: Thu, 22 Jan 2026 01:08:45 +0530 Subject: [PATCH 5/5] Fix: Correct copyright year to match actual JLine source (2020 not 2025) Signed-off-by: NullPointer-cell --- src/licensedcode/data/rules/bsd-new_jline_xml.RULE | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE index 85e18348b9..021bb5d519 100644 --- a/src/licensedcode/data/rules/bsd-new_jline_xml.RULE +++ b/src/licensedcode/data/rules/bsd-new_jline_xml.RULE @@ -3,7 +3,7 @@ license_expression: bsd-new is_license_notice: yes relevance: 100 ignorable_copyrights: - - Copyright (c) 2002-2025, the original author or authors + - Copyright (c) 2002-2020, the original author or authors ignorable_holders: - the original author or authors ignorable_urls: @@ -13,7 +13,7 @@ notes: | Appears in jline-console, jline-style, and jline-reader modules. --- -Copyright (c) 2002-2025, the original author or authors. +Copyright (c) 2002-2020, the original author or authors. This software is distributable under the BSD license. See the terms of the BSD license in the documentation provided with this software. https://opensource.org/licenses/BSD-3-Clause