Merge pull request #442 from abraham/copilot/fix-687218e6-a2f6-4522-8542-08c02d239390

Fix missing enum values in NotificationGroup type by respecting blocked files in EntityParser

Author: abraham

dist/schema.json

@@ -38092,7 +38092,7 @@
             }
           },
           "status_id": {
-            "description": "ID of the [Status]({{< relref \"entities/Status\" >}}) that was the object of the notification. Attached when `type` of the notification is `favourite`, `reblog`, `status`, `mention`, `poll`, or `update`.",
+            "description": "ID of the [Status]({{< relref \"entities/Status\" >}}) that was the object of the notification. Attached when `type` of the notification is `favourite`, `reblog`, `status`, `mention`, `poll`, `update`, `quote` or `quoted_update`. In the case of `quoted_update`, your quote of the edited status is attached, not the status that was edited.",
             "type": [
               "string",
               "null"
@@ -38104,7 +38104,7 @@
               "string",
               "null"
             ],
-            "$ref": "#/components/schemas/NotificationGroupTypeEnum"
+            "$ref": "#/components/schemas/NotificationTypeEnum"
           }
         },
         "externalDocs": {
@@ -38709,23 +38709,6 @@
           "account_suspension"
         ]
       },
-      "NotificationGroupTypeEnum": {
-        "type": "string",
-        "enum": [
-          "mention",
-          "status",
-          "reblog",
-          "follow",
-          "follow_request",
-          "favourite",
-          "poll",
-          "update",
-          "admin.sign_up",
-          "admin.report",
-          "severed_relationships",
-          "moderation_warning"
-        ]
-      },
       "GetApiV1NotificationsParamTypesEnum": {
         "type": "string",
         "enum": [

src/__tests__/parsers/EntityParser.draft.test.ts

@@ -40,6 +40,6 @@ describe('EntityParser - Draft File Handling', () => {
     // This test validates that only explicit draft: true is filtered
     // This is implicitly tested by checking that we still get a reasonable number of entities
     const entities = parser.parseAllEntities();
-    expect(entities.length).toBe(93); // Exact count after removing EncryptedMessage (increased due to extracted nested entities + Admin::DimensionData + DiscoverOauthServerConfigurationResponse + OEmbedResponse)
+    expect(entities.length).toBe(90); // Exact count after removing EncryptedMessage and entities from blocked files (increased due to extracted nested entities + Admin::DimensionData + DiscoverOauthServerConfigurationResponse + OEmbedResponse)
   });
 });

src/__tests__/parsers/EntityParser.methodEntities.test.ts

@@ -55,6 +55,42 @@ describe('EntityParser - Method Entity Extraction', () => {
       expect(notificationGroup.attributes.some((a) => a.name === 'type')).toBe(
         true
       );
+
+      // Check that type attribute has enum values including quote and quoted_update
+      const typeAttribute = notificationGroup.attributes.find(
+        (a) => a.name === 'type'
+      );
+      expect(typeAttribute).toBeDefined();
+      if (typeAttribute) {
+        expect(typeAttribute.enumValues).toBeDefined();
+        expect(typeAttribute.enumValues).toContain('quote');
+        expect(typeAttribute.enumValues).toContain('quoted_update');
+        expect(typeAttribute.enumValues).toContain('mention');
+        expect(typeAttribute.enumValues).toContain('favourite');
+        // Should have all 14 values
+        expect(typeAttribute.enumValues?.length).toBe(14);
+      }
     }
   });
+
+  test('should skip blocked method files for entity parsing', () => {
+    const entities = parser.parseAllEntities();
+
+    // Find all NotificationGroup entities
+    const notificationGroups = entities.filter(
+      (e) => e.name === 'NotificationGroup'
+    );
+
+    // Should only have one NotificationGroup entity (from grouped_notifications.md, not notifications_alpha.md)
+    expect(notificationGroups).toHaveLength(1);
+
+    // The single NotificationGroup should have complete enum values
+    const notificationGroup = notificationGroups[0];
+    const typeAttribute = notificationGroup.attributes.find(
+      (a) => a.name === 'type'
+    );
+    expect(typeAttribute?.enumValues).toContain('quote');
+    expect(typeAttribute?.enumValues).toContain('quoted_update');
+    expect(typeAttribute?.enumValues?.length).toBe(14);
+  });
 });

src/parsers/EntityParser.ts

@@ -46,11 +46,29 @@ class EntityParser {
 
     // Parse entities from method files
     if (fs.existsSync(this.methodsPath)) {
+      // Load blocked files from config
+      let blockedFiles: string[] = [];
+      try {
+        const config = JSON.parse(fs.readFileSync('config.json', 'utf8'));
+        blockedFiles = config.blockedFiles || [];
+      } catch (error) {
+        console.warn('Could not load blockedFiles from config.json:', error);
+      }
+
       const methodFiles = fs
         .readdirSync(this.methodsPath)
         .filter((file) => file.endsWith('.md'));
 
       for (const file of methodFiles) {
+        // Check if file is blocked
+        const relativePath = `methods/${file}`;
+        if (blockedFiles.includes(relativePath)) {
+          console.log(
+            `Skipping blocked file for entity parsing: ${relativePath}`
+          );
+          continue;
+        }
+
         try {
           const methodEntities = MethodEntityParser.parseEntitiesFromMethodFile(
             path.join(this.methodsPath, file)