fix cmake include header (#7)

Author: anonrig

CMakeLists.txt

@@ -8,8 +8,25 @@ if (NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)
 endif()
 
+include(GNUInstallDirs)
 
 add_subdirectory(src)
 enable_testing()
 add_subdirectory(tests)
-add_subdirectory(benchmarks)
+add_subdirectory(benchmarks)
+
+install(
+  FILES include/version_weaver.h
+  DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
+  COMPONENT version_weaver_development
+)
+
+install(
+  TARGETS version_weaver
+  EXPORT version_weaver_targets
+  RUNTIME COMPONENT version_weaver_runtime
+  LIBRARY COMPONENT version_weaver_runtime
+  NAMELINK_COMPONENT version_weaver_development
+  ARCHIVE COMPONENT version_weaver_development
+  INCLUDES DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
+)

src/CMakeLists.txt

@@ -3,4 +3,4 @@ target_include_directories(version_weaver
   PUBLIC
    $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
    $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
-)
+)

src/version_weaver.cpp

@@ -13,22 +13,22 @@ std::string coerce(std::string_view version) { return ""; }
 std::string minimum(std::string_view range) { return ""; }
 std::string clean(std::string_view range) { return ""; }
 
-inline std::string_view trim_whitespace(std::string_view input) noexcept {
-  while (!input.empty() && std::isspace(input.front())) {
-    input.remove_prefix(1);
+inline void trim_whitespace(std::string_view* input) noexcept {
+  while (!input->empty() && std::isspace(input->front())) {
+    input->remove_prefix(1);
   }
-  while (!input.empty() && std::isspace(input.back())) {
-    input.remove_suffix(1);
+  while (!input->empty() && std::isspace(input->back())) {
+    input->remove_suffix(1);
   }
-  return input;
 }
 
 std::expected<Version, ParseError> parse(std::string_view input) {
   if (input.size() > MAX_VERSION_LENGTH) {
     return std::unexpected(ParseError::VERSION_LARGER_THAN_MAX_LENGTH);
   }
 
-  std::string_view input_copy = trim_whitespace(input);
+  std::string_view input_copy = input;
+  trim_whitespace(&input_copy);
 
   auto dot_iterator = input_copy.find('.');
   if (dot_iterator == std::string_view::npos) {
@@ -90,4 +90,5 @@ std::expected<Version, ParseError> parse(std::string_view input) {
   version.build = input_copy;
   return version;
 }
+
 }  // namespace version_weaver