[CHG] review of OCA#522 & add setup for auth_admin

Author: Jonathan Nemry (ACSONE)

auth_admin_passkey/__openerp__.py

@@ -4,7 +4,7 @@
 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
 
 {
-    'name': 'Authentification - Admin Passkey',
+    'name': 'Authentication - Admin Passkey',
     'version': '8.0.2.1.1',
     'category': 'base',
     'author': "GRAP,Odoo Community Association (OCA)",
@@ -17,12 +17,6 @@
         'data/ir_config_parameter.xml',
         'view/res_config_view.xml',
     ],
-    'demo': [],
-    'js': [],
-    'css': [],
-    'qweb': [],
-    'images': [],
-    'post_load': '',
     'application': False,
     'installable': True,
     'auto_install': False,

auth_admin_passkey/model/res_config.py

@@ -9,6 +9,18 @@
 class BaseConfigSettings(models.TransientModel):
     _inherit = 'base.config.settings'
 
+    auth_admin_passkey_send_to_admin = fields.Boolean(
+        string='Send email to admin user.',
+        help="""When the administrator use his password to login in """
+             """with a different account, OpenERP will send an email """
+             """to the admin user.""")
+
+    auth_admin_passkey_send_to_user = fields.Boolean(
+        string='Send email to user.',
+        help="""When the administrator use his password to login in """
+             """with a different account, OpenERP will send an email """
+             """to the account user.""")
+
     # Getter / Setter Section
     @api.model
     def get_default_auth_admin_passkey_send_to_admin(self, fields):
@@ -39,15 +51,3 @@ def set_auth_admin_passkey_send_to_user(self):
             self.env['ir.config_parameter'].set_param(
                 "auth_admin_passkey.send_to_user",
                 config.auth_admin_passkey_send_to_user or '')
-
-    auth_admin_passkey_send_to_admin = fields.Boolean(
-        string='Send email to admin user.',
-        help="""When the administrator use his password to login in """
-             """with a different account, OpenERP will send an email """
-             """to the admin user.""")
-
-    auth_admin_passkey_send_to_user = fields.Boolean(
-        string='Send email to user.',
-        help="""When the administrator use his password to login in """
-             """with a different account, OpenERP will send an email """
-             """to the account user.""")

auth_admin_passkey/model/res_users.py

@@ -3,12 +3,10 @@
 # @author Sylvain LE GAL (https://twitter.com/legalsylvain)
 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
 
-import datetime
-
 from openerp import SUPERUSER_ID
 from openerp import registry
 from openerp import exceptions
-from openerp import models, api
+from openerp import api, fields, models
 from openerp.tools.translate import _
 from openerp.tools.safe_eval import safe_eval
 
@@ -50,7 +48,7 @@ def _send_email_passkey(self, user_agent_env):
                     """\n\nTechnicals informations belows : \n\n"""
                     """- Login date : %s\n\n""")) % (
                         login_user.login,
-                        datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S"))
+                        fields.Datetime.now())
             for k, v in user_agent_env.iteritems():
                 body += ("- %s : %s\n\n") % (k, v)
             mail_obj.sudo().create({
@@ -68,7 +66,7 @@ def _send_email_same_password(self, login_user):
             mail_obj.sudo().create({
                 'email_to': admin_user.email,
                 'subject': self._get_translation(
-                    admin_user.lang, _('[WARNING] OpenERP Security Risk')),
+                    admin_user.lang, _('[WARNING] Odoo Security Risk')),
                 'body_html': self._get_translation(
                     admin_user.lang, _(
                         """<pre>User with login '%s' has the same """

setup/auth_admin_passkey/odoo_addons/__init__.py

@@ -0,0 +1 @@
+__import__('pkg_resources').declare_namespace(__name__)

setup/auth_admin_passkey/odoo_addons/auth_admin_passkey

@@ -0,0 +1 @@
+../../../auth_admin_passkey

setup/auth_admin_passkey/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)