Skip to content

Commit 9e1e644

Browse files
jeremyederclaude
andauthored
fix(ci): resolve YAML parsing error in amber-auto-review workflow (#419)
## Summary Fixes the CI failure affecting PR #417 and all future pull requests. ## Problem The `amber-auto-review.yml` workflow was failing with: ``` SyntaxError: Unexpected end of input ``` **Root Cause**: The YAML parser was confused by the `---` markdown separator on line 168, which appeared as a standalone line inside a JavaScript template literal. YAML interprets `---` as a document separator, causing the workflow file structure to become invalid. ## Solution Converted the JavaScript template literal to string concatenation to avoid having `---` appear as a standalone line in the YAML structure. This prevents the YAML parser from misinterpreting markdown formatting as YAML syntax. ### Changes - Replaced multiline template literal (lines 166-189) with string concatenation - No functional changes - the generated markdown is identical - Resolved yamllint syntax errors ## Testing - ✅ Local YAML validation passes (yamllint) - ✅ File structure validated - ✅ Will be tested on this PR's CI run ## Impact - Fixes PR #417 CI failure - Prevents future failures on all PRs with Amber code review enabled --- Closes #417 (CI failure) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent 0274ee7 commit 9e1e644

File tree

1 file changed

+14
-24
lines changed

1 file changed

+14
-24
lines changed

.github/workflows/amber-auto-review.yml

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -163,30 +163,20 @@ jobs:
163163
return;
164164
}
165165
166-
const transparencySection = `
167-
168-
---
169-
🔍 [View AI decision process](${serverUrl}/${repository}/actions/runs/${runId}) (logs available for 90 days)
170-
171-
<details>
172-
<summary>📋 View memory system files loaded (click to expand)</summary>
173-
174-
### What Amber Loaded for Code Review
175-
176-
Amber automatically loaded these repository standards from the memory system:
177-
178-
1. **CLAUDE.md** - Master project instructions, development standards
179-
2. **backend-development.md** - Go backend, K8s integration patterns
180-
3. **frontend-development.md** - NextJS, Shadcn UI, React Query patterns
181-
4. **security-standards.md** - Auth, RBAC, token handling
182-
5. **k8s-client-usage.md** - User token vs service account patterns
183-
6. **error-handling.md** - Consistent error patterns
184-
7. **react-query-usage.md** - Data fetching patterns
185-
186-
**Impact**: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.
187-
188-
</details>
189-
`;
166+
const transparencySection = '\n\n---\n🔍 [View AI decision process](' + serverUrl + '/' + repository + '/actions/runs/' + runId + ') (logs available for 90 days)\n\n' +
167+
'<details>\n' +
168+
'<summary>📋 View memory system files loaded (click to expand)</summary>\n\n' +
169+
'### What Amber Loaded for Code Review\n\n' +
170+
'Amber automatically loaded these repository standards from the memory system:\n\n' +
171+
'1. **CLAUDE.md** - Master project instructions, development standards\n' +
172+
'2. **backend-development.md** - Go backend, K8s integration patterns\n' +
173+
'3. **frontend-development.md** - NextJS, Shadcn UI, React Query patterns\n' +
174+
'4. **security-standards.md** - Auth, RBAC, token handling\n' +
175+
'5. **k8s-client-usage.md** - User token vs service account patterns\n' +
176+
'6. **error-handling.md** - Consistent error patterns\n' +
177+
'7. **react-query-usage.md** - Data fetching patterns\n\n' +
178+
'**Impact**: This review used your repository\'s specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.\n\n' +
179+
'</details>';
190180
191181
const updatedBody = reviewComment.body + transparencySection;
192182

0 commit comments

Comments
 (0)