tslint: catch dangling promises

Author: Jacob Peddicord

browser/components/projects/acl/ProjectAclEditor.tsx

@@ -22,7 +22,6 @@ import * as ProjectActions from '../../../modules/projects';
 interface Props {
   dispatch: (action: any) => any;
   project: WebProject;
-  groups: string[];
 }
 
 interface State {
@@ -88,7 +87,6 @@ class ProjectAclEditor extends React.Component<Props, State> {
   }
 
   render() {
-    const { groups } = this.props;
     const { sortedAcl } = this.state;
 
     return <form onSubmit={this.save}>

browser/components/projects/render/AttributionDocBuilder.tsx

@@ -37,7 +37,6 @@ class AttributionDocBuilder extends Component<Props, State> {
   };
   componentWillMount() {
     const { dispatch, project: { projectId } } = this.props;
-    const activeProjectId = this.props.project.projectId;
     dispatch(ProjectActions.buildAttributionDoc(projectId));
   }
 
@@ -82,7 +81,7 @@ class AttributionDocBuilder extends Component<Props, State> {
   }
 
   render() {
-    const { attributionDoc: { lines, warnings }, project: { title, version, projectId } } = this.props;
+    const { attributionDoc: { lines, warnings }, project: { title, version } } = this.props;
     const { highlights } = this.state;
 
     return (

package-lock.json

@@ -65,6 +65,7 @@
     "selenium-webdriver": "^3.0.1",
     "ts-loader": "^2.3.2",
     "tslint": "^5.5.0",
+    "tslint-language-service": "^0.9.7",
     "typescript": "^2.6.2",
     "url-loader": "^0.5.9",
     "webpack": "^3.6.0",

package.json

@@ -12,6 +12,8 @@
  * permissions and limitations under the License.
  */
 
+/* tslint:disable:no-floating-promises */
+
 import { By, until } from 'selenium-webdriver';
 import build, { CustomDriver } from './driver';
 

selenium/landing.spec.ts

@@ -12,6 +12,8 @@
  * permissions and limitations under the License.
  */
 
+/* tslint:disable:no-floating-promises */
+
 import {By, until} from 'selenium-webdriver';
 import build, { CustomDriver } from './driver';
 

selenium/projects-auth.spec.ts

@@ -12,6 +12,8 @@
  * permissions and limitations under the License.
  */
 
+/* tslint:disable:no-floating-promises */
+
 import {By, Key, until} from 'selenium-webdriver';
 import build, { CustomDriver } from './driver';
 

selenium/projects.spec.ts

@@ -136,7 +136,7 @@ export async function storePackage(req: any, packageId: number, info: Pick<WebPa
 export async function verifyPackage(req: any, packageId: number, verified: boolean,
                                     comments: string): Promise<Partial<WebPackage>> {
   const user = auth.extractRequestUser(req);
-  assertCanValidate(req);
+  await assertCanValidate(req);
   await Promise.all([
     db.addVerification(packageId, user, comments),
     db.verifyPackage(packageId, verified),
@@ -146,7 +146,7 @@ export async function verifyPackage(req: any, packageId: number, verified: boole
 }
 
 export async function getVerificationQueue(req: any): Promise<{queue: Array<Partial<WebPackage>>}> {
-  assertCanValidate(req);
+  await assertCanValidate(req);
   const results = await db.getUnverifiedPackages(25);
   const queue = results.map((item) => ({
     packageId: item.package_id,

server/api/packages/index.ts

@@ -233,7 +233,7 @@ export async function generateAttributionDocument(req: Request, projectId: strin
 
   // save a copy if requested
   if (store) {
-    documentdb.storeAttributionDocument(projectId, project.version, text, user);
+    await documentdb.storeAttributionDocument(projectId, project.version, text, user);
     winston.info(`Document for project ${projectId} was stored by ${user}`);
     return {text};
   }

server/api/projects/index.ts

@@ -48,113 +48,113 @@ function pack(promise: Promise<any>, res: any | undefined, next: any | undefined
 }
 
 /*** User/session/general info ***/
-router.get('/info', (req, res, next) => {
-  pack(userInfo(req), res, next);
+router.get('/info', async (req, res, next) => {
+  await pack(userInfo(req), res, next);
 });
 
 /*** Projects ***/
 
 /**
  * List all projects filtered by access.
  */
-router.get('/projects', (req, res, next) => {
-  pack(projectAPI.searchProjects(req), res, next);
+router.get('/projects', async (req, res, next) => {
+  await pack(projectAPI.searchProjects(req), res, next);
 });
 
 /**
  * Create a new project.
  */
-router.post('/projects/new', projectValidators.createProject, (req, res, next) => {
-  pack(projectAPI.createProject(req, req.body), res, next);
+router.post('/projects/new', projectValidators.createProject, async (req, res, next) => {
+  await pack(projectAPI.createProject(req, req.body), res, next);
 });
 
 /**
  * Get a particular project.
  */
-router.get('/projects/:projectId', (req, res, next) => {
-  pack(projectAPI.getProject(req, req.params.projectId), res, next);
+router.get('/projects/:projectId', async (req, res, next) => {
+  await pack(projectAPI.getProject(req, req.params.projectId), res, next);
 });
 
 /**
  * Edit a project's basic details.
  */
-router.patch('/projects/:projectId', projectValidators.patchProject, (req, res, next) => {
-  pack(projectAPI.patchProject(req, req.params.projectId, req.body), res, next);
+router.patch('/projects/:projectId', projectValidators.patchProject, async (req, res, next) => {
+  await pack(projectAPI.patchProject(req, req.params.projectId, req.body), res, next);
 });
 
 /**
  * Attach a package to a project, optionally creating or updating the package.
  */
-router.post('/projects/:projectId/attach', projectValidators.attachPackage, (req, res, next) => {
-  pack(projectAPI.attachPackage(req, req.params.projectId, req.body), res, next);
+router.post('/projects/:projectId/attach', projectValidators.attachPackage, async (req, res, next) => {
+  await pack(projectAPI.attachPackage(req, req.params.projectId, req.body), res, next);
 });
 
 /**
  * Detach a package from a project.
  */
-router.post('/projects/:projectId/detach', (req, res, next) => {
-  pack(projectAPI.detachPackage(req, req.params.projectId, req.body.packageId), res, next);
+router.post('/projects/:projectId/detach', async (req, res, next) => {
+  await pack(projectAPI.detachPackage(req, req.params.projectId, req.body.packageId), res, next);
 });
 
 /**
  * Replace a package instance with another, without changing the usage.
  */
-router.post('/projects/:projectId/replace', projectValidators.replacePackage, (req, res, next) => {
-  pack(projectAPI.replacePackage(req, req.params.projectId, req.body.oldId, req.body.newId), res, next);
+router.post('/projects/:projectId/replace', projectValidators.replacePackage, async (req, res, next) => {
+  await pack(projectAPI.replacePackage(req, req.params.projectId, req.body.oldId, req.body.newId), res, next);
 });
 
 /**
  * Build an attribution document. Return the document along
  * with any warnings.
  */
-router.get('/projects/:projectId/build', (req, res, next) => {
-  pack(projectAPI.generateAttributionDocument(req, req.params.projectId), res, next);
+router.get('/projects/:projectId/build', async (req, res, next) => {
+  await pack(projectAPI.generateAttributionDocument(req, req.params.projectId), res, next);
 });
 
 /**
  * Building a document using POST will trigger a store & download.
  */
-router.post('/projects/:projectId/build', (req, res, next) => {
-  pack(projectAPI.generateAttributionDocument(req, req.params.projectId, true), res, next);
+router.post('/projects/:projectId/build', async (req, res, next) => {
+  await pack(projectAPI.generateAttributionDocument(req, req.params.projectId, true), res, next);
 });
 
 /*** Packages ***/
 
 /**
  * Search all packages by name/version.
  */
-router.post('/packages/', (req, res, next) => {
-  pack(packageAPI.searchPackages(req, req.body.query), res, next);
+router.post('/packages/', async (req, res, next) => {
+  await pack(packageAPI.searchPackages(req, req.body.query), res, next);
 });
 
 /**
  * Admin action: fetch the package verification queue.
  */
-router.get('/packages/verification', (req, res, next) => {
-  pack(packageAPI.getVerificationQueue(req), res, next);
+router.get('/packages/verification', async (req, res, next) => {
+  await pack(packageAPI.getVerificationQueue(req), res, next);
 });
 
 /**
  * Get a single package.
  */
-router.get('/packages/:packageId', (req, res, next) => {
-  pack(packageAPI.getPackage(req, req.params.packageId, req.query.extended != null), res, next);
+router.get('/packages/:packageId', async (req, res, next) => {
+  await pack(packageAPI.getPackage(req, req.params.packageId, req.query.extended != null), res, next);
 });
 
 /**
  * Verify (accept/reject with comments) a single package.
  */
-router.post('/packages/:packageId/verify', (req, res, next) => {
-  pack(packageAPI.verifyPackage(req, req.params.packageId, req.body.verified, req.body.comments), res, next);
+router.post('/packages/:packageId/verify', async (req, res, next) => {
+  await pack(packageAPI.verifyPackage(req, req.params.packageId, req.body.verified, req.body.comments), res, next);
 });
 
 /*** Licenses ***/
 
 /**
  * Retrieve all license and tag data.
  */
-router.get('/licenses/', (req, res, next) => {
-  pack(licenseAPI.listLicenses(), res, next);
+router.get('/licenses/', async (req, res, next) => {
+  await pack(licenseAPI.listLicenses(), res, next);
 });
 
 // error handling for all of the above