Fix some code inspection warnings

Author: andrei-punko

build.gradle

@@ -36,11 +36,11 @@ description = 'java-interview-coding'
 java.sourceCompatibility = JavaVersion.VERSION_21
 java.targetCompatibility = JavaVersion.VERSION_21
 
-tasks.withType(JavaCompile) {
+tasks.withType(JavaCompile).configureEach {
     options.encoding = 'UTF-8'
 }
 
-tasks.withType(Test) {
+tasks.withType(Test).configureEach {
     testLogging {
         events "passed", "skipped", "failed",
                 // "standardOut",   // Uncomment to get all logs during tests execution
@@ -81,7 +81,7 @@ jacocoTestReport {
     }
 }
 
-task githubWorkflowTest(type: Test) {
+tasks.register('githubWorkflowTest', Test) {
     exclude '**/**AddMultithreadingTest.class'
     exclude '**/**BlockingQueueTest.class'
     exclude '**/**DeadlockTest.class'

src/main/java/by/andd3dfx/collections/custom/CustomLinkedList.java

@@ -10,9 +10,9 @@
 public class CustomLinkedList<T> implements Iterable<T> {
 
     @AllArgsConstructor
-    public class Node<T> {
-        private T value;
-        private Node<T> next;
+    public static class Node<M> {
+        private M value;
+        private Node<M> next;
 
         @Override
         public String toString() {
@@ -36,22 +36,20 @@ public void add(int index, T value) {
         }
 
         if (index == 0) {
-            var newNode = new Node(value, head);
-            head = newNode;
+            head = new Node<>(value, head);
             size++;
             return;
         }
 
         int i = 1;
-        Node prev = head;
-        Node curr = head.next;
+        Node<T> prev = head;
+        Node<T> curr = head.next;
         while (i < index) {
             i++;
             prev = curr;
             curr = curr.next;
         }
-        var newNode = new Node(value, curr);
-        prev.next = newNode;
+        prev.next = new Node<>(value, curr);
         size++;
     }
 
@@ -152,11 +150,11 @@ public T pop() {
     }
 
     public void reverse() {
-        Node prev = null;
-        Node curr = head;
+        Node<T> prev = null;
+        Node<T> curr = head;
 
         while (curr != null) {
-            Node next = curr.next;
+            Node<T> next = curr.next;
             curr.next = prev;
             prev = curr;
             curr = next;
@@ -171,11 +169,11 @@ public void clear() {
 
     @Override
     public Iterator<T> iterator() {
-        return new CustomIterator(head);
+        return new CustomIterator<>(head);
     }
 
     @AllArgsConstructor
-    public class CustomIterator<E> implements Iterator<E> {
+    public static class CustomIterator<E> implements Iterator<E> {
         private Node<E> curr;
 
         @Override

src/main/java/by/andd3dfx/common/CountStreamers.java

@@ -4,7 +4,6 @@
 import lombok.Data;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Comparator;
 
 import static by.andd3dfx.common.CountStreamers.EventType.START;
@@ -35,7 +34,7 @@ public static int count(int[][] times) {
             events.add(new EventItem(time[1], STOP));
         }
 
-        Collections.sort(events, Comparator.comparingInt(EventItem::getTime));
+        events.sort(Comparator.comparingInt(EventItem::getTime));
 
         var current = 0;
         var max = 0;

src/main/java/by/andd3dfx/common/JoinIntervals.java

@@ -2,7 +2,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 
 /**
  * <pre>
@@ -52,7 +51,6 @@ public static String transform(int[] a) {
             items.add(String.valueOf(lastItem));
         }
 
-        return items.stream()
-                .collect(Collectors.joining(","));
+        return String.join(",", items);
     }
 }

src/main/java/by/andd3dfx/common/PropertiesExtractor.java

@@ -3,7 +3,6 @@
 import java.lang.reflect.Field;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 
 /**
  * Write a function that accept one argument of object type and print all values of own properties (that are not
@@ -32,7 +31,7 @@ public static String extract(Object obj) throws IllegalAccessException {
                 result.add(extract(value));
             }
         }
-        return result.stream().collect(Collectors.joining(" "));
+        return String.join(" ", result);
     }
 
     private static Object extractValue(Field field, Object obj) throws IllegalAccessException {

src/main/java/by/andd3dfx/common/SortedSquares.java

@@ -7,7 +7,6 @@
 import java.util.Deque;
 import java.util.List;
 import java.util.PriorityQueue;
-import java.util.stream.Collectors;
 
 /**
  * <pre>
@@ -28,7 +27,7 @@ public static Integer[] transformUsingSorting(Integer[] items) {
         return Arrays.stream(items)
                 .map(integer -> integer * integer)
                 .sorted()
-                .collect(Collectors.toList())
+                .toList()
                 .toArray(new Integer[0]);
     }
 

src/main/java/by/andd3dfx/common/TrainComposition.java

@@ -16,7 +16,7 @@
  */
 public class TrainComposition {
 
-    private Deque<Integer> deque = new ArrayDeque<>();
+    private final Deque<Integer> deque = new ArrayDeque<>();
 
     public void attachWagonFromLeft(int wagonId) {
         deque.addFirst(wagonId);

src/main/java/by/andd3dfx/common/UrlShortener.java

@@ -5,7 +5,7 @@
 
 /**
  * <pre>
- * According to https://stackoverflow.com/questions/742013/how-do-i-create-a-url-shortener/742047
+ * According to <a href="https://stackoverflow.com/questions/742013/how-do-i-create-a-url-shortener/742047">article</a>
  *
  * - Реализовать сократитель ссылок
  * 1. берем строку из символов англ. алфавита и цифр: abc..zABC..Z01..9 (62 символа)
@@ -66,15 +66,15 @@ public String restoreLongUrl(String shortString) {
     String encodePrimaryKeyToShortString(Long dbPrimaryKey) {
         StringBuilder sb = new StringBuilder();
         while (dbPrimaryKey > 0) {
-            Long remainder = dbPrimaryKey % BASE;
-            sb.append(ALPHABET.charAt(remainder.intValue()));
+            long remainder = dbPrimaryKey % BASE;
+            sb.append(ALPHABET.charAt((int) remainder));
             dbPrimaryKey = dbPrimaryKey / BASE;
         }
         return sb.reverse().toString();
     }
 
     Long decodeShortStringToPrimaryKey(String shortString) {
-        Long result = 0L;
+        long result = 0L;
         for (char character : shortString.toCharArray()) {
             int charIndex = ALPHABET.indexOf(character);
             result = result * BASE + charIndex;

src/main/java/by/andd3dfx/core/GenericClassCreation.java

@@ -8,7 +8,7 @@
  * <pre>
  * Examples of object creation when it defined as generic type.
  *
- * According to: https://stackoverflow.com/questions/75175/create-instance-of-generic-type-in-java
+ * According to <a href="https://stackoverflow.com/questions/75175/create-instance-of-generic-type-in-java">article</a>
  * </pre>
  *
  * @see <a href="https://youtu.be/vkn_2w-oJIo">Video solution</a>

src/main/java/by/andd3dfx/core/creationorder/ClassA.java

@@ -1,12 +1,15 @@
 package by.andd3dfx.core.creationorder;
 
+import lombok.Getter;
+
 import java.util.ArrayList;
 import java.util.List;
 
 public class ClassA {
 
+    @Getter
     protected static List<String> logs = new ArrayList<>();
-    private int value = 100;
+    private final int value = 100;
 
     {
         logs.add("A1 Usual block of class A, " + value);
@@ -24,8 +27,4 @@ public ClassA() {
     public void showValue() {
         logs.add("A4 Call of class A method, " + value);
     }
-
-    public static List<String> getLogs() {
-        return logs;
-    }
 }