Allow XBeeAddress64 to work with uint64_t variables

This adds:
 - A constructor that takes a single uint64_t variable. This allows
   implicitly converting integers to XBeeAddress64 values, so these will
   work:

        XBeeAddress64 dest = 0x0;
        request.setAddress64(0x0013A21234567890);

   (note that the latter also requires some const-correctness fixes in
   methods taking XBeeAddress64 arguments).
 - A get() and set() method for getting and setting the address as a
   uint64_t.
 - A operator uint64_t() which allows the XBeeAddress64 to be
   implicitely converted to a uint64_t. E.g.:

        uint64_t address = resp.getRemoteAddress64();

   But also comparison:

        resp.getRemoteAddress64() == XBeeAddress64(0, 0)
        resp.getRemoteAddress64() == 0x0013A21234567890);

   Note that both comparisons above work by converting to uint64_t and
   comparing those.

   Because this removes the need for separate comparison operators, the
   ones that were there (but still commented out) were removed.

Note that avr-gcc doesn't currently optimize uint64_t values very well,
so the storage is still left as two separate uint32_t values. If you use
the msb/lsb accessors, code should be unchanged compared to before, but
if you use the uint64_t accessors or compare addresses, code will be
less efficient. This will hopefully be fixed in a future compiler
version, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66511.

Author: matthijskooijman

XBee.cpp

@@ -1028,6 +1028,10 @@ XBeeAddress64::XBeeAddress64(uint32_t msb, uint32_t lsb) : XBeeAddress() {
 	_lsb = lsb;
 }
 
+XBeeAddress64::XBeeAddress64(uint64_t addr) : XBeeAddress() {
+	set(addr);
+}
+
 uint32_t XBeeAddress64::getMsb() {
 	return _msb;
 }
@@ -1044,14 +1048,18 @@ void XBeeAddress64::setLsb(uint32_t lsb) {
 	_lsb = lsb;
 }
 
-// contributed by user repat123 on issue tracker
-//bool XBeeAddress64::operator==(XBeeAddress64 addr) {
-//    return ((_lsb == addr.getLsb()) && (_msb == addr.getMsb()));
-//}
+uint64_t XBeeAddress64::get() {
+	return (static_cast<uint64_t>(_msb) << 32) | _lsb;
+}
 
-//bool XBeeAddress64::operator!=(XBeeAddress64 addr) {
-//            return !(*this == addr);
-//}
+void XBeeAddress64::set(uint64_t addr) {
+	_msb = addr >> 32;
+	_lsb = addr;
+}
+
+XBeeAddress64::operator uint64_t() {
+	return get();
+}
 
 #ifdef SERIES_2
 

XBee.h

@@ -292,18 +292,26 @@ class XBeeAddress {
 
 /**
  * Represents a 64-bit XBee Address
+ *
+ * Note that avr-gcc as of 4.9 doesn't optimize uint64_t very well, so
+ * for the smallest and fastest code, use msb and lsb separately. See
+ * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66511
  */
 class XBeeAddress64 : public XBeeAddress {
 public:
+	XBeeAddress64(uint64_t addr);
 	XBeeAddress64(uint32_t msb, uint32_t lsb);
 	XBeeAddress64();
 	uint32_t getMsb();
 	uint32_t getLsb();
+	uint64_t get();
+	operator uint64_t();
 	void setMsb(uint32_t msb);
 	void setLsb(uint32_t lsb);
-	//bool operator==(XBeeAddress64 addr);
-	//bool operator!=(XBeeAddress64 addr);
+	void set(uint64_t addr);
 private:
+	// Once https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66511 is
+	// fixed, it might make sense to merge these into a uint64_t.
 	uint32_t _msb;
 	uint32_t _lsb;
 };