Improve CRAP index calculation

andrey-tech · andrey-tech · commit 03a054a568dd · 2025-09-18T07:18:30.000+03:00
diff --git a/composer.json b/composer.json
@@ -64,6 +64,12 @@
         "cs": "phpcs -s -p --report=full --standard=phpcs.xml.dist",
         "psalm": "psalm --long-progress --output-format=compact --config=psalm.xml.dist",
         "phpmd": "phpmd src ansi phpmd.xml.dist --suffixes php",
-        "pdepend": "pdepend --summary-xml=summary.xml --suffix=php --quiet src"
+        "pdepend": "pdepend --summary-xml=.summary.xml --suffix=php --quiet src",
+        "check": [
+            "@lint",
+            "@cs",
+            "@psalm",
+            "@phpmd"
+        ]
    }
 }
diff --git a/src/AndreyTech/Pdepend/Summary/Extractor/Parser.php b/src/AndreyTech/Pdepend/Summary/Extractor/Parser.php
@@ -20,6 +20,8 @@
 use Exception;
 use SimpleXMLElement;
 
+use function round;
+
 final class Parser
 {
     /**
@@ -216,7 +218,7 @@ private function calculateCRAP(int $complexity, int $coverage = 0): int
     {
         $crap = ($complexity ** 2) * ((1 - $coverage / 100) ** 3) + $complexity;
 
-        return (int) $crap;
+        return (int) round($crap);
     }
 
     private function getStringAttr(SimpleXMLElement $element, string $attribute): string

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,12 @@`
`64`	`64`	`"cs": "phpcs -s -p --report=full --standard=phpcs.xml.dist",`
`65`	`65`	`"psalm": "psalm --long-progress --output-format=compact --config=psalm.xml.dist",`
`66`	`66`	`"phpmd": "phpmd src ansi phpmd.xml.dist --suffixes php",`
`67`		`- "pdepend": "pdepend --summary-xml=summary.xml --suffix=php --quiet src"`
	`67`	`+ "pdepend": "pdepend --summary-xml=.summary.xml --suffix=php --quiet src",`
	`68`	`+ "check": [`
	`69`	`+ "@lint",`
	`70`	`+ "@cs",`
	`71`	`+ "@psalm",`
	`72`	`+ "@phpmd"`
	`73`	`+ ]`
`68`	`74`	`}`
`69`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@`
`20`	`20`	`use Exception;`
`21`	`21`	`use SimpleXMLElement;`
`22`	`22`
	`23`	`+use function round;`
	`24`	`+`
`23`	`25`	`final class Parser`
`24`	`26`	`{`
`25`	`27`	`/**`
`@@ -216,7 +218,7 @@ private function calculateCRAP(int $complexity, int $coverage = 0): int`
`216`	`218`	`{`
`217`	`219`	`$crap = ($complexity ** 2) * ((1 - $coverage / 100) ** 3) + $complexity;`
`218`	`220`
`219`		`- return (int) $crap;`
	`221`	`+ return (int) round($crap);`
`220`	`222`	`}`
`221`	`223`
`222`	`224`	`private function getStringAttr(SimpleXMLElement $element, string $attribute): string`