refactor(@angular/cli): remove ora spinner dependency from package

The ora package has been removed now that the progress indicator for the
update command is now based on the `listr2` package that is also used
by the `ng add` command.

Author: clydin

packages/angular/cli/BUILD.bazel

@@ -69,7 +69,6 @@ ts_library(
         "@npm//jsonc-parser",
         "@npm//listr2",
         "@npm//npm-package-arg",
-        "@npm//ora",
         "@npm//pacote",
         "@npm//semver",
         "@npm//yargs",

packages/angular/cli/package.json

@@ -34,7 +34,6 @@
     "listr2": "8.2.1",
     "npm-package-arg": "11.0.2",
     "npm-pick-manifest": "9.0.1",
-    "ora": "5.4.1",
     "pacote": "18.0.6",
     "resolve": "1.22.8",
     "semver": "7.6.2",

packages/angular/cli/src/commands/add/cli.ts

@@ -324,7 +324,6 @@ export default class AddCommandModule
             const { success, tempNodeModules } = await packageManager.installTemp(
               context.packageIdentifier.toString(),
               registry ? [`--registry="${registry}"`] : undefined,
-              false,
             );
             const tempRequire = createRequire(tempNodeModules + '/');
             assert(context.collectionName, 'Collection name should always be available');
@@ -343,7 +342,6 @@ export default class AddCommandModule
               context.savePackage,
               registry ? [`--registry="${registry}"`] : undefined,
               undefined,
-              false,
             );
 
             if (!success) {

packages/angular/cli/src/utilities/package-manager.ts

@@ -14,7 +14,6 @@ import { join } from 'path';
 import { PackageManager } from '../../lib/config/workspace-schema';
 import { AngularWorkspace, getProjectByCwd } from './config';
 import { memoize } from './memoize';
-import { Spinner } from './spinner';
 
 interface PackageManagerOptions {
   saveDev: string;
@@ -49,7 +48,6 @@ export class PackageManagerUtils {
     save: 'dependencies' | 'devDependencies' | true = true,
     extraArgs: string[] = [],
     cwd?: string,
-    progress = true,
   ): Promise<boolean> {
     const packageManagerArgs = this.getArguments();
     const installArgs: string[] = [packageManagerArgs.install, packageName];
@@ -58,7 +56,7 @@ export class PackageManagerUtils {
       installArgs.push(packageManagerArgs.saveDev);
     }
 
-    return this.run([...installArgs, ...extraArgs], { cwd, silent: true, progress });
+    return this.run([...installArgs, ...extraArgs], { cwd, silent: true });
   }
 
   /** Install all packages. */
@@ -69,14 +67,13 @@ export class PackageManagerUtils {
       installArgs.push(packageManagerArgs.installAll);
     }
 
-    return this.run([...installArgs, ...extraArgs], { cwd, silent: true, progress: false });
+    return this.run([...installArgs, ...extraArgs], { cwd, silent: true });
   }
 
   /** Install a single package temporary. */
   async installTemp(
     packageName: string,
     extraArgs?: string[],
-    progress = true,
   ): Promise<{
     success: boolean;
     tempNodeModules: string;
@@ -121,7 +118,7 @@ export class PackageManagerUtils {
     ];
 
     return {
-      success: await this.install(packageName, true, installArgs, tempPath, progress),
+      success: await this.install(packageName, true, installArgs, tempPath),
       tempNodeModules,
     };
   }
@@ -164,12 +161,9 @@ export class PackageManagerUtils {
 
   private async run(
     args: string[],
-    options: { cwd?: string; silent?: boolean; progress?: boolean } = {},
+    options: { cwd?: string; silent?: boolean } = {},
   ): Promise<boolean> {
-    const { cwd = process.cwd(), silent = false, progress = true } = options;
-
-    const spinner = progress ? new Spinner() : undefined;
-    spinner?.start('Installing packages...');
+    const { cwd = process.cwd(), silent = false } = options;
 
     return new Promise((resolve) => {
       const bufferedOutput: { stream: NodeJS.WriteStream; data: Buffer }[] = [];
@@ -181,12 +175,9 @@ export class PackageManagerUtils {
         cwd,
       }).on('close', (code: number) => {
         if (code === 0) {
-          spinner?.succeed('Packages successfully installed.');
           resolve(true);
         } else {
-          spinner?.stop();
           bufferedOutput.forEach(({ stream, data }) => stream.write(data));
-          spinner?.fail('Packages installation failed, see above.');
           resolve(false);
         }
       });

packages/angular/cli/src/utilities/spinner.ts

@@ -521,7 +521,6 @@ __metadata:
     listr2: "npm:8.2.1"
     npm-package-arg: "npm:11.0.2"
     npm-pick-manifest: "npm:9.0.1"
-    ora: "npm:5.4.1"
     pacote: "npm:18.0.6"
     resolve: "npm:1.22.8"
     semver: "npm:7.6.2"