ci: migrate lint validation to GHA

Migrate validation job from CircleCI to Github Actions as part of a larger lint job.

Author: josephperrott

.circleci/dynamic_config.yml

@@ -189,30 +189,6 @@ jobs:
           paths:
             - ~/.cache/yarn
 
-  validate:
-    executor: action-executor
-    steps:
-      - custom_attach_workspace
-      - run:
-          name: Validate Commit Messages
-          command: >
-            if [[ -n "${CIRCLE_PR_NUMBER}" ]]; then
-              yarn ng-dev commit-message validate-range <<pipeline.git.base_revision>> <<pipeline.git.revision>>
-            else
-              echo "This build is not over a PR, nothing to do."
-            fi
-      - run:
-          name: Validate Code Formatting
-          command: yarn -s ng-dev format changed <<pipeline.git.base_revision>> --check
-      - run:
-          name: Validate NgBot Configuration
-          command: yarn ng-dev ngbot verify
-      - run:
-          name: Validate Circular Dependencies
-          command: yarn ts-circular-deps:check
-      - run: yarn -s admin validate
-      - run: yarn -s check-tooling-setup
-
   build:
     executor: bazel-executor
     steps:
@@ -388,9 +364,6 @@ workflows:
     jobs:
       # Linux jobs
       - setup
-      - validate:
-          requires:
-            - setup
 
       # These jobs only really depend on Setup, but the build job is very quick to run (~35s) and
       # will catch any build errors before proceeding to the more lengthy and resource intensive

.github/workflows/ci.yml

@@ -0,0 +1,53 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - main
+      - '[0-9]+.[0-9]+.x'
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+permissions: {}
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Initialize environment
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@ef022a04090aca0945862f9f69f8ff3ea5865f26
+      - name: Setup ESLint Caching
+        uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1
+        with:
+          path: .eslintcache
+          key: ${{ runner.os }}-${{ hashFiles('.eslintrc.json') }}
+      - name: Install node modules
+        run: yarn install --frozen-lockfile --ignore-scripts
+      - name: Run ESLint
+        run: yarn lint --cache-strategy content
+      - name: Validate NgBot Configuration
+        run: yarn ng-dev ngbot verify
+      - name: Validate Circular Dependencies
+        run: yarn ts-circular-deps:check
+      - name: Run Validation
+        run: yarn -s admin validate
+      - name: Check tooling setup
+        run: yarn -s check-tooling-setup
+      - name: Check commit message
+        # Commit message validation is only done on pull requests as its too late to validate once
+        # it has been merged.
+        if: github.event_name == 'pull_request'
+        run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
+      - name: Check code format
+        # Code formatting checks are only done on pull requests as its too late to validate once
+        # it has been merged.
+        if: github.event_name == 'pull_request'
+        run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}