refactor(@angular-devkit/build-angular): remove circular dependency in dev-server builder

This commit moves the `isEsbuildBased` function from `builder.ts` to `options.ts` to resolve a circular dependency.

Author: clydin

goldens/circular-deps/packages.json

@@ -1,8 +1,4 @@
 [
-  [
-    "packages/angular_devkit/build_angular/src/builders/dev-server/builder.ts",
-    "packages/angular_devkit/build_angular/src/builders/dev-server/options.ts"
-  ],
   [
     "packages/angular/build/src/tools/esbuild/angular/component-stylesheets.ts",
     "packages/angular/build/src/tools/esbuild/bundler-context.ts",

packages/angular_devkit/build_angular/src/builders/dev-server/builder.ts

@@ -13,7 +13,7 @@ import type { Plugin } from 'esbuild';
 import type http from 'node:http';
 import { EMPTY, Observable, defer, switchMap } from 'rxjs';
 import type { ExecutionTransformer } from '../../transforms';
-import { normalizeOptions } from './options';
+import { isEsbuildBased, normalizeOptions } from './options';
 import type { Schema as DevServerBuilderOptions } from './schema';
 
 /**
@@ -194,23 +194,6 @@ case.
   };
 }
 
-export function isEsbuildBased(
-  builderName: string,
-): builderName is
-  | '@angular/build:application'
-  | '@angular-devkit/build-angular:application'
-  | '@angular-devkit/build-angular:browser-esbuild' {
-  if (
-    builderName === '@angular/build:application' ||
-    builderName === '@angular-devkit/build-angular:application' ||
-    builderName === '@angular-devkit/build-angular:browser-esbuild'
-  ) {
-    return true;
-  }
-
-  return false;
-}
-
 interface BuilderSelectorInfo {
   builderName: string;
   forceEsbuild: boolean;

packages/angular_devkit/build_angular/src/builders/dev-server/options.ts

@@ -10,11 +10,27 @@ import { BuilderContext, targetFromTargetString } from '@angular-devkit/architec
 import path from 'node:path';
 import { normalizeCacheOptions } from '../../utils/normalize-cache';
 import { normalizeOptimization } from '../../utils/normalize-optimization';
-import { isEsbuildBased } from './builder';
 import { Schema as DevServerOptions } from './schema';
 
 export type NormalizedDevServerOptions = Awaited<ReturnType<typeof normalizeOptions>>;
 
+export function isEsbuildBased(
+  builderName: string,
+): builderName is
+  | '@angular/build:application'
+  | '@angular-devkit/build-angular:application'
+  | '@angular-devkit/build-angular:browser-esbuild' {
+  if (
+    builderName === '@angular/build:application' ||
+    builderName === '@angular-devkit/build-angular:application' ||
+    builderName === '@angular-devkit/build-angular:browser-esbuild'
+  ) {
+    return true;
+  }
+
+  return false;
+}
+
 /**
  * Normalize the user provided options by creating full paths for all path based options
  * and converting multi-form options into a single form that can be directly used