refactor: remove outdated namespace syntax usage

The `namespace` TypeScript usage within the CLI has been removed. This
syntax is not recommended outside of type definition files.

Author: clydin

goldens/public-api/angular_devkit/architect/index.md

@@ -358,6 +358,7 @@ class JobOutputSchemaValidationError extends schema.SchemaValidationException {
 
 declare namespace jobs {
     export {
+        strategy,
         isJobHandler,
         JobName,
         JobHandler,
@@ -403,8 +404,7 @@ declare namespace jobs {
         JobArgumentSchemaValidationError,
         JobInboundMessageSchemaValidationError,
         JobOutputSchemaValidationError,
-        SimpleScheduler,
-        strategy
+        SimpleScheduler
     }
 }
 export { jobs }
@@ -418,6 +418,12 @@ enum JobState {
     Started = "started"
 }
 
+// @public (undocumented)
+type JobStrategy<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue> = (handler: JobHandler<A, I, O>, options?: Partial<Readonly<JobDescription>>) => JobHandler<A, I, O>;
+
+// @public
+function memoize<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(replayMessages?: boolean): JobStrategy<A, I, O>;
+
 // @public
 interface RegisterJobOptions extends Partial<JobDescription> {
 }
@@ -427,6 +433,9 @@ interface Registry<MinimumArgumentValueT extends JsonValue = JsonValue, MinimumI
     get<A extends MinimumArgumentValueT, I extends MinimumInputValueT, O extends MinimumOutputValueT>(name: JobName): Observable<JobHandler<A, I, O> | null>;
 }
 
+// @public
+function reuse<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(replayMessages?: boolean): JobStrategy<A, I, O>;
+
 // @public
 interface ScheduleJobOptions {
     dependencies?: Job | Job[];
@@ -449,6 +458,9 @@ interface Scheduler<MinimumArgumentValueT extends JsonValue = JsonValue, Minimum
 // @public
 export function scheduleTargetAndForget(context: BuilderContext, target: Target, overrides?: json.JsonObject, scheduleOptions?: ScheduleOptions_2): Observable<BuilderOutput>;
 
+// @public
+function serialize<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(): JobStrategy<A, I, O>;
+
 // @public
 interface SimpleJobHandlerContext<A extends JsonValue, I extends JsonValue, O extends JsonValue> extends JobHandlerContext<A, I, O> {
     // (undocumented)
@@ -490,13 +502,13 @@ class SimpleScheduler<MinimumArgumentT extends JsonValue = JsonValue, MinimumInp
     protected _schemaRegistry: schema.SchemaRegistry;
 }
 
-// @public (undocumented)
-namespace strategy {
-    // (undocumented)
-    type JobStrategy<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue> = (handler: JobHandler<A, I, O>, options?: Partial<Readonly<JobDescription>>) => JobHandler<A, I, O>;
-    function memoize<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(replayMessages?: boolean): JobStrategy<A, I, O>;
-    function reuse<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(replayMessages?: boolean): JobStrategy<A, I, O>;
-    function serialize<A extends JsonValue = JsonValue, I extends JsonValue = JsonValue, O extends JsonValue = JsonValue>(): JobStrategy<A, I, O>;
+declare namespace strategy {
+    export {
+        serialize,
+        reuse,
+        memoize,
+        JobStrategy
+    }
 }
 
 // @public (undocumented)

goldens/public-api/angular_devkit/core/index.md

@@ -1223,71 +1223,76 @@ interface TemplateTag<R = string> {
     (template: TemplateStringsArray, ...substitutions: any[]): R;
 }
 
-// @public (undocumented)
-namespace test {
-    // (undocumented)
-    class TestHost extends SimpleMemoryHost {
-        // (undocumented)
-        $exists(path: string): boolean;
-        // (undocumented)
-        $isDirectory(path: string): boolean;
-        // (undocumented)
-        $isFile(path: string): boolean;
-        // (undocumented)
-        $list(path: string): PathFragment[];
-        // (undocumented)
-        $read(path: string): string;
-        // (undocumented)
-        $write(path: string, content: string): void;
-        constructor(map?: {
-            [path: string]: string;
-        });
-        // (undocumented)
-        clearRecords(): void;
-        // (undocumented)
-        clone(): TestHost;
-        // (undocumented)
-        protected _delete(path: Path): void;
-        // (undocumented)
-        protected _exists(path: Path): boolean;
-        // (undocumented)
-        get files(): Path[];
-        // (undocumented)
-        protected _isDirectory(path: Path): boolean;
-        // (undocumented)
-        protected _isFile(path: Path): boolean;
-        // (undocumented)
-        protected _list(path: Path): PathFragment[];
-        // (undocumented)
-        protected _read(path: Path): ArrayBuffer;
-        // (undocumented)
-        get records(): TestLogRecord[];
-        // (undocumented)
-        protected _records: TestLogRecord[];
-        // (undocumented)
-        protected _rename(from: Path, to: Path): void;
-        // (undocumented)
-        protected _stat(path: Path): Stats<SimpleMemoryHostStats> | null;
-        // (undocumented)
-        get sync(): SyncDelegateHost<{}>;
-        // (undocumented)
-        protected _sync: SyncDelegateHost<{}> | null;
-        // (undocumented)
-        protected _watch(path: Path, options?: HostWatchOptions): Observable<HostWatchEvent>;
-        // (undocumented)
-        protected _write(path: Path, content: FileBuffer): void;
+declare namespace test {
+    export {
+        TestLogRecord,
+        TestHost
     }
+}
+
+// @public (undocumented)
+class TestHost extends SimpleMemoryHost {
     // (undocumented)
-    type TestLogRecord = {
-        kind: 'write' | 'read' | 'delete' | 'list' | 'exists' | 'isDirectory' | 'isFile' | 'stat' | 'watch';
-        path: Path;
-    } | {
-        kind: 'rename';
-        from: Path;
-        to: Path;
-    };
+    $exists(path: string): boolean;
+    // (undocumented)
+    $isDirectory(path: string): boolean;
+    // (undocumented)
+    $isFile(path: string): boolean;
+    // (undocumented)
+    $list(path: string): PathFragment[];
+    // (undocumented)
+    $read(path: string): string;
+    // (undocumented)
+    $write(path: string, content: string): void;
+    constructor(map?: {
+        [path: string]: string;
+    });
+    // (undocumented)
+    clearRecords(): void;
+    // (undocumented)
+    clone(): TestHost;
+    // (undocumented)
+    protected _delete(path: Path): void;
+    // (undocumented)
+    protected _exists(path: Path): boolean;
+    // (undocumented)
+    get files(): Path[];
+    // (undocumented)
+    protected _isDirectory(path: Path): boolean;
+    // (undocumented)
+    protected _isFile(path: Path): boolean;
+    // (undocumented)
+    protected _list(path: Path): PathFragment[];
+    // (undocumented)
+    protected _read(path: Path): ArrayBuffer;
+    // (undocumented)
+    get records(): TestLogRecord[];
+    // (undocumented)
+    protected _records: TestLogRecord[];
+    // (undocumented)
+    protected _rename(from: Path, to: Path): void;
+    // (undocumented)
+    protected _stat(path: Path): Stats<SimpleMemoryHostStats> | null;
+    // (undocumented)
+    get sync(): SyncDelegateHost<{}>;
+    // (undocumented)
+    protected _sync: SyncDelegateHost<{}> | null;
+    // (undocumented)
+    protected _watch(path: Path, options?: HostWatchOptions): Observable<HostWatchEvent>;
+    // (undocumented)
+    protected _write(path: Path, content: FileBuffer): void;
 }
 
+// @public (undocumented)
+type TestLogRecord = {
+    kind: 'write' | 'read' | 'delete' | 'list' | 'exists' | 'isDirectory' | 'isFile' | 'stat' | 'watch';
+    path: Path;
+} | {
+    kind: 'rename';
+    from: Path;
+    to: Path;
+};
+
 // @public (undocumented)
 class TransformLogger extends Logger {
     constructor(name: string, transform: (stream: Observable<LogEntry>) => Observable<LogEntry>, parent?: Logger | null);
@@ -1315,6 +1320,7 @@ type UriHandler = (uri: string) => Observable<JsonObject> | Promise<JsonObject>
 
 declare namespace virtualFs {
     export {
+        test,
         AliasHost,
         stringToFileBuffer,
         fileBufferToString,
@@ -1345,8 +1351,7 @@ declare namespace virtualFs {
         ScopedHost,
         SynchronousDelegateExpectedException,
         SyncDelegateHost,
-        ResolverHost,
-        test
+        ResolverHost
     }
 }
 export { virtualFs }

packages/angular_devkit/architect/src/jobs/index.ts

@@ -6,11 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import * as strategy from './strategy';
+
 export * from './api';
 export * from './create-job-handler';
 export * from './exception';
 export * from './dispatcher';
 export * from './fallback-registry';
 export * from './simple-registry';
 export * from './simple-scheduler';
-export * from './strategy';
+export { strategy };