feat: support retrying timed out evaluations #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not flaw/skip results due to timeouts caused by e.g. stuck building or stuck serving.
AndrewKushnir
approved these changes
Nov 24, 2025
Comment on lines
+201
to
+204
| const maxAttempts = (options.promptTimeoutRetries ?? 0) + 1; | ||
| for (let attemptIdx = 0; attemptIdx < maxAttempts; attemptIdx++) { | ||
| try { | ||
| await env.executor.finalizeEval(evalID); | ||
| } catch (e) { | ||
| progress.log(rootPromptDef, 'error', 'Failed to finalize eval', `${e}`); | ||
| return await evaluate(); |
Collaborator
There was a problem hiding this comment.
nit (potentially for a followup PR): do we want to have a timeout in-between attempts (e.g. exponential backoff)?
Member
Author
There was a problem hiding this comment.
Potentially, we can expand when we see the need. The exponential backoff is currently used for LLM requests separately (where we try to overcome rate limits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not flaw/skip results due to timeouts caused by e.g. stuck building or stuck serving.