fix: do not silently fail puppeteer testing #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently catch errors for Puppeteer logic (screenshot, runtime error collection, CSP testing etc.). The error message logged is actually wrongly saying something about screenshots. In addition, we don't even report the error back to the worker "host". This means that the error is simply swallowed and there is empty serve testing result. We should surface the error properly by removing the `try/catch` and letting the try/catch in `worker.ts` catch the error --> so that it sets the `serveTestingResult#errorMessage`.
crisbeto
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently catch errors for Puppeteer logic (screenshot, runtime error collection, CSP testing etc.). The error message logged is actually wrongly saying something about screenshots.
In addition, we don't even report the error back to the worker "host". This means that the error is simply swallowed and there is empty serve testing result. We should surface the error properly by removing the
try/catchand letting the try/catch inworker.tscatch the error --> so that it sets theserveTestingResult#errorMessage.