Skip to content

Commit 0e282ee

Browse files
committed
more test
1 parent 83d9ecd commit 0e282ee

File tree

2 files changed

+52
-0
lines changed

2 files changed

+52
-0
lines changed

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/ArrowFlightJdbcAccessorFactoryTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
import org.apache.arrow.vector.LargeVarCharVector;
4747
import org.apache.arrow.vector.ValueVector;
4848
import org.apache.arrow.vector.VarCharVector;
49+
import org.apache.arrow.vector.ViewVarBinaryVector;
50+
import org.apache.arrow.vector.ViewVarCharVector;
4951
import org.apache.arrow.vector.complex.DenseUnionVector;
5052
import org.apache.arrow.vector.complex.MapVector;
5153
import org.apache.arrow.vector.complex.StructVector;
@@ -239,6 +241,18 @@ public void createAccessorForFixedSizeBinaryVector() {
239241
}
240242
}
241243

244+
@Test
245+
public void createAccessorForViewVarBinaryVector() {
246+
try (ValueVector valueVector =
247+
new ViewVarBinaryVector("", rootAllocatorTestExtension.getRootAllocator())) {
248+
ArrowFlightJdbcAccessor accessor =
249+
ArrowFlightJdbcAccessorFactory.createAccessor(
250+
valueVector, GET_CURRENT_ROW, (boolean wasNull) -> {});
251+
252+
assertTrue(accessor instanceof ArrowFlightJdbcBinaryVectorAccessor);
253+
}
254+
}
255+
242256
@Test
243257
public void createAccessorForTimeStampVector() {
244258
try (ValueVector valueVector = rootAllocatorTestExtension.createTimeStampMilliVector()) {
@@ -340,6 +354,18 @@ public void createAccessorForLargeVarCharVector() {
340354
}
341355
}
342356

357+
@Test
358+
public void createAccessorForViewVarCharVector() {
359+
try (ValueVector valueVector =
360+
new ViewVarCharVector("", rootAllocatorTestExtension.getRootAllocator())) {
361+
ArrowFlightJdbcAccessor accessor =
362+
ArrowFlightJdbcAccessorFactory.createAccessor(
363+
valueVector, GET_CURRENT_ROW, (boolean wasNull) -> {});
364+
365+
assertTrue(accessor instanceof ArrowFlightJdbcVarCharVectorAccessor);
366+
}
367+
}
368+
343369
@Test
344370
public void createAccessorForDurationVector() {
345371
try (ValueVector valueVector =

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/text/ArrowFlightJdbcVarCharVectorAccessorTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import static org.hamcrest.CoreMatchers.instanceOf;
2525
import static org.hamcrest.MatcherAssert.assertThat;
2626
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
27+
import static org.junit.jupiter.api.Assertions.assertEquals;
28+
import static org.junit.jupiter.api.Assertions.assertNull;
2729
import static org.junit.jupiter.api.Assertions.assertThrows;
2830
import static org.mockito.Mockito.when;
2931

@@ -46,6 +48,8 @@
4648
import org.apache.arrow.vector.DateMilliVector;
4749
import org.apache.arrow.vector.TimeMilliVector;
4850
import org.apache.arrow.vector.TimeStampVector;
51+
import org.apache.arrow.vector.VarCharVector;
52+
import org.apache.arrow.vector.ViewVarCharVector;
4953
import org.apache.arrow.vector.util.Text;
5054
import org.junit.jupiter.api.BeforeEach;
5155
import org.junit.jupiter.api.Test;
@@ -695,4 +699,26 @@ public void testShouldGetObjectClassReturnString() {
695699
final Class<?> clazz = accessor.getObjectClass();
696700
assertThat(clazz, equalTo(String.class));
697701
}
702+
703+
@Test
704+
public void testViewVarcharVector() throws Exception {
705+
try (VarCharVector varCharVector =
706+
new VarCharVector("", rootAllocatorTestExtension.getRootAllocator());
707+
ViewVarCharVector viewVarCharVector =
708+
new ViewVarCharVector("", rootAllocatorTestExtension.getRootAllocator())) {
709+
varCharVector.allocateNew(1);
710+
viewVarCharVector.allocateNew(1);
711+
712+
ArrowFlightJdbcVarCharVectorAccessor varCharVectorAccessor =
713+
new ArrowFlightJdbcVarCharVectorAccessor(varCharVector, () -> 0, (boolean wasNull) -> {});
714+
ArrowFlightJdbcVarCharVectorAccessor viewVarcharVectorAccessor =
715+
new ArrowFlightJdbcVarCharVectorAccessor(
716+
viewVarCharVector, () -> 0, (boolean wasNull) -> {});
717+
assertNull(viewVarcharVectorAccessor.getString());
718+
719+
varCharVector.set(0, new Text("looooong_string"));
720+
viewVarCharVector.set(0, new Text("looooong_string"));
721+
assertEquals(varCharVectorAccessor.getString(), viewVarcharVectorAccessor.getString());
722+
}
723+
}
698724
}

0 commit comments

Comments
 (0)