GH-87: fixed comments

Author: xxlaykxx

vector/src/main/codegen/templates/AbstractFieldWriter.java

@@ -110,10 +110,10 @@ public void endEntry() {
   public void write(ExtensionHolder var1)  {
     this.fail("ExtensionType");
   }
-  public void writeExtensionType(Object var1)  {
+  public void writeExtension(Object var1)  {
     this.fail("ExtensionType");
   }
-  public void addExtensionTypeFactory(ExtensionTypeWriterFactory var1) {
+  public void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory var1) {
     this.fail("ExtensionType");
   }
 

vector/src/main/codegen/templates/BaseWriter.java

@@ -111,7 +111,7 @@ public interface ExtensionWriter extends BaseWriter {
     void writeNull();
 
     /**
-     * Writes vlaue from the given extension holder.
+     * Writes value from the given extension holder.
      *
      * @param holder the extension holder to write
      */
@@ -122,14 +122,14 @@ public interface ExtensionWriter extends BaseWriter {
      *
      * @param value the extension type value to write
      */
-    void writeExtensionType(Object value);
+    void writeExtension(Object value);
 
     /**
      * Adds the given extension type factory. This factory allows configuring writer implementations for specific ExtensionTypeVector.
      *
      * @param factory the extension type factory to add
      */
-    void addExtensionTypeFactory(ExtensionTypeWriterFactory factory);
+    void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory factory);
   }
 
   public interface ScalarWriter extends

vector/src/main/codegen/templates/PromotableWriter.java

@@ -541,13 +541,13 @@ public void writeLargeVarChar(String value) {
   }
 
   @Override
-  public void writeExtensionType(Object value) {
-    getWriter(MinorType.EXTENSIONTYPE).writeExtensionType(value);
+  public void writeExtension(Object value) {
+    getWriter(MinorType.EXTENSIONTYPE).writeExtension(value);
   }
 
   @Override
-  public void addExtensionTypeFactory(ExtensionTypeWriterFactory factory) {
-    getWriter(MinorType.EXTENSIONTYPE).addExtensionTypeFactory(factory);
+  public void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory factory) {
+    getWriter(MinorType.EXTENSIONTYPE).addExtensionTypeWriterFactory(factory);
   }
 
   @Override

vector/src/main/codegen/templates/UnionListWriter.java

@@ -335,12 +335,12 @@ public void writeNull() {
   }
 
   @Override
-  public void writeExtensionType(Object value) {
-    writer.writeExtensionType(value);
+  public void writeExtension(Object value) {
+    writer.writeExtension(value);
   }
   @Override
-  public void addExtensionTypeFactory(ExtensionTypeWriterFactory var1) {
-    writer.addExtensionTypeFactory(var1);
+  public void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory var1) {
+    writer.addExtensionTypeWriterFactory(var1);
   }
   public void write(ExtensionHolder var1) {
     writer.write(var1);

vector/src/main/java/org/apache/arrow/vector/complex/impl/UnionExtensionWriter.java

@@ -55,12 +55,12 @@ public void close() throws Exception {
   }
 
   @Override
-  public void writeExtensionType(Object var1) {
-    this.writer.writeExtensionType(var1);
+  public void writeExtension(Object var1) {
+    this.writer.writeExtension(var1);
   }
 
   @Override
-  public void addExtensionTypeFactory(ExtensionTypeWriterFactory factory) {
+  public void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory factory) {
     this.writer = factory.getWriterImpl(vector);
     this.writer.setPosition(idx());
   }

vector/src/test/java/org/apache/arrow/vector/UuidVector.java

@@ -34,7 +34,7 @@ public UuidVector(
     super(name, allocator, underlyingVector);
     this.field = new Field(name, FieldType.nullable(new UuidType()), null);
   }
-  
+
   public UuidVector(String name, BufferAllocator allocator) {
     super(name, allocator, new FixedSizeBinaryVector(name, allocator, 16));
     this.field = new Field(name, FieldType.nullable(new UuidType()), null);

vector/src/test/java/org/apache/arrow/vector/complex/impl/TestPromotableWriter.java

@@ -791,12 +791,12 @@ public void testExtensionType() throws Exception {
       UUID u2 = UUID.randomUUID();
       container.allocateNew();
       container.setValueCount(1);
-      writer.addExtensionTypeFactory(new UuidWriterFactory());
+      writer.addExtensionTypeWriterFactory(new UuidWriterFactory());
 
       writer.setPosition(0);
-      writer.writeExtensionType(u1);
+      writer.writeExtension(u1);
       writer.setPosition(1);
-      writer.writeExtensionType(u2);
+      writer.writeExtension(u2);
 
       container.setValueCount(2);
 

vector/src/test/java/org/apache/arrow/vector/complex/impl/UuidWriterImpl.java

@@ -22,28 +22,26 @@
 import org.apache.arrow.vector.holder.UuidHolder;
 import org.apache.arrow.vector.holders.ExtensionHolder;
 
-public class UuidWriterImpl extends AbstractExtensionTypeWriter {
+public class UuidWriterImpl extends AbstractExtensionTypeWriter<UuidVector> {
 
   public UuidWriterImpl(UuidVector vector) {
     super(vector);
   }
 
   @Override
-  public void writeExtensionType(Object value) {
+  public void writeExtension(Object value) {
     UUID uuid = (UUID) value;
     ByteBuffer bb = ByteBuffer.allocate(16);
     bb.putLong(uuid.getMostSignificantBits());
     bb.putLong(uuid.getLeastSignificantBits());
-    ((UuidVector) this.vector).setSafe(this.idx(), bb.array());
-    this.vector.setValueCount(this.idx() + 1);
+    vector.setSafe(idx(), bb.array());
+    vector.setValueCount(this.idx() + 1);
   }
 
   @Override
   public void write(ExtensionHolder holder) {
-    if (holder instanceof UuidHolder) {
-      UuidHolder uuidHolder = (UuidHolder) holder;
-      ((UuidVector) this.vector).setSafe(this.idx(), uuidHolder.value);
-      this.vector.setValueCount(this.idx() + 1);
-    }
+    UuidHolder uuidHolder = (UuidHolder) holder;
+    vector.setSafe(this.idx(), uuidHolder.value);
+    vector.setValueCount(this.idx() + 1);
   }
 }