move constants

Author: ViggoC

performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarkConstants.java

@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.arrow.vector;
+
+public class VariableWidthVectorBenchmarkConstants {
+  public static final String SHORT_VALUE = "InlineValue";
+  public static final String LONG_VALUE = VariableWidthVectorBenchmarks.class.getName();
+}

performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java

@@ -47,7 +47,7 @@ public class VariableWidthVectorBenchmarks {
 
   private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
 
-  private static byte[] bytes = VariableWidthVectorBenchmarks.class.getName().getBytes();
+  private static byte[] bytes = VariableWidthVectorBenchmarkConstants.LONG_VALUE.getBytes();
   private ArrowBuf arrowBuff;
 
   private BufferAllocator allocator;

performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorInlineValueBenchmarks.java

@@ -16,6 +16,7 @@
  */
 package org.apache.arrow.vector;
 
+import java.util.concurrent.TimeUnit;
 import org.apache.arrow.memory.ArrowBuf;
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.memory.RootAllocator;
@@ -35,8 +36,6 @@
 import org.openjdk.jmh.runner.options.Options;
 import org.openjdk.jmh.runner.options.OptionsBuilder;
 
-import java.util.concurrent.TimeUnit;
-
 /** Benchmarks for {@link BaseVariableWidthVector}. */
 @State(Scope.Benchmark)
 public class VariableWidthVectorInlineValueBenchmarks {
@@ -48,7 +47,7 @@ public class VariableWidthVectorInlineValueBenchmarks {
 
   private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
 
-  private static final byte[] bytes = "InlineValue".getBytes();
+  private static final byte[] bytes = VariableWidthVectorBenchmarkConstants.SHORT_VALUE.getBytes();
   private ArrowBuf arrowBuff;
 
   private BufferAllocator allocator;
@@ -121,7 +120,9 @@ public int setSafeFromNullableVarcharHolder() {
   public static void main(String[] args) throws RunnerException {
     Options opt =
         new OptionsBuilder()
-            .include(VariableWidthVectorInlineValueBenchmarks.class.getSimpleName() + ".setSafeFromArray")
+            .include(
+                VariableWidthVectorInlineValueBenchmarks.class.getSimpleName()
+                    + ".setSafeFromArray")
             .forks(1)
             .build();
 

performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorBenchmarks.java

@@ -47,7 +47,7 @@ public class VariableWidthViewVectorBenchmarks {
 
   private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
 
-  private static byte[] bytes = VariableWidthVectorBenchmarks.class.getName().getBytes();
+  private static byte[] bytes = VariableWidthVectorBenchmarkConstants.LONG_VALUE.getBytes();
   private ArrowBuf arrowBuff;
 
   private BufferAllocator allocator;

performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorInlineValueBenchmarks.java

@@ -16,6 +16,7 @@
  */
 package org.apache.arrow.vector;
 
+import java.util.concurrent.TimeUnit;
 import org.apache.arrow.memory.ArrowBuf;
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.memory.RootAllocator;
@@ -35,8 +36,6 @@
 import org.openjdk.jmh.runner.options.Options;
 import org.openjdk.jmh.runner.options.OptionsBuilder;
 
-import java.util.concurrent.TimeUnit;
-
 /** Benchmarks for {@link BaseVariableWidthVector}. */
 @State(Scope.Benchmark)
 public class VariableWidthViewVectorInlineValueBenchmarks {
@@ -48,7 +47,7 @@ public class VariableWidthViewVectorInlineValueBenchmarks {
 
   private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
 
-  private static byte[] bytes = "InlineValue".getBytes();
+  private static byte[] bytes = VariableWidthVectorBenchmarkConstants.SHORT_VALUE.getBytes();
   private ArrowBuf arrowBuff;
 
   private BufferAllocator allocator;
@@ -121,7 +120,9 @@ public int setSafeFromNullableVarcharHolder() {
   public static void main(String[] args) throws RunnerException {
     Options opt =
         new OptionsBuilder()
-            .include(VariableWidthViewVectorInlineValueBenchmarks.class.getSimpleName() + ".setSafeFromArray")
+            .include(
+                VariableWidthViewVectorInlineValueBenchmarks.class.getSimpleName()
+                    + ".setSafeFromArray")
             .forks(1)
             .build();