Skip to content

Commit 82c55ae

Browse files
committed
remove useragent customization from NettyClientBuilder
1 parent 1642733 commit 82c55ae

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/NettyClientBuilder.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public class NettyClientBuilder {
6060
protected String overrideHostname = null;
6161
protected List<FlightClientMiddleware.Factory> middleware = new ArrayList<>();
6262
protected boolean verifyServer = true;
63-
protected String userAgent;
6463

6564
public NettyClientBuilder() {}
6665

@@ -131,11 +130,6 @@ public NettyClientBuilder verifyServer(boolean verifyServer) {
131130
return this;
132131
}
133132

134-
public NettyClientBuilder userAgent(String userAgent) {
135-
this.userAgent = userAgent;
136-
return this;
137-
}
138-
139133
/** Create the client from this builder. */
140134
public NettyChannelBuilder build() {
141135
final NettyChannelBuilder builder;
@@ -232,8 +226,7 @@ public NettyChannelBuilder build() {
232226
builder
233227
.maxTraceEvents(MAX_CHANNEL_TRACE_EVENTS)
234228
.maxInboundMessageSize(maxInboundMessageSize)
235-
.maxInboundMetadataSize(maxInboundMessageSize)
236-
.userAgent(userAgent);
229+
.maxInboundMetadataSize(maxInboundMessageSize);
237230
return builder;
238231
}
239232
}

flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/client/ArrowFlightSqlClientHandler.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,7 +937,6 @@ public ArrowFlightSqlClientHandler build() throws SQLException {
937937
if (driverVersion != null && driverVersion.versionString != null) {
938938
userAgent = String.format(USER_AGENT_TEMPLATE, driverVersion.versionString);
939939
}
940-
clientBuilder.userAgent(userAgent);
941940

942941
buildTimeMiddlewareFactories.add(new ClientCookieMiddleware.Factory());
943942
buildTimeMiddlewareFactories.forEach(clientBuilder::intercept);
@@ -973,6 +972,9 @@ public ArrowFlightSqlClientHandler build() throws SQLException {
973972
}
974973

975974
NettyChannelBuilder channelBuilder = clientBuilder.build();
975+
976+
channelBuilder.userAgent(userAgent);
977+
976978
if (connectTimeout != null) {
977979
channelBuilder.withOption(
978980
ChannelOption.CONNECT_TIMEOUT_MILLIS, (int) connectTimeout.toMillis());

0 commit comments

Comments
 (0)