Skip to content

Commit a523df7

Browse files
authored
GH-522: [Release] Add support for signing .jar (#524)
Fixes GH-522.
1 parent 6e3c8ba commit a523df7

File tree

3 files changed

+27
-9
lines changed

3 files changed

+27
-9
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
.settings/
1414
/*-build/
1515
/.mvn/.develocity/
16+
/apache-arrow-java-*
1617
/apache-arrow-java.tar.gz
1718
/build/
1819
/dev/release/apache-rat-0.16.1.jar

ci/scripts/jni_full_build.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@
1717
# specific language governing permissions and limitations
1818
# under the License.
1919

20-
set -e
20+
set -eu
2121

2222
source_dir="$(cd "${1}" && pwd)"
2323
jni_build_dir="$(cd "${2}" && pwd)"
2424
dist_dir="${3}"
25+
rm -rf "${dist_dir}"
2526
mkdir -p "${dist_dir}"
2627
dist_dir="$(cd "${dist_dir}" && pwd)"
2728

@@ -69,3 +70,8 @@ find ~/.m2/repository/org/apache/arrow \
6970
")" \
7071
-exec echo "{}" ";" \
7172
-exec cp "{}" "${dist_dir}" ";"
73+
74+
for artifact in "${dist_dir}"/*; do
75+
sha256sum "${artifact}" >"${artifact}.sha256"
76+
sha512sum "${artifact}" >"${artifact}.sha512"
77+
done

dev/release/release_rc.sh

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ fi
8080

8181
rc_hash="$(git rev-list --max-count=1 "${rc_tag}")"
8282

83-
id="apache-arrow-java-${version}"
84-
tar_gz="${id}.tar.gz"
83+
artifacts_dir="apache-arrow-java-${version}-rc${rc}"
84+
signed_artifacts_dir="${artifacts_dir}-signed"
8585

8686
if [ "${RELEASE_SIGN}" -gt 0 ]; then
8787
git_origin_url="$(git remote get-url origin)"
@@ -105,23 +105,34 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
105105
echo "Found GitHub Actions workflow with ID: ${run_id}"
106106
gh run watch --repo "${repository}" --exit-status "${run_id}"
107107

108-
echo "Downloading .tar.gz from GitHub Releases"
108+
echo "Downloading artifacts from GitHub Releases"
109109
gh release download "${rc_tag}" \
110-
--dir . \
111-
--pattern "${tar_gz}" \
110+
--dir "${artifacts_dir}" \
112111
--repo "${repository}" \
113112
--skip-existing
114113

115-
echo "Signing tar.gz and creating checksums"
116-
gpg --armor --output "${tar_gz}.asc" --detach-sig "${tar_gz}"
114+
echo "Signing artifacts"
115+
rm -rf "${signed_artifacts_dir}"
116+
mkdir -p "${signed_artifacts_dir}"
117+
for artifact in "${artifacts_dir}"/*; do
118+
case "${artifact}" in
119+
*.asc | *.sha256 | *.sha512)
120+
continue
121+
;;
122+
esac
123+
gpg --armor \
124+
--detach-sig \
125+
--output "${signed_artifacts_dir}/$(basename "${artifact}").asc" \
126+
"${artifact}"
127+
done
117128
fi
118129

119130
if [ "${RELEASE_UPLOAD}" -gt 0 ]; then
120131
echo "Uploading signature"
121132
gh release upload "${rc_tag}" \
122133
--clobber \
123134
--repo "${repository}" \
124-
"${tar_gz}.asc"
135+
"${signed_artifacts_dir}"/*.asc
125136
fi
126137

127138
echo "Draft email for dev@arrow.apache.org mailing list"

0 commit comments

Comments
 (0)